This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 107080

Summary: Rename refactoring of folders under web folder does not work for VW JSP Pages
Product: obsolete Reporter: _ sandipchitale <sandipchitale>
Component: visualwebAssignee: _ sandipchitale <sandipchitale>
Status: VERIFIED FIXED    
Severity: blocker    
Priority: P2    
Version: 6.x   
Hardware: All   
OS: Windows XP   
Issue Type: DEFECT Exception Reporter:
Bug Depends on: 108185    
Bug Blocks:    

Description _ sandipchitale 2007-06-18 21:16:30 UTC
Move and rename refactoring of folders under web folder does not work for VW JSP Pages
Comment 1 _ sandipchitale 2007-06-19 00:35:08 UTC
*** Issue 107105 has been marked as a duplicate of this issue. ***
Comment 2 _ sandipchitale 2007-06-28 00:51:29 UTC
Partial fix.

Move Refactoring of folders under web/ is working.
Rename Refactoring of folders under web/ is not yet working.


Checking in FacesJavaFileMoveRefactoringPlugin.java;
/cvs/visualweb/insync/src/org/netbeans/modules/visualweb/insync/faces/refactoring/FacesJavaFileMoveRefactoringPlugin.ja
va,v  <--  FacesJavaFileMoveRefactoringPlugin.java
new revision: 1.8; previous revision: 1.7
done
Checking in FacesJspFileMoveRefactoringPlugin.java;
/cvs/visualweb/insync/src/org/netbeans/modules/visualweb/insync/faces/refactoring/FacesJspFileMoveRefactoringPlugin.jav
a,v  <--  FacesJspFileMoveRefactoringPlugin.java
new revision: 1.8; previous revision: 1.7
done
Checking in FacesRefactoringUtils.java;
/cvs/visualweb/insync/src/org/netbeans/modules/visualweb/insync/faces/refactoring/FacesRefactoringUtils.java,v  <--  
FacesRefactoringUtils.java
new revision: 1.10; previous revision: 1.9
done
Checking in FacesRefactoringsPluginFactory.java;
/cvs/visualweb/insync/src/org/netbeans/modules/visualweb/insync/faces/refactoring/FacesRefactoringsPluginFactory.java,v
  <--  FacesRefactoringsPluginFactory.java
new revision: 1.8; previous revision: 1.7
done
Comment 3 _ sandipchitale 2007-09-01 01:41:59 UTC
Actually the folder move works. Modifying the Summary to indicate folder rename not working.
Comment 4 _ sandipchitale 2007-09-01 22:33:53 UTC
While renaming folder containing JSP page the FacesModel for the original
JSP files lands up in a situation whereby the markup file points to the
new location (thru MarkupUnit) vs. java file points to the old location
(thru JavaUnit). While removing the original FacesModel it removes the
units. The units remove the DataObject which in turn remove the FileObjects.
Thus the markup file in the new location was getting deleted.

Added a check - before deleteing the Dataobjects - to make sure that the
files of both units in fact correspond to each other using the standard
relative path and name matching mechanism.

Checking in src/org/netbeans/modules/visualweb/insync/models/FacesModelSet.java;
/cvs/visualweb/insync/src/org/netbeans/modules/visualweb/insync/models/FacesModelSet.java,v  <--  FacesModelSet.java
new revision: 1.18; previous revision: 1.17
done

Curently the refactoring goes through completely. However the designer keeps showing Loading...Please wait message, when
the pages in renamed folder are opened. Will file a separate issue for that. Closing and reopening the projects fixes
the problem.
Comment 5 Lark Fitzgerald 2007-10-31 20:41:27 UTC
rename works but see same exception in log as with issue:
http://www.netbeans.org/issues/show_bug.cgi?id=120693
tested using:
Product Version: NetBeans IDE Dev (Build 20071031110342)
Java: 1.6.0_03; Java HotSpot(TM) Client VM 1.6.0_03-b02
System: Windows Vista version 6.0 running on x86; Cp1252; en_US (nb)
Glassfish: 58g
Woodstock 4.1: Build 15 RC1