This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | AddDriverDialog NPE occurs if registering driver using a layer file | ||
|---|---|---|---|
| Product: | db | Reporter: | John Baker <jbaker> |
| Component: | Code | Assignee: | John Baker <jbaker> |
| Status: | RESOLVED FIXED | ||
| Severity: | blocker | CC: | davidvc |
| Priority: | P3 | ||
| Version: | 6.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Bug Depends on: | |||
| Bug Blocks: | 116053 | ||
| Attachments: |
XML file which describes the driver in the module layer
diff of changes |
||
Created attachment 49718 [details]
XML file which describes the driver in the module layer
blocks 116053 Created attachment 49719 [details]
diff of changes
Fixed. Unit tests ran and passing, the testComboboxWithConnections unit test could be updated. Will file separate issue to track Checking in db/src/org/netbeans/modules/db/explorer/dlg/AddDriverDialog.java; /cvs/db/src/org/netbeans/modules/db/explorer/dlg/AddDriverDialog.java,v <-- AddDriverDialog.java new revision: 1.43; previous revision: 1.42 done Don't like the fix much. FileSystem.getDisplayName() is what the name suggests it is: a string to be shown in the UI. There is no guarantee it will be the path of the JAR file. Checking in src/org/netbeans/modules/db/explorer/dlg/AddDriverDialog.java; /cvs/db/src/org/netbeans/modules/db/explorer/dlg/AddDriverDialog.java,v <-- AddDriverDialog.java new revision: 1.45; previous revision: 1.44 done |
Using the layer file approach to registering a driver almost works. The driver gets added to the Services tab. However, when choosing the Customize action, an NPE occurs. I had created an "XML file which describes the driver in the module layer" attached. The problem is the reference to the driver uses the jar protocol. So, once inside the AddDriverDialog non-default ctr, the FileObject is an AbstractFileObject so, FileUtil.toFile(fo) is null. A suggested fix is to add the following condition to the non-default ctr . else if (!fo.isData()) { // try/catch is required fileName = fo.getFileSystem().getDisplayName(); } This will set filename to the absolute path of the driver jar file. Attached will be a diff.