This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Registry should allow plugin to set bundle of properties "atomically" | ||
---|---|---|---|
Product: | serverplugins | Reporter: | Petr Hejl <phejl> |
Component: | Infrastructure | Assignee: | Petr Hejl <phejl> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | apireviews |
Priority: | P1 | Keywords: | API, API_REVIEW_FAST |
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | ENHANCEMENT | Exception Reporter: | |
Attachments: |
proposed patch
proposed patch (previous patch missing spec version) comments reflected |
Description
Petr Hejl
2007-10-29 17:09:00 UTC
One of the bugs related to this is the issue 120321. Created attachment 53206 [details]
proposed patch
Created attachment 53209 [details]
proposed patch (previous patch missing spec version)
Y01 Why there is a need to change tests, if this is supposed to be compatible change? Y02 Why the tests were not changed to also test the new behaviour? Add one new assert, please. Re Y01: Those tests are using method that is not part of the public api. Re Y02: Fixed in the following patch. Created attachment 53262 [details]
comments reflected
Thanks for your comments. I will implement changes contained in the last posted patch. Implemented. Checking in apichanges.xml; /cvs/j2eeserver/apichanges.xml,v <-- apichanges.xml new revision: 1.37; previous revision: 1.36 done Checking in nbproject/project.properties; /cvs/j2eeserver/nbproject/project.properties,v <-- project.properties new revision: 1.29; previous revision: 1.28 done Checking in src/org/netbeans/modules/j2ee/deployment/impl/ServerRegistry.java; /cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerRegistry.java,v <-- ServerRegistry.java new revision: 1.56; previous revision: 1.55 done Checking in src/org/netbeans/modules/j2ee/deployment/plugins/api/InstanceProperties.java; /cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/plugins/api/InstanceProperties.java,v <-- InstanceProperties.java new revision: 1.23; previous revision: 1.22 done Checking in test/unit/src/org/netbeans/modules/j2ee/deployment/impl/ServerInstanceTest.java; /cvs/j2eeserver/test/unit/src/org/netbeans/modules/j2ee/deployment/impl/ServerInstanceTest.java,v <-- ServerInstanceTest.java new revision: 1.7; previous revision: 1.6 done Checking in test/unit/src/org/netbeans/modules/j2ee/deployment/impl/TargetServerTest.java; /cvs/j2eeserver/test/unit/src/org/netbeans/modules/j2ee/deployment/impl/TargetServerTest.java,v <-- TargetServerTest.java new revision: 1.8; previous revision: 1.7 done RCS file: /cvs/j2eeserver/test/unit/src/org/netbeans/modules/j2ee/deployment/plugins/api/InstancePropertiesTest.java,v done Checking in test/unit/src/org/netbeans/modules/j2ee/deployment/plugins/api/InstancePropertiesTest.java; /cvs/j2eeserver/test/unit/src/org/netbeans/modules/j2ee/deployment/plugins/api/InstancePropertiesTest.java,v <-- InstancePropertiesTest.java initial revision: 1.1 done |