This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | NPE from refactoring change parameters | ||
---|---|---|---|
Product: | java | Reporter: | err <err> |
Component: | Refactoring | Assignee: | issues@java <issues> |
Status: | VERIFIED FIXED | ||
Severity: | blocker | CC: | jiriprox, jpokorsky, mmirilovic |
Priority: | P1 | ||
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | messages log with exception |
Description
err
2007-11-05 23:42:35 UTC
Created attachment 52561 [details]
messages log with exception
This is common usecase, it should be fixed in 6.0 -> increasing priority Checking in ChangeParamsTransformer.java; /cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/plugins/ChangeParamsTransformer.java,v <-- ChangeParamsTransformer.java new revision: 1.10; previous revision: 1.9 done Keywords| |60_HR_FIX So I'm guessing things are at the stage where only "approved" changes can go in. And this keyword flags the change as a candidate for 6.0. http://refactoring.netbeans.org/source/browse/refactoring/java/src/org/netbeans/modules/refactoring/java/plugins/ChangeParamsTransformer.java?r1=1.9&r2=1.10 I'd like to ask for review. Fix is similar to issue 119269. Problem is in method isMethodMatch, which throws NPE if it cannot resolve some element. But it should simply return false, because element can be unknown in context of current file. Reviewed, the fix should work. verified in trunk, the fix can go to 6.0 Fixed in 6.0 Checking in ChangeParamsTransformer.java; /cvs/refactoring/java/src/org/netbeans/modules/refactoring/java/plugins/ChangeParamsTransformer.java,v <-- ChangeParamsTransformer.java new revision: 1.9.4.1; previous revision: 1.9 done verified in RC1 |