This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 129284

Summary:	Eliminate single byte reads from FileInputStream
Product:	platform	Reporter:	Pavel Flaska <pflaska>
Component:	Plugin Manager	Assignee:	Jiri Rechtacek <jrechtacek>
Status:	VERIFIED FIXED
Severity:	blocker	Keywords:	PERFORMANCE
Priority:	P4
Version:	6.x
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Bug Depends on:
Bug Blocks:	129286
Attachments:	The most visible place

Description Pavel Flaska 2008-03-05 13:34:14 UTC

There are several places where FileInputStream is used for reading xml files. Because XML parser uses inputStream.read()
method for reading one byte, it seems to be better to provide BufferedInputStream to InputSource. Such minor
optimization can reduce the number of I/O operations and perhaps it will be little bit faster.

Comment 1 Pavel Flaska 2008-03-05 13:36:02 UTC

Created attachment 57809 [details]
The most visible place

Comment 2 Jiri Rechtacek 2008-03-06 15:52:19 UTC

http://hg.netbeans.org/core-main/rev/0fff21a92641

Comment 3 Jiri Rechtacek 2008-03-06 15:53:47 UTC

Btw: I did more performance improvements (don't touch update_tracking/*.xml during generating data model and eliminate
single byte reads from FileInputStream)

Comment 4 Pavel Flaska 2008-03-07 11:22:55 UTC

I can confirm only buffered streams are used.