This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Regression: profiler classes are loaded during NetBeans startup with LimeWire project | ||
---|---|---|---|
Product: | profiler | Reporter: | Alexander Kouznetsov <mrkam> |
Component: | Base | Assignee: | J Bachorik <yardus> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | anebuzelsky, issues, jtulach |
Priority: | P3 | Keywords: | PERFORMANCE, REGRESSION, TEST |
Version: | 6.x | ||
Hardware: | PC | ||
OS: | Windows XP | ||
URL: | http://wiki.netbeans.org/FitnessViaWhiteAndBlackList | ||
Issue Type: | DEFECT | Exception Reporter: | |
Attachments: | Stacktraces |
Description
Alexander Kouznetsov
2008-11-18 13:24:21 UTC
Created attachment 73865 [details]
Stacktraces
First of all, I don't think this is a regression (thus lowering to P3). The functionality causing the violation has been in the profiler for ages. If you think otherwise, please provide the profiler version this regression is against. The second part is more complicated - what else should be used to implement a project-type dependent functionality? If I use LookupProvider I end up with issue like #152984. If I do it my own custom way (polling all registered profiler types whether they can work with a certain project type) I'm getting this issue filed. This really confuses me - what am I supposed to do? Not to write a project type specific functionality at all? Plz, advice ... > Regression occurred between 081105 and 081117.
Let's wait for advice from jtulach.
Given that there was no activity in the profiler code base during the dates mentioned I really don't think it's caused by profiler. The functionality has been there since the first version so it must be something else that had changed and caused this particular functionality to be invoked. QA, plz, try to locate the exact revision which caused the regression in results. However, I'm not going to fix this issue till issue #152984 is resolved - solving this would just bring me another P2 regression so it's plainly a waste of time. org.netbeans.modules.profiler.RerunSupport was not loaded with 081125 Alexander asked me to express my advices: The preferred way is to register the ProjectTypeProfiler into appropriate project type lookup. This would work in much better (more lazy) way, especially with connection to issue 150194. Untill the issue 150194 is fixed, let's keep this issue open and let's hope we will have a chance to fix it for 7.0. Lowering the priority as the offending class RerunSupport has mysteriously disappear. It's not even possible to get history information from mercurial (try eg. http://hg.netbeans.org/main/log/5bdcbcceb230/profiler/src/org/netbeans/modules/profiler/RerunSupport.java). Given this, it definitely can not be loaded at the IDE startup. As for the rest of the classes mentioned here - resolving this issue would require a rewrite of the profiler IDE integration and in current situation it won't happen soon. Milestone cleanup: future->next ProjectTypeProfiler has been replaced by per-project registration of various profiler services. Further reduction of the profiler classes loaded at startup has been done in http://hg.netbeans.org/profiler-main/rev/29cb4f37f1aa Closing the issue. Integrated into 'main-golden' Changeset: http://hg.netbeans.org/main-golden/rev/29cb4f37f1aa User: Jaroslav Bachorik <yardus@netbeans.org> Log: Reducing the number of profiler classes loaded at startup. Related to #153383,#201356,#201357. |