This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 20517

Summary: Manifest entry of type Roots does not create a new tab in the Explorer
Product: platform Reporter: Kale <nkale>
Component: Module SystemAssignee: Peter Zavadsky <pzavadsky>
Status: VERIFIED WORKSFORME    
Severity: blocker CC: dsimonek, dstrupl, hittleman, issues, jglick, jpokorsky, jzajicek, non_migrated_user
Priority: P3 Keywords: UI
Version: 3.x   
Hardware: All   
OS: All   
Issue Type: DEFECT Exception Reporter:
Bug Depends on: 19609, 22758, 28083    
Bug Blocks:    
Attachments: An example module file that demonstrates the defect

Description Kale 2002-02-13 19:46:17 UTC
Netbeans version 3.3 (build 200112102331)

My module's manifest has a declaration of type roots, as follows :-
Name: explorerTab/AppRoot.class
OpenIDE-Module-Class: Node
Type: Roots

When I install the module through Open API Support in test mode, the extra tab 
on the explorer appears correctly.
But when the same module is pre-installed with Netbeans, ie., (if the module is 
copied into modules/.. directory, or to the userDir/modules directory) the 
extra tab does not appear.

The defect is quite critical to our product, as we wanted to ship Netbeans pre-
installed with our module. The extra tab provides the main functionality of our 
module.
Comment 1 Kale 2002-02-13 19:48:32 UTC
Created attachment 4697 [details]
An example module file that demonstrates the defect
Comment 2 Jesse Glick 2002-02-14 12:02:17 UTC
In fact it does show up - after View | Explorer is selected. Note that
the built-in Workplace tab (used when projects module is not
installed) also does not show up immediately. When the projects module
is installed, the Project tab appears, but not this root. So there is
some problem refreshing NbMainExplorer on time.

Javadoc module does not suffer from this problem. Turns out it
declares a top component ref in the Explorer *in addition to* adding a
manifest section. Kale, a workaround would be to copy the stuff
Javadoc module does in its XML layer under Windows/ to register its tab.

In other words, some rewrite of the window system broke backward
compatibility for root node installation from manifest - the tab still
appears manually but not automatically. This must be fixed for 3.4
IMHO. I suggest the workaround in javadoc be deleted, and NbInstaller
when adding a Node manifest section should autocreate suitable window
system XML files on the FixedFileSystem.

A proper fix for issue #19609 might be enough to fix this.
Comment 3 Jan Chalupa 2002-04-10 10:58:56 UTC
Fix of this bug depends on a task that is not implemented yet.  A
waiver for FFJ 4.0 requested.
Comment 4 Jesse Glick 2002-04-10 20:14:19 UTC
IMO the bug could be fixed directly in 3.3.x, without implementing
issue #19609 as a whole, but it would be "dead-end" code (effort not
usable for 3.4 anyway).
Comment 5 Jiri Rechtacek 2002-05-29 13:40:58 UTC
Fix this issue now depends on fix issue 22758 (derived from 19609);
should use above recommended workaround about use xml layer under
Windows/.
Comment 6 Marek Grummich 2002-07-22 09:00:04 UTC
Target milestone was changed from '3.4' to TBD.
Comment 7 Marek Grummich 2002-07-22 09:05:05 UTC
Target milestone was changed from '3.4' to TBD.
Comment 8 Marek Grummich 2002-07-22 09:07:22 UTC
Target milestone was changed from '3.4' to TBD.
Comment 9 Marek Grummich 2002-07-22 09:08:06 UTC
Target milestone was changed from '3.4' to TBD.
Comment 10 Marek Grummich 2002-07-22 09:13:02 UTC
Set terget milestone to TBD
Comment 11 Marek Grummich 2002-07-22 09:14:07 UTC
Target milestone was changed from '3.4' to TBD.
Comment 12 Marek Grummich 2002-07-22 09:15:44 UTC
Set terget milestone to TBD
Comment 13 Marek Grummich 2002-07-22 09:33:21 UTC
Target milestone was changed from '3.4' to TBD.
Comment 14 Jaroslav Tulach 2002-07-26 07:58:35 UTC
This bug is reported in version <= 3.4dev and still not fixed. Due to that it
forbids the release candidate for 3.4 to be promoted. Are you aware of that and
are you intensively working on the fix? If not, you should consider some
corrective action.
Comment 15 Jiri Rechtacek 2002-07-26 08:08:58 UTC
I decrease the priority, there is a workaround and this issue depends
on task 22758 with P3.
Comment 16 Jesse Glick 2002-07-29 02:24:59 UTC
I don't agree with the P3 rating - we broke backward compatibility for
manifest installation. That is a bug: a module using this manifest
entry would add a node in 3.3, and does not in 3.4, contrary to the
documentation in the Nodes/Modules API for 3.3.

The fact that restoring compatibility would be done most easily in
conjunction with a UI change, which happens to be marked P3, is
irrelevant. The fact that you do not plan to fix it for 3.4 is also
irrelevant.

The workaround is also not really good for most modules because it (1)
requires a nontrivial amount of work to implement for a module author
and (2) still won't look quite right unless #22758 is implemented for
other tabs.
Comment 17 Jesse Glick 2002-10-17 15:59:20 UTC
The UI will now look consistent - see issue #22758 and issue #28048.
Comment 18 Jiri Rechtacek 2003-02-19 16:15:01 UTC
please Peter, take care about this. thanks
Comment 19 Peter Zavadsky 2003-02-21 16:38:53 UTC
To me it seems it is working, see the issue #22758.
Closing as worksforme.

Please reopen if you have different result.
Comment 20 Jesse Glick 2003-02-21 16:50:38 UTC
NodeSectionTranslator is supposed to be the fix of this, correct?
Comment 21 Peter Zavadsky 2003-02-24 16:29:47 UTC
Yes, correct.
Comment 22 Marian Mirilovic 2003-07-29 09:48:04 UTC
verified - it works fine in [nb_dev](20030728)