This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Suggested method: FileUtil.getFileDisplayName | ||
---|---|---|---|
Product: | platform | Reporter: | Jesse Glick <jglick> |
Component: | Filesystems | Assignee: | rmatous <rmatous> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | apireviews, mslama, phrebejk, rmatous |
Priority: | P1 | Keywords: | API, API_REVIEW_FAST |
Version: | 3.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | ENHANCEMENT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 41535, 44151 | ||
Attachments: | Suggested patch |
Description
Jesse Glick
2003-11-26 17:59:12 UTC
Created attachment 12324 [details]
Suggested patch
Should also check for archives explicitly, probably. Will commit something like this to FolderNode.updateDisplayName for root folders. We need this, please fast-track. Should take half an hour. Does it mean that I should agree and integrate ? Then it may be half an hour. If I should follow the fast-track process then its common that it takes a week. We can wait a week. I just meant that the actual patch should take a half hour; very simple utility method. If you like, I can supply an updated patch with unit test. Might be nice to also specially handle JAR file objects to show e.g. java/lang/Object.class in /space/jdk1.5/jre/lib/rt.jar (Currently it seems the display name of JarFileSystem gives only the simple JAR name, but if it gave the full path to the JAR it would not be necessary to do such a trick.) I changed JarFileSystem.displayName as noted. The utility method would be useful in CloneableEditor.toolTip, etc. Well it's been a week, can it go in? If you prefer, reassign to me to commit. /cvs/openide/openide-spec-vers.properties,v <-- openide-spec-vers.properties new revision: 1.149; previous revision: 1.148 /cvs/openide/api/doc/changes/apichanges.xml,v <-- apichanges.xml new revision: 1.208; previous revision: 1.207 done /cvs/openide/src/org/openide/filesystems/Bundle.properties,v <-- Bundle.properties new revision: 1.33; previous revision: 1.32 /cvs/openide/src/org/openide/filesystems/FileUtil.java,v <-- FileUtil.java new revision: 1.100; previous revision: 1.99 /cvs/openide/test/unit/src/org/openide/filesystems/FileUtilTestHidden.java,v <-- FileUtilTestHidden.java new revision: 1.4; previous revision: 1.3 /cvs/openide/test/unit/src/org/openide/filesystems/JarFileSystemTest.java,v <-- JarFileSystemTest.java new revision: 1.15; previous revision: 1.14 Thanks; I will commit some usages of the new method to various modules that could use it that I know of. FYI: 1.11 form/nbproject/project.xml 1.99 form/src/org/netbeans/modules/form/FormDesigner.java 1.2 image/nbproject/project.xml 1.43 image/src/org/netbeans/modules/image/ImageViewer.java 1.4 openide/loaders/nbproject/project.xml 1.11 openide/loaders/src/org/openide/loaders/Bundle.properties 1.27 openide/loaders/src/org/openide/loaders/DataFolder.java 1.14 openide/loaders/src/org/openide/loaders/DataNode.java 1.11 openide/loaders/src/org/openide/loaders/DataShadow.java 1.16 openide/loaders/src/org/openide/text/DataEditorSupport.java 1.95 openide/src/org/openide/filesystems/AbstractFileObject.java 1.79 openide/src/org/openide/filesystems/AbstractFolder.java 1.19 openide/src/org/openide/filesystems/FileEvent.java 1.87 openide/src/org/openide/filesystems/FileObject.java 1.81 openide/src/org/openide/filesystems/FileSystem.java 1.58 properties/manifest.mf 1.68 properties/src/org/netbeans/modules/properties/Bundle.properties 1.71 properties/src/org/netbeans/modules/properties/PropertiesEditorSupport.java 1.34 properties/src/org/netbeans/modules/properties/PropertiesLocaleNode.java 1.69 properties/src/org/netbeans/modules/properties/PropertiesOpen.java 1.4 utilities/nbproject/project.xml 1.9 utilities/src/org/netbeans/modules/pdf/LinkProcessor.java 1.15 utilities/src/org/netbeans/modules/search/LocationInfoPanel.java also: 1.14 org.netbeans.modules.java.project.JavaTargetChooserPanelGUI.java 1.20 org.netbeans.modules.project.ui.SimpleTargetChooserPanelGUI.java |