This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | API Change: ProblemDetails & ReadOnlyFileHandlers | ||
|---|---|---|---|
| Product: | editor | Reporter: | Jan Becicka <jbecicka> |
| Component: | Refactoring | Assignee: | apireviews <apireviews> |
| Status: | RESOLVED FIXED | ||
| Severity: | blocker | CC: | mentlicher |
| Priority: | P3 | Keywords: | API, API_REVIEW_FAST |
| Version: | 5.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | TASK | Exception Reporter: | |
| Attachments: |
Proposed change
Javadoc |
||
|
Description
Jan Becicka
2005-05-20 08:28:22 UTC
Created attachment 22205 [details]
Proposed change
Created attachment 22206 [details]
Javadoc
Please review the change. The change looks OK. I have only two minor comments: - the constructor in ProblemDetailsFactory should be private - description of "files" parameter in ReadOnlyFilesHandler.createProblem() is missing Checking in refactoring/apichanges.xml; /cvs/refactoring/apichanges.xml,v <-- apichanges.xml new revision: 1.2; previous revision: 1.1 done Checking in refactoring/arch/arch-refactoring.xml; /cvs/refactoring/arch/arch-refactoring.xml,v <-- arch-refactoring.xml new revision: 1.16; previous revision: 1.15 done Checking in refactoring/experimental/src/org/netbeans/modules/refactoring/experimental/plugins/AnonymousToInnerRefactoringPlugin.java; /cvs/refactoring/experimental/src/org/netbeans/modules/refactoring/experimental/plugins/AnonymousToInnerRefactoringPlugin.java,v <-- AnonymousToInnerRefactoringPlugin.java new revision: 1.3; previous revision: 1.2 done Checking in refactoring/experimental/src/org/netbeans/modules/refactoring/experimental/plugins/CopyClassRefactoringPlugin.java; /cvs/refactoring/experimental/src/org/netbeans/modules/refactoring/experimental/plugins/CopyClassRefactoringPlugin.java,v <-- CopyClassRefactoringPlugin.java new revision: 1.2; previous revision: 1.1 done Checking in refactoring/experimental/src/org/netbeans/modules/refactoring/experimental/plugins/ExtractMethodRefactoringPlugin.java; /cvs/refactoring/experimental/src/org/netbeans/modules/refactoring/experimental/plugins/ExtractMethodRefactoringPlugin.java,v <-- ExtractMethodRefactoringPlugin.java new revision: 1.9; previous revision: 1.8 done Checking in refactoring/experimental/src/org/netbeans/modules/refactoring/experimental/plugins/IntroduceVariableRefactoringPlugin.java; /cvs/refactoring/experimental/src/org/netbeans/modules/refactoring/experimental/plugins/IntroduceVariableRefactoringPlugin.java,v <-- IntroduceVariableRefactoringPlugin.java new revision: 1.4; previous revision: 1.3 done Checking in refactoring/experimental/src/org/netbeans/modules/refactoring/experimental/plugins/PluginsFactory.java; /cvs/refactoring/experimental/src/org/netbeans/modules/refactoring/experimental/plugins/PluginsFactory.java,v <-- PluginsFactory.java new revision: 1.10; previous revision: 1.9 done Checking in refactoring/experimental/src/org/netbeans/modules/refactoring/experimental/plugins/PullUpRefactoringPlugin.java; /cvs/refactoring/experimental/src/org/netbeans/modules/refactoring/experimental/plugins/PullUpRefactoringPlugin.java,v <-- PullUpRefactoringPlugin.java new revision: 1.7; previous revision: 1.6 done Checking in refactoring/experimental/src/org/netbeans/modules/refactoring/experimental/plugins/PushDownRefactoringPlugin.java; /cvs/refactoring/experimental/src/org/netbeans/modules/refactoring/experimental/plugins/PushDownRefactoringPlugin.java,v <-- PushDownRefactoringPlugin.java new revision: 1.4; previous revision: 1.3 done Checking in refactoring/nbproject/project.properties; /cvs/refactoring/nbproject/project.properties,v <-- project.properties new revision: 1.11; previous revision: 1.10 done Checking in refactoring/src/org/netbeans/modules/refactoring/APIAccessor.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/APIAccessor.java,v <-- APIAccessor.java new revision: 1.2; previous revision: 1.1 done Checking in refactoring/src/org/netbeans/modules/refactoring/ChangeModElement.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/ChangeModElement.java,v <-- ChangeModElement.java new revision: 1.13; previous revision: 1.12 done Checking in refactoring/src/org/netbeans/modules/refactoring/CommentElement.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/CommentElement.java,v <-- CommentElement.java new revision: 1.5; previous revision: 1.4 done Checking in refactoring/src/org/netbeans/modules/refactoring/CreateMethodElement.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/CreateMethodElement.java,v <-- CreateMethodElement.java new revision: 1.15; previous revision: 1.14 done Checking in refactoring/src/org/netbeans/modules/refactoring/JavadocElement.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/JavadocElement.java,v <-- JavadocElement.java new revision: 1.4; previous revision: 1.3 done Checking in refactoring/src/org/netbeans/modules/refactoring/SPIAccessor.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/SPIAccessor.java,v <-- SPIAccessor.java new revision: 1.2; previous revision: 1.1 done Checking in refactoring/src/org/netbeans/modules/refactoring/WhereUsedElement.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/WhereUsedElement.java,v <-- WhereUsedElement.java new revision: 1.20; previous revision: 1.19 done Checking in refactoring/src/org/netbeans/modules/refactoring/api/AbstractRefactoring.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/api/AbstractRefactoring.java,v <-- AbstractRefactoring.java new revision: 1.24; previous revision: 1.23 done Checking in refactoring/src/org/netbeans/modules/refactoring/api/AccessorImpl.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/api/AccessorImpl.java,v <-- AccessorImpl.java new revision: 1.2; previous revision: 1.1 done Checking in refactoring/src/org/netbeans/modules/refactoring/api/Problem.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/api/Problem.java,v <-- Problem.java new revision: 1.5; previous revision: 1.4 done RCS file: /cvs/refactoring/src/org/netbeans/modules/refactoring/api/ProblemDetails.java,v done Checking in refactoring/src/org/netbeans/modules/refactoring/api/ProblemDetails.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/api/ProblemDetails.java,v <-- ProblemDetails.java initial revision: 1.1 done Checking in refactoring/src/org/netbeans/modules/refactoring/api/RefactoringElement.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/api/RefactoringElement.java,v <-- RefactoringElement.java new revision: 1.10; previous revision: 1.9 done Checking in refactoring/src/org/netbeans/modules/refactoring/plugins/ChangeParametersPlugin.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/plugins/ChangeParametersPlugin.java,v <-- ChangeParametersPlugin.java new revision: 1.16; previous revision: 1.15 done Checking in refactoring/src/org/netbeans/modules/refactoring/plugins/MoveClassRefactoringPlugin.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/plugins/MoveClassRefactoringPlugin.java,v <-- MoveClassRefactoringPlugin.java new revision: 1.24; previous revision: 1.23 done Checking in refactoring/src/org/netbeans/modules/refactoring/plugins/RenameRefactoringPlugin.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/plugins/RenameRefactoringPlugin.java,v <-- RenameRefactoringPlugin.java new revision: 1.27; previous revision: 1.26 done Removing refactoring/src/org/netbeans/modules/refactoring/plugins/SimpleRefactoringElementImpl.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/plugins/SimpleRefactoringElementImpl.java,v <-- SimpleRefactoringElementImpl.java new revision: delete; previous revision: 1.3 done Checking in refactoring/src/org/netbeans/modules/refactoring/spi/AccessorImpl.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/spi/AccessorImpl.java,v <-- AccessorImpl.java new revision: 1.2; previous revision: 1.1 done RCS file: /cvs/refactoring/src/org/netbeans/modules/refactoring/spi/Bundle.properties,v done Checking in refactoring/src/org/netbeans/modules/refactoring/spi/Bundle.properties; /cvs/refactoring/src/org/netbeans/modules/refactoring/spi/Bundle.properties,v <-- Bundle.properties initial revision: 1.1 done RCS file: /cvs/refactoring/src/org/netbeans/modules/refactoring/spi/ProblemDetailsFactory.java,v done Checking in refactoring/src/org/netbeans/modules/refactoring/spi/ProblemDetailsFactory.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/spi/ProblemDetailsFactory.java,v <-- ProblemDetailsFactory.java initial revision: 1.1 done RCS file: /cvs/refactoring/src/org/netbeans/modules/refactoring/spi/ProblemDetailsImplementation.java,v done Checking in refactoring/src/org/netbeans/modules/refactoring/spi/ProblemDetailsImplementation.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/spi/ProblemDetailsImplementation.java,v <-- ProblemDetailsImplementation.java initial revision: 1.1 done RCS file: /cvs/refactoring/src/org/netbeans/modules/refactoring/spi/ReadOnlyFilesHandler.java,v done Checking in refactoring/src/org/netbeans/modules/refactoring/spi/ReadOnlyFilesHandler.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/spi/ReadOnlyFilesHandler.java,v <-- ReadOnlyFilesHandler.java initial revision: 1.1 done Checking in refactoring/src/org/netbeans/modules/refactoring/spi/RefactoringElementImplementation.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/spi/RefactoringElementImplementation.java,v <-- RefactoringElementImplementation.java new revision: 1.2; previous revision: 1.1 done Checking in refactoring/src/org/netbeans/modules/refactoring/spi/RefactoringElementsBag.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/spi/RefactoringElementsBag.java,v <-- RefactoringElementsBag.java new revision: 1.3; previous revision: 1.2 done RCS file: /cvs/refactoring/src/org/netbeans/modules/refactoring/spi/SimpleRefactoringElementImpl.java,v done Checking in refactoring/src/org/netbeans/modules/refactoring/spi/SimpleRefactoringElementImpl.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/spi/SimpleRefactoringElementImpl.java,v <-- SimpleRefactoringElementImpl.java initial revision: 1.1 done Checking in refactoring/src/org/netbeans/modules/refactoring/spi/ui/ParametersPanel.form; /cvs/refactoring/src/org/netbeans/modules/refactoring/spi/ui/ParametersPanel.form,v <-- ParametersPanel.form new revision: 1.3; previous revision: 1.2 done Checking in refactoring/src/org/netbeans/modules/refactoring/spi/ui/ParametersPanel.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/spi/ui/ParametersPanel.java,v <-- ParametersPanel.java new revision: 1.9; previous revision: 1.8 done Checking in refactoring/src/org/netbeans/modules/refactoring/ui/Bundle.properties; /cvs/refactoring/src/org/netbeans/modules/refactoring/ui/Bundle.properties,v <-- Bundle.properties new revision: 1.53; previous revision: 1.52 done Checking in refactoring/src/org/netbeans/modules/refactoring/ui/CheckNodeListener.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/ui/CheckNodeListener.java,v <-- CheckNodeListener.java new revision: 1.13; previous revision: 1.12 done Checking in refactoring/src/org/netbeans/modules/refactoring/ui/ErrorPanel.form; /cvs/refactoring/src/org/netbeans/modules/refactoring/ui/ErrorPanel.form,v <-- ErrorPanel.form new revision: 1.7; previous revision: 1.6 done Checking in refactoring/src/org/netbeans/modules/refactoring/ui/ErrorPanel.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/ui/ErrorPanel.java,v <-- ErrorPanel.java new revision: 1.8; previous revision: 1.7 done RCS file: /cvs/refactoring/src/org/netbeans/modules/refactoring/ui/ProblemComponent.form,v done Checking in refactoring/src/org/netbeans/modules/refactoring/ui/ProblemComponent.form; /cvs/refactoring/src/org/netbeans/modules/refactoring/ui/ProblemComponent.form,v <-- ProblemComponent.form initial revision: 1.1 done RCS file: /cvs/refactoring/src/org/netbeans/modules/refactoring/ui/ProblemComponent.java,v done Checking in refactoring/src/org/netbeans/modules/refactoring/ui/ProblemComponent.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/ui/ProblemComponent.java,v <-- ProblemComponent.java initial revision: 1.1 done Checking in refactoring/src/org/netbeans/modules/refactoring/ui/RefactoringPanel.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/ui/RefactoringPanel.java,v <-- RefactoringPanel.java new revision: 1.53; previous revision: 1.52 done Checking in j2ee/refactoring/nbproject/project.xml; /cvs/j2ee/refactoring/nbproject/project.xml,v <-- project.xml new revision: 1.11; previous revision: 1.10 done Checking in j2ee/refactoring/src/org/netbeans/modules/j2ee/refactoring/changeparam/AbstractChangeParamsRefactoringElement.java; /cvs/j2ee/refactoring/src/org/netbeans/modules/j2ee/refactoring/changeparam/AbstractChangeParamsRefactoringElement.java,v <-- AbstractChangeParamsRefactoringElement.java new revision: 1.4; previous revision: 1.3 done Checking in j2ee/refactoring/src/org/netbeans/modules/j2ee/refactoring/moveclass/AbstractMoveClassRefactoringElement.java; /cvs/j2ee/refactoring/src/org/netbeans/modules/j2ee/refactoring/moveclass/AbstractMoveClassRefactoringElement.java,v <-- AbstractMoveClassRefactoringElement.java new revision: 1.4; previous revision: 1.3 done Checking in j2ee/refactoring/src/org/netbeans/modules/j2ee/refactoring/rename/AbstractRenameRefactoringElement.java; /cvs/j2ee/refactoring/src/org/netbeans/modules/j2ee/refactoring/rename/AbstractRenameRefactoringElement.java,v <-- AbstractRenameRefactoringElement.java new revision: 1.4; previous revision: 1.3 done Checking in j2ee/refactoring/src/org/netbeans/modules/j2ee/refactoring/whereused/AbstractWhereUsedRefactoringElement.java; /cvs/j2ee/refactoring/src/org/netbeans/modules/j2ee/refactoring/whereused/AbstractWhereUsedRefactoringElement.java,v <-- AbstractWhereUsedRefactoringElement.java new revision: 1.4; previous revision: 1.3 done |