This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Include core/favorites in platform cluster | ||
---|---|---|---|
Product: | platform | Reporter: | Jaroslav Tulach <jtulach> |
Component: | Favorites | Assignee: | Jaroslav Tulach <jtulach> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | CC: | apireviews |
Priority: | P3 | Keywords: | API_REVIEW_FAST |
Version: | 5.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | TASK | Exception Reporter: | |
Attachments: |
This is the patch I'd like to apply
Changes including correct deps for projectui |
Description
Jaroslav Tulach
2005-09-23 09:55:06 UTC
I am ready to move the module if we agree on the VOC, CTQ and solution. Anybody seeing this change as a blocker please speak up. Should probably attach patch: to nbbuild/cluster.properties; possibly to nbbuild/build.properties; and to apisupport/project/src/org/netbeans/modules/apisupport/project/ui/customizer/SuiteCustomizerModuleList.java and apisupport/www/phase-V-ui.html (for the default exclusion). Q: It is not clear to me how is core/favorites connected to presence of loaders or template manager. Template Manager was moved to core/favorites, I think. Yes you are right. Thanks. > > Url: > > http://core.netbeans.org/source/browse/core/ui/src/org/netbeans/core/ui/r > >esources/layer.xml?r1=1.102&r2=1.103 <attr name="simple" boolvalue="false" > > /> > > <file name="Folder.shadow"> > > - <attr name="originalFile" > > stringvalue="Templates/Other/Folder"/> + <attr > > name="originalFile" stringvalue="Templates/Folder"/> </file> > > </folder> > > Hele, shouldn't these "templates" be in core/favorites rather than > core/ui, since that is where the other template-related stuff seems to > get put now? I guess you are right, I'll prepare this together with a patch for http://www.netbeans.org/issues/show_bug.cgi?id=64968 Created attachment 25224 [details]
This is the patch I'd like to apply
1. build.properties probably needs patching 2. projects/projectui/nbproject/project.xml still depends on org.netbeans.core.ui, I guess to mask the Folder template (?), so if this dep is kept it should be switched to org.netbeans.modules.favorites build.properties is (imho) only useful for list of modules to build javadoc. And favorites do not have javadoc. I do not know why or what shall I change there. projectui module overrides Explorer.wsmode and Folder template. So the deps on core/favorites and core/ui need to be there. I'll attach updated patch. Created attachment 25295 [details]
Changes including correct deps for projectui
Well, build.properties does include config.{,fixed}modules.platform, which until now listed all the modules in the platform cluster. If this moduleconfig is not used for anything, which may be the case, then I will delete it. If there are no objections I'd like to apply the patch tomorrow. I do not plan to update build.properties as the only important config there I know (javadoc) is not affected by this change. Update: you must patch build.properties#platform to include core/favorites. Also please run build.xml#check-module-configs (which should fail if build.properties is not patched) and commit updated ide/golden/moduleconfigs.txt accordingly. Integrated yesterday. http://core.netbeans.org/servlets/ReadMsg?list=cvs&msgNo=12867 |