This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 68031

Summary:	Too many action updates when listening to ActionMap changes
Product:	platform	Reporter:	_ rkubacki <rkubacki>
Component:	Lookup	Assignee:	Jaroslav Tulach <jtulach>
Status:	RESOLVED FIXED
Severity:	blocker	Keywords:	PERFORMANCE
Priority:	P3
Version:	5.x
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:

Description _ rkubacki 2005-11-03 12:29:29 UTC

There are various actions in editor and java/editor that listen to changes in
ActionMap lookup and update their presenter if the result is changed. This is OK
but the change occurs too often for example when the node is change in editor
like I the cursor is moved from one element fo Java source to another. The
lookup result is updated altough it is not actually changed.

Comment 1 Jaroslav Tulach 2005-11-11 16:49:49 UTC

"#68031: Making the AbstractLookup and especially ProxyLookup much, much 
improved. The results are now really unmodifiable, events are fired only if 
something really changes, etc. Small step for me, but big step forward for the 
mankind. I am just curious how much unit tests will fail on monday..." 
Checking in 
openide/masterfs/src/org/netbeans/modules/masterfs/MasterFileSystem.java; 
/cvs/openide/masterfs/src/org/netbeans/modules/masterfs/MasterFileSystem.java,v  
<--  MasterFileSystem.java 
new revision: 1.20; previous revision: 1.19 
done 
Checking in 
openide/test/unit/src/org/openide/windows/TopComponentGetLookupTest.java; 
/cvs/openide/test/unit/src/org/openide/windows/TopComponentGetLookupTest.java,v  
<--  TopComponentGetLookupTest.java 
new revision: 1.22; previous revision: 1.21 
done 
Checking in openide/util/apichanges.xml; 
/cvs/openide/util/apichanges.xml,v  <--  apichanges.xml 
new revision: 1.10; previous revision: 1.9 
done 
Checking in openide/util/manifest.mf; 
/cvs/openide/util/manifest.mf,v  <--  manifest.mf 
new revision: 1.8; previous revision: 1.7 
done 
Checking in openide/util/src/org/openide/util/lookup/AbstractLookup.java; 
/cvs/openide/util/src/org/openide/util/lookup/AbstractLookup.java,v  <--  
AbstractLookup.java 
new revision: 1.3; previous revision: 1.2 
done 
Checking in openide/util/src/org/openide/util/lookup/ProxyLookup.java; 
/cvs/openide/util/src/org/openide/util/lookup/ProxyLookup.java,v  <--  
ProxyLookup.java 
new revision: 1.3; previous revision: 1.2 
done 
Checking in 
openide/util/test/unit/src/org/openide/util/lookup/AbstractLookupBaseHid.java; 
/cvs/openide/util/test/unit/src/org/openide/util/lookup/AbstractLookupBaseHid.java,v  
<--  AbstractLookupBaseHid.java 
new revision: 1.2; previous revision: 1.1 
done 
Checking in 
openide/util/test/unit/src/org/openide/util/lookup/ProxyLookupTest.java; 
/cvs/openide/util/test/unit/src/org/openide/util/lookup/ProxyLookupTest.java,v  
<--  ProxyLookupTest.java 
new revision: 1.3; previous revision: 1.2 
done 
RCS 
file: /cvs/openide/windows/test/unit/src/org/openide/windows/PreventNeedlessChangesOfActionMapTest.java,v 
done 
Checking in 
openide/windows/test/unit/src/org/openide/windows/PreventNeedlessChangesOfActionMapTest.java; 
/cvs/openide/windows/test/unit/src/org/openide/windows/PreventNeedlessChangesOfActionMapTest.java,v  
<--  PreventNeedlessChangesOfActionMapTest.java 
initial revision: 1.1