This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 80720

Summary:	New Entity Class wizard doesn't check reserved literals in EJB QL
Product:	javaee	Reporter:	Jindrich Sedek <jsedek>
Component:	Persistence	Assignee:	Dongmei Cao <dongmeic>
Status:	RESOLVED WONTFIX
Severity:	blocker
Priority:	P4
Version:	5.x
Hardware:	All
OS:	All
Issue Type:	DEFECT	Exception Reporter:
Bug Depends on:	81163
Bug Blocks:
Attachments:	Proposed patch after issue 81163 is fixed.

Description Jindrich Sedek 2006-07-20 14:43:31 UTC

Create new EJB module
Menu/File/New File...
Choose persistence categorie and Entity Class as file type
set for example All as a class name and set some package
error message should be shown and finish button should be disabled because "All"
is EJB QL reserved word, but it is not and pressing Finish button new class is
generated with error message

Comment 1 Rochelle Raccah 2006-07-20 21:39:59 UTC

I checked and "All" is in the list of reserved words at
j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/dd/Bundle.properties

However, it seems this list is not checked for New Entity/New Entity from DB

Comment 2 Martin Adamek 2006-07-26 14:15:14 UTC

It is easy fix once issue 81163 is resolved.

Comment 3 Martin Adamek 2006-07-26 14:37:58 UTC

Created attachment 32233 [details]
Proposed patch after issue 81163 is fixed.

Comment 4 Rochelle Raccah 2006-07-28 01:47:43 UTC

Issue 81163 blocks checking this in the New Entity wizard, but not in the Entity
from DB wizard.

Comment 5 Rochelle Raccah 2006-08-01 01:33:19 UTC

Fixed for the New Entity from DB wizard:
Checking in
src/org/netbeans/modules/j2ee/persistence/entitygenerator/EntityMember.java;
/cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/entitygenerator/Attic/EntityMember.java,v
 <--  EntityMember.java
new revision: 1.1.2.1.2.4; previous revision: 1.1.2.1.2.3
done
Checking in
src/org/netbeans/modules/j2ee/persistence/wizard/fromdb/Bundle.properties;
/cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/wizard/fromdb/Attic/Bundle.properties,v
 <--  Bundle.properties
new revision: 1.1.2.3.2.26; previous revision: 1.1.2.3.2.25
done
Checking in
src/org/netbeans/modules/j2ee/persistence/wizard/fromdb/TableUISupport.java;
/cvs/j2ee/persistence/src/org/netbeans/modules/j2ee/persistence/wizard/fromdb/Attic/TableUISupport.java,v
 <--  TableUISupport.java
new revision: 1.1.2.9; previous revision: 1.1.2.8
done

Comment 6 Martin Adamek 2006-08-30 11:36:09 UTC

This issue is blocked by issue 81163, so it cannot be fixed until the other one
is fixed. Should we mark that one also as fix-in-55?

Comment 7 Martin Adamek 2006-09-05 13:13:38 UTC

Will not be fixed in 5.5 because of dependency.

Comment 8 Pavel Buzek 2007-10-29 18:33:56 UTC

Marking as evaluated for 6.0 - this is a valid P3, not critical for the release.

Comment 9 Andrei Badea 2008-01-15 13:52:48 UTC

This not a P3: user impact low (it is easy to rename the newly generated entity class), and there is a hint telling the
user that the name is reserved.

Comment 10 Dongmei Cao 2008-11-19 21:42:39 UTC

low priority

Comment 11 Quality Engineering 2009-11-02 11:15:04 UTC

NetBeans.org Migration: changing resolution from LATER to WONTFIX