This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
| Summary: | Need non-FileObject-based VisibilityQuery.isVisible | ||
|---|---|---|---|
| Product: | projects | Reporter: | Jesse Glick <jglick> |
| Component: | Generic Infrastructure | Assignee: | Milos Kleint <mkleint> |
| Status: | RESOLVED FIXED | ||
| Severity: | blocker | CC: | pjiricka |
| Priority: | P3 | Keywords: | API, API_REVIEW_FAST |
| Version: | 6.x | ||
| Hardware: | All | ||
| OS: | All | ||
| Issue Type: | DEFECT | Exception Reporter: | |
| Bug Depends on: | |||
| Bug Blocks: | 44586, 49026 | ||
| Attachments: |
api change diff
includeexcludevisualizer patch version control implements VisibilityQueryImplementation2 |
||
|
Description
Jesse Glick
2007-02-19 22:51:48 UTC
jesse, is this critical for 6.0? I suppose not as it's a P3 -> future Please consider for 6.1. Should not be difficult. Created attachment 58468 [details]
api change diff
please review. the attached diff includes an additional spi interface VisibilityQueryImplementation2, additional method to VisibilityQuery and an updated master fs implementation. Users of the API shall not be required to call both VisibilityQuery.isVisible(FileObject) and isVisible(File). The File-based method will attempt to delegate to the FileObject based one if the underlying VQI is not VQI2. Looks OK to me. Would be useful to include the patch to IncludeExcludeVisualizer which it would enable. Created attachment 58753 [details]
includeexcludevisualizer patch
Created attachment 58754 [details]
version control implements VisibilityQueryImplementation2
attached are the rewrite of IncludeExcludeVisualizer and also version control based VisbilityQueryImplementations now implement the "2" interface. Looks good. done http://hg.netbeans.org/main/rev/9a854ac87a45 http://hg.netbeans.org/main/rev/87683b6f84d0 http://hg.netbeans.org/main/rev/694555c4ae52 fixed. |