This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | CollisionsCollector context | ||
---|---|---|---|
Product: | platform | Reporter: | Joshua Sandusky <jsandusky> |
Component: | Graph | Assignee: | apireviews <apireviews> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | Keywords: | API_REVIEW_FAST |
Priority: | P3 | ||
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | ENHANCEMENT | Exception Reporter: | |
Attachments: | The proposed patch |
Description
Joshua Sandusky
2007-03-26 23:36:02 UTC
including the first part of the routeConnection method in my modified OrthogonalSearchRouter to provide the details of what I am doing: public List<Point> routeConnection (ConnectionWidget widget) { ... collector.collectCollisions(widget, verticalCollisions, horizontalCollisions); ... CollisionsCollector is not context sensitive at all. I am attaching a proposed patch. It contains a new ConnectionWidgetCollisionsCollector interface which receives "ConnectionWidget" parameter as the context of connection which is being routed. You can use the ConnectionWidgetCollisionsCollector interface for creating an OrthogonalSearchRouter instance using: RouterFactory.createOrthogonalSearchRouter(CWCC collector) The patch contains updated documentation, javadoc, apichanges.xml, increased spec. number and automated test. Reassigning to apireviews to ask for fast-track API review. Thanks Dave, this sounds like it will work well! Created attachment 41151 [details]
The proposed patch
Sorry - I have forgotten to attach the proposed patch to the issue last week. I guess I have to wait one week again for patch integration. Or not? Y01 Stop using golden files in this trivial cases and try for example: boolean wasHere; public void insideListenerMethod() { wasHere = true; } assertTrue("Listener called", wasHere); Patch applied. |