This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 108973 - I18N - wsdl from db wizard has text labels not from pseudo localized bundle file
Summary: I18N - wsdl from db wizard has text labels not from pseudo localized bundle file
Status: VERIFIED FIXED
Alias: None
Product: soa
Classification: Unclassified
Component: SQL Project (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: nav064
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2007-07-05 19:33 UTC by kaa
Modified: 2008-05-29 14:13 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
image (66.03 KB, image/jpeg)
2007-07-05 19:35 UTC, kaa
Details
exception (6.51 KB, text/plain)
2007-09-21 17:38 UTC, kaa
Details
image (88.06 KB, image/jpeg)
2008-04-03 17:53 UTC, kaa
Details

Note You need to log in before you can comment on or make changes to this bug.
Description kaa 2007-07-05 19:33:40 UTC
build 0630

1. Create BPEL Module
2. Open file new wizard: SOA -> WSDL From Database
3. Follow the wizard until step 4.

There are text labels not from pseudo localized bundle file.
I'm running in the Japan locale, using a pseudo localized Netbeans.
Comment 1 kaa 2007-07-05 19:35:05 UTC
Created attachment 44744 [details]
image
Comment 2 Shivanand Kini 2007-07-09 22:04:31 UTC
moving to sql wizard component
Comment 3 Venkat Srinivasan 2007-08-21 05:32:36 UTC
Pls look into this
Comment 4 Naveen Kuncharapu 2007-08-30 15:17:56 UTC
fixed.Now the wsdl from dbwizard has text labels from pseudo localized bundle file. 
Comment 5 Naveen Kuncharapu 2007-09-06 06:48:20 UTC
fixed
Comment 6 kaa 2007-09-21 17:37:32 UTC
step 3: there is an exception on XP and S10
Comment 7 kaa 2007-09-21 17:38:16 UTC
Created attachment 49260 [details]
exception
Comment 8 Radhika Maddula 2007-10-15 14:49:22 UTC
Not able to reproduce the issue. Verified in the Netbeans IDE Dev(Build 071015)
Comment 9 Ken Frank 2007-10-15 15:45:16 UTC
rmaddula - what locale did you run nb in to verify this and did you
use pseudo localization like original issue situation ?

I realize there are really 2 issues in this issue and that the exception should
have been reported separately - was it the exception part you verified about
or the missing message part ?

Andrey, please verify both situations, and it still exception, please file a separate issue today.

ken.frank@sun.com
Comment 10 kaa 2008-03-13 16:55:50 UTC
reproducible on Solaris 10.
build 0311
Comment 11 Naveen Kuncharapu 2008-03-27 05:41:04 UTC
Fixed in the current build.
Comment 12 kaa 2008-04-03 17:52:20 UTC
Fix looks incomplete: 
Product Version: NetBeans IDE Dev (Build 200803301102)
Java: 1.6.0_05; Java HotSpot(TM) Client VM 10.0-b19
System: Windows XP version 5.1 running on x86; MS932; ja_JP

1. There are labels not from pseudo localized bunle file
2. There are table headers with invisible text if the width of the column is max.
Comment 13 kaa 2008-04-03 17:53:38 UTC
Created attachment 59633 [details]
image
Comment 14 Ken Frank 2008-04-03 18:03:17 UTC
I see resize problems on solaris with select datasource
and table objects panel - Andrey can you look at that ?

for messages not from bundle or from bundle but not from
localized - please file a separate issue; its not about resize.
I do see those msgs like Clear All in the pseudo bundle file
of 0330.

ken.frank@sun.com
Comment 15 Ken Frank 2008-04-03 18:07:09 UTC
Andrey, also 5th panel - resize problem on solaris
re JNDI Name label

also its not with prefix/suffix but in pseudo bundle file -
is this a regression in that it was ok before ?

in any case add to the separate issue.

ken.frank@sun.com
Comment 16 Ken Frank 2008-04-08 01:59:45 UTC
to bug filer, kaa, I don't see additional info or gifs about other resize
situations seen on solaris, at least - does it mean these were not seen by you ?

ken.frank@sun.com
Comment 17 Ken Frank 2008-04-08 02:27:28 UTC
this issue is just about resizing; it should not have been used
for missing messages; another issue was filed on that
132273.

ken.frank@sun.com
Comment 18 kaa 2008-04-08 16:50:42 UTC
Resize problems with select datasource and table objects are both known. The issue 129414 was filed for them. The
problem with resize on the step 5 with JNDI Name was filed for 6.0: issue 108979. It was verifyied but the problem
exists in 6.1 again. I have filed new issue 132345.
Comment 19 Narayana Rallabandi 2008-04-11 07:50:55 UTC
Can you please attach the pseudo localized bundle, which you are using. 

Thanks,
Comment 20 Ken Frank 2008-04-11 18:04:07 UTC
please tell me name(s) of the english jar file that has the messages
and from what nb build to get it - ie from trunk of some certain date
or from release61/rc build of some certain date - and I will send the
pseudo localized of those to you.

ken.frank@sun.com
Comment 21 Ken Frank 2008-04-14 22:59:16 UTC
kaa,

is all of what is in here covered
by some/all of these:

132349, 132274, 132273, 129414, 132348, 120901 ?

if so, and all parts are covered, I suggest closing this one.

ken.frank@sun.com
Comment 22 nav064 2008-04-15 09:42:45 UTC
Is the pseudo localized bundle referred to from enterprise/sql/jdbcwizard/src/org/netbeans/modules/jdbcwizard/wizards or
soa/org/netbeans/modules/jdbcwizard/wizards? Could you test with the latest?
Comment 23 nav064 2008-04-15 09:43:05 UTC
Is the pseudo localized bundle referred to from enterprise/sql/jdbcwizard/src/org/netbeans/modules/jdbcwizard/wizards or
soa/org/netbeans/modules/jdbcwizard/wizards? Could you test with the latest?
Comment 24 Ken Frank 2008-04-15 15:52:53 UTC
nav064 - has there been a fix for this issue ?
if so, then in which build - trunk, rc1 or other place - we need
exact location.

also, in which product jar is the fix ?

the problem and others related to this wizard, filed separately,
still show in rc1.

also, not related to actual issue  - in  the
enterprise/sql/jdbcwizard/src/org/netbeans/modules/jdbcwizard/wizards
bundle file is
MNE_BrowseFolders_Select_Option=Select

--usually key names with MNE are definitions of mnemonic keys, not messages -
can you clarify ?

thus at present time, only the word Select is not pseudo localized.

also, mnemonics should be done now, as per nb policy, using the '&' approach,
not the 2 key value approach.

and other places in this bundle are
MNE_BrowseFolders_jLabel1=B
MNE_TargetChooser_FileName_Label=N
MNE_TargetChooser_FolderName_Label=N

but usually if a key has word label in it, it means
a label, not a mnemonic key - and since translators
need to add info the the label of a mnenonic, it can
be confusing for them to see it this way.

same comments for the other bundle file mentioned from soa2

ken.frank@sun.com
Comment 25 Venkat Srinivasan 2008-04-16 07:07:51 UTC
Pls look into this.
Comment 26 nav064 2008-04-16 10:07:15 UTC
Frank,
The changes in the bundle.properties from soa2(not from enterprise) are reflected properly in the wizard. 
The fix was up in trunk build #1331. And regarding mnemonics and labels, I'll do the needful. 
Comment 27 nav064 2008-04-16 10:09:44 UTC
It was checked-in to (mercurial) main branch.
Comment 28 nav064 2008-04-16 15:19:14 UTC
Checked-in some changes accordingly. Now, labels for mnemonics start with "LABEL" not "LBL" and all mnemonics start with
"MNE".  
Comment 29 Ken Frank 2008-04-16 15:50:14 UTC
nav064,

to clarify - 

the fix is in trunk only now ? (not in release 61 branch ?)

what is the date of the build that has the fix you mention - I need
to see if a trunk build of that date was tested (we get builds via installers)

ken.frank@sun.com
Comment 30 Ken Frank 2008-04-16 20:41:49 UTC
added the status whiteboard entry for issues that could be in
patch 1 for nb6.1
Comment 31 nav064 2008-04-17 08:14:42 UTC
Can you please let me know whats the repository to point to for patch 1 for nb6.1 so that I can make sure that the
changes are in?
Comment 32 Ken Frank 2008-04-17 16:10:03 UTC
nav064

the first repos to put it in is the trunk/main one; other dev can give more
info on this to you as I don't know other details.

Then, after you put it there, please tell me the date and time it was put - then
we will get the next trunk build and verify.

when it can be verified, we will mark it here and then let sustaining team know
that its verified in trunk, so that then they can get the fix for the patch.

ken.frank@sun.com
Comment 33 Ken Frank 2008-04-17 16:11:56 UTC
nav064 - one more information -
please add the trunk commit info
to this issue, since that is how
sustaining team will find the fix
when they put it later into sustaining
branch for patch.

ken.frank@sun.com
Comment 34 nav064 2008-04-21 06:59:04 UTC
Issues 120901,132348,132349,108973 - I18N changes jdbc bc wizard
HG: user: Nav  <nav064@netbeans.org>
HG: branch default
HG: changed sql.project/src/org/netbeans/modules/sql/project/ui/wizards/PanelProjectLocationVisual.java
HG: changed sql.wizard/src/org/netbeans/modules/jdbcwizard/builder/xsd/XSDGenerator.java
HG: changed sql.wizard/src/org/netbeans/modules/jdbcwizard/wizards/Bundle.properties
HG: changed sql.wizard/src/org/netbeans/modules/jdbcwizard/wizards/ChosenColumnPanel.java
HG: changed sql.wizard/src/org/netbeans/modules/jdbcwizard/wizards/InsertColumnPanel.java
HG: changed sql.wizard/src/org/netbeans/modules/jdbcwizard/wizards/JDBCWizardSelectionPanel.java
HG: changed sql.wizard/src/org/netbeans/modules/jdbcwizard/wizards/JDBCWizardTablePanel.java
HG: changed sql.wizard/src/org/netbeans/modules/jdbcwizard/wizards/JNDINamePanel.java
HG: changed sql.wizard/src/org/netbeans/modules/jdbcwizard/wizards/PolledColumnPanel.java
HG: changed sql.wizard/src/org/netbeans/modules/jdbcwizard/wizards/SimpleTargetChooserPanelGUI.java
HG: changed sql.wizard/src/org/netbeans/modules/jdbcwizard/wizards/UpdateColumnPanel.java

default branch: release61
Comment 35 rbalada 2008-04-21 16:27:18 UTC
nav064,

would you please provide us with changeset id? I would appreciate a URL link to the changeset in a form
"http://hg.netbeans.org/..."
Comment 36 nav064 2008-04-22 07:41:50 UTC
http://hg.netbeans.org/main/rev/911d8fdc2a45

That was for the last change I made to the main.
Comment 38 Ken Frank 2008-04-23 16:43:41 UTC
kaa,

this has been marked as resolved but not yet verified but 
we need to know now so it can be in patch. is there a reason it has not
been able to be verified ?
Comment 39 kaa 2008-04-24 19:55:58 UTC
The issue has been reproducible until now (1701, 1717 builds).
I vitrified with the latest pseudo jar file. Messages look ok. See also issue 132273.

Product Version: NetBeans IDE Dev (Build 20080424124045)
Java: 1.6.0_05; Java HotSpot(TM) Client VM 10.0-b19
System: Windows XP version 5.1 running on x86; MS932; ja_JP (nb)
Comment 40 pslechta 2008-04-28 11:19:51 UTC
Please provide complete list of change sets that should be ported to 6.1 patch 1. Otherwise this bug fix cannot be part
of patch 1.

Why I think the change sets are not complete?

http://hg.netbeans.org/main/rev/3726ceeca2dc

Changed, but never used (in the diff)
-MNEMONIC_otd_edit_import=e
-MNEMONIC_otd_new_import=w 
+MNE_otd_edit_import=e
+MNE_otd_new_import=w 

-MNEMONIC_otd_db_filetreeview=x
+MNE_otd_db_filetreeview=x 

And some other changes that are never used...
Comment 41 Ken Frank 2008-04-28 16:29:53 UTC
Nav,

please provide this info requested as soon as possible so the
fix can actually go into the patch1.

Thanks.

ken.frank@sun.com
Comment 42 pslechta 2008-04-29 11:18:51 UTC
Please provide proper change set for this fix in 5 days (till May 5th). Otherwise this fix will be removed from patch 1.
Comment 43 nav064 2008-04-30 13:10:20 UTC
http://hg.netbeans.org/release61/rev/4fb2a4b5b12f

Changeset of a porting check-in for issues 120901,132348,132349 and 108973 from main to release61. 
Was done to get changes into release61. Shall be making changes only in the main and providing the changeset. 

Petr,
Please let the modified keys be there as they can be used for 508 compliance, etc.
Comment 44 pslechta 2008-05-06 13:01:53 UTC
All changes described in http://hg.netbeans.org/release61/rev/4fb2a4b5b12f are already incorporated in release61_fixes
repository. This may be side effect caused by porting other bugs, or the changes were already in release61 repository.

Marking this issue as backported into release61_fixes repository.
Comment 45 pslechta 2008-05-07 11:08:20 UTC
After another check, I found that all changes from http://hg.netbeans.org/release61/rev/4fb2a4b5b12f are already part of
NB 6.1 FCS build. Cleaning status whiteboard, this fix should not be part of NB 6.1 patch 1 because it is already in NB
6.1 FCS release.