This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 109641 - Update General Options panel according to UI Spec
Summary: Update General Options panel according to UI Spec
Status: RESOLVED FIXED
Alias: None
Product: platform
Classification: Unclassified
Component: Window System (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Milan Kubec
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks:
 
Reported: 2007-07-13 13:36 UTC by Milan Kubec
Modified: 2008-12-22 13:35 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
diff (271.07 KB, text/plain)
2007-07-17 14:00 UTC, Milan Kubec 		Details
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Milan Kubec 2007-07-13 13:36:15 UTC 
General Options panel needs to be updated according to UI Spec:
http://ui.netbeans.org/docs/ui/OptionMenuDialogues/#GeneralPaneldesing

Part of the update will be move of the code from editor/options to core/ui because general panel contains only platform
specific settings = Proxy settings and Web browser settings. It will change package from:
'org.netbeans.modules.options.general' to
'org.netbeans.core.ui.options.general'
Comment 1 Milan Kubec 2007-07-17 14:00:30 UTC 
Created attachment 45208 [details]
diff
Comment 2 Milan Kubec 2007-07-17 14:04:02 UTC 
I've attached diff with the change. Passing to fast api review. Package org.netbeans.core.ui.options.general was moved
from editor/options to package org.netbeans.modules.options.general in core/ui. Please review. Thanks.
Comment 3 Vitezslav Stejskal 2007-07-17 14:56:01 UTC 
I assume you meant to say that:
org.netbeans.modules.options.general (editor/options) -> org.netbeans.core.ui.options.general (core/ui)

Otherwise looking good.
Comment 4 Milan Kubec 2007-07-17 15:21:23 UTC 
Of course, Vita is right.
Comment 5 Jesse Glick 2007-07-17 16:29:56 UTC 
Good news.
Comment 6 Milan Kubec 2007-07-20 13:37:18 UTC 
I'll commit this change on Monday 23rd.
Comment 7 Milan Kubec 2007-07-23 10:46:58 UTC 
Done.

Checking in extbrowser/src/org/netbeans/modules/extbrowser/SystemDefaultBrowserBeanInfo.java;
/cvs/extbrowser/src/org/netbeans/modules/extbrowser/SystemDefaultBrowserBeanInfo.java,v  <-- 
SystemDefaultBrowserBeanInfo.java
new revision: 1.8; previous revision: 1.7
done
Checking in extbrowser/src/org/netbeans/modules/extbrowser/ExtWebBrowserBeanInfo.java;
/cvs/extbrowser/src/org/netbeans/modules/extbrowser/ExtWebBrowserBeanInfo.java,v  <--  ExtWebBrowserBeanInfo.java
new revision: 1.15; previous revision: 1.14
done
Checking in core/execution/src/org/netbeans/core/execution/beaninfo/editors/NbProcessDescriptorCustomEditor.java;
/cvs/core/execution/src/org/netbeans/core/execution/beaninfo/editors/NbProcessDescriptorCustomEditor.java,v  <-- 
NbProcessDescriptorCustomEditor.java
new revision: 1.8; previous revision: 1.7
done
Checking in core/execution/src/org/netbeans/core/execution/beaninfo/editors/NbProcessDescriptorCustomEditor.form;
/cvs/core/execution/src/org/netbeans/core/execution/beaninfo/editors/NbProcessDescriptorCustomEditor.form,v  <-- 
NbProcessDescriptorCustomEditor.form
new revision: 1.5; previous revision: 1.4
done
Checking in core/execution/src/org/netbeans/core/execution/beaninfo/editors/Bundle.properties;
/cvs/core/execution/src/org/netbeans/core/execution/beaninfo/editors/Bundle.properties,v  <--  Bundle.properties
new revision: 1.7; previous revision: 1.6
done
Removing editor/options/src/org/netbeans/modules/options/general/AdvancedProxyPanel.form;
/cvs/editor/options/src/org/netbeans/modules/options/general/AdvancedProxyPanel.form,v  <--  AdvancedProxyPanel.form
new revision: delete; previous revision: 1.2
done
Removing editor/options/src/org/netbeans/modules/options/general/Bundle.properties;
/cvs/editor/options/src/org/netbeans/modules/options/general/Bundle.properties,v  <--  Bundle.properties
new revision: delete; previous revision: 1.15
done
Removing editor/options/src/org/netbeans/modules/options/general/GeneralOptionsPanelController.java;
/cvs/editor/options/src/org/netbeans/modules/options/general/GeneralOptionsPanelController.java,v  <-- 
GeneralOptionsPanelController.java
new revision: delete; previous revision: 1.8
done
Removing editor/options/src/org/netbeans/modules/options/general/AdvancedProxyPanel.java;
/cvs/editor/options/src/org/netbeans/modules/options/general/AdvancedProxyPanel.java,v  <--  AdvancedProxyPanel.java
new revision: delete; previous revision: 1.2
done
Removing editor/options/src/org/netbeans/modules/options/general/GeneralOptions.java;
/cvs/editor/options/src/org/netbeans/modules/options/general/GeneralOptions.java,v  <--  GeneralOptions.java
new revision: delete; previous revision: 1.6
done
Removing editor/options/src/org/netbeans/modules/options/general/GeneralOptionsPanel.form;
/cvs/editor/options/src/org/netbeans/modules/options/general/GeneralOptionsPanel.form,v  <--  GeneralOptionsPanel.form
new revision: delete; previous revision: 1.9
done
Removing editor/options/src/org/netbeans/modules/options/general/GeneralOptionsPanel.java;
/cvs/editor/options/src/org/netbeans/modules/options/general/GeneralOptionsPanel.java,v  <--  GeneralOptionsPanel.java
new revision: delete; previous revision: 1.33
done
Removing editor/options/src/org/netbeans/modules/options/general/GeneralOptionsModel.java;
/cvs/editor/options/src/org/netbeans/modules/options/general/GeneralOptionsModel.java,v  <--  GeneralOptionsModel.java
new revision: delete; previous revision: 1.14
done
Checking in editor/options/nbproject/project.xml;
/cvs/editor/options/nbproject/project.xml,v  <--  project.xml
new revision: 1.24; previous revision: 1.23
done
RCS file: /cvs/core/ui/src/org/netbeans/core/ui/options/general/AdvancedProxyPanel.form,v
done
Checking in core/ui/src/org/netbeans/core/ui/options/general/AdvancedProxyPanel.form;
/cvs/core/ui/src/org/netbeans/core/ui/options/general/AdvancedProxyPanel.form,v  <--  AdvancedProxyPanel.form
initial revision: 1.1
done
RCS file: /cvs/core/ui/src/org/netbeans/core/ui/options/general/GeneralOptionsModel.java,v
done
Checking in core/ui/src/org/netbeans/core/ui/options/general/GeneralOptionsModel.java;
/cvs/core/ui/src/org/netbeans/core/ui/options/general/GeneralOptionsModel.java,v  <--  GeneralOptionsModel.java
initial revision: 1.1
done
RCS file: /cvs/core/ui/src/org/netbeans/core/ui/options/general/WebBrowsersOptionsPanel.form,v
done
Checking in core/ui/src/org/netbeans/core/ui/options/general/WebBrowsersOptionsPanel.form;
/cvs/core/ui/src/org/netbeans/core/ui/options/general/WebBrowsersOptionsPanel.form,v  <--  WebBrowsersOptionsPanel.form
initial revision: 1.1
done
RCS file: /cvs/core/ui/src/org/netbeans/core/ui/options/general/WebBrowsersOptionsModel.java,v
done
Checking in core/ui/src/org/netbeans/core/ui/options/general/WebBrowsersOptionsModel.java;
/cvs/core/ui/src/org/netbeans/core/ui/options/general/WebBrowsersOptionsModel.java,v  <--  WebBrowsersOptionsModel.java
initial revision: 1.1
done
RCS file: /cvs/core/ui/src/org/netbeans/core/ui/options/general/GeneralOptionsPanel.form,v
done
Checking in core/ui/src/org/netbeans/core/ui/options/general/GeneralOptionsPanel.form;
/cvs/core/ui/src/org/netbeans/core/ui/options/general/GeneralOptionsPanel.form,v  <--  GeneralOptionsPanel.form
initial revision: 1.1
done
RCS file: /cvs/core/ui/src/org/netbeans/core/ui/options/general/GeneralOptions.java,v
done
Checking in core/ui/src/org/netbeans/core/ui/options/general/GeneralOptions.java;
/cvs/core/ui/src/org/netbeans/core/ui/options/general/GeneralOptions.java,v  <--  GeneralOptions.java
initial revision: 1.1
done
RCS file: /cvs/core/ui/src/org/netbeans/core/ui/options/general/GeneralOptionsPanelController.java,v
done
Checking in core/ui/src/org/netbeans/core/ui/options/general/GeneralOptionsPanelController.java;
/cvs/core/ui/src/org/netbeans/core/ui/options/general/GeneralOptionsPanelController.java,v  <-- 
GeneralOptionsPanelController.java
initial revision: 1.1
done
RCS file: /cvs/core/ui/src/org/netbeans/core/ui/options/general/GeneralOptionsPanel.java,v
done
Checking in core/ui/src/org/netbeans/core/ui/options/general/GeneralOptionsPanel.java;
/cvs/core/ui/src/org/netbeans/core/ui/options/general/GeneralOptionsPanel.java,v  <--  GeneralOptionsPanel.java
initial revision: 1.1
done
RCS file: /cvs/core/ui/src/org/netbeans/core/ui/options/general/AdvancedProxyPanel.java,v
done
Checking in core/ui/src/org/netbeans/core/ui/options/general/AdvancedProxyPanel.java;
/cvs/core/ui/src/org/netbeans/core/ui/options/general/AdvancedProxyPanel.java,v  <--  AdvancedProxyPanel.java
initial revision: 1.1
done
RCS file: /cvs/core/ui/src/org/netbeans/core/ui/options/general/Bundle.properties,v
done
Checking in core/ui/src/org/netbeans/core/ui/options/general/Bundle.properties;
/cvs/core/ui/src/org/netbeans/core/ui/options/general/Bundle.properties,v  <--  Bundle.properties
initial revision: 1.1
done
RCS file: /cvs/core/ui/src/org/netbeans/core/ui/options/general/WebBrowsersOptionsPanel.java,v
done
Checking in core/ui/src/org/netbeans/core/ui/options/general/WebBrowsersOptionsPanel.java;
/cvs/core/ui/src/org/netbeans/core/ui/options/general/WebBrowsersOptionsPanel.java,v  <--  WebBrowsersOptionsPanel.java
initial revision: 1.1
done
Checking in editor/options/test/unit/src/org/netbeans/modules/options/editor/EditorOptionsTest.java;
/cvs/editor/options/test/unit/src/org/netbeans/modules/options/editor/EditorOptionsTest.java,v  <--  EditorOptionsTest.java
new revision: 1.8; previous revision: 1.7
done
Checking in editor/options/src/org/netbeans/modules/options/editor/mf-layer.xml;
/cvs/editor/options/src/org/netbeans/modules/options/editor/mf-layer.xml,v  <--  mf-layer.xml
new revision: 1.42; previous revision: 1.41
done
Checking in core/ui/src/org/netbeans/core/ui/resources/layer.xml;
/cvs/core/ui/src/org/netbeans/core/ui/resources/layer.xml,v  <--  layer.xml
new revision: 1.131; previous revision: 1.130
done
Checking in core/ui/nbproject/project.xml;
/cvs/core/ui/nbproject/project.xml,v  <--  project.xml
new revision: 1.13; previous revision: 1.12
done
Checking in core/nbproject/project.xml;
/cvs/core/nbproject/project.xml,v  <--  project.xml
new revision: 1.31; previous revision: 1.30
done
Checking in ide/test/qa-functional/src/validation/IDEValidation.java;
/cvs/ide/test/qa-functional/src/validation/IDEValidation.java,v  <--  IDEValidation.java
new revision: 1.201; previous revision: 1.200
done
Comment 8 Milan Kubec 2007-07-23 15:10:11 UTC 
Additional fix: browserExecutable is not preferred property for web browser on linux, any first property that is not
expert or hidden is used then.

Checking in WebBrowsersOptionsModel.java;
/cvs/core/ui/src/org/netbeans/core/ui/options/general/WebBrowsersOptionsModel.java,v  <--  WebBrowsersOptionsModel.java
new revision: 1.3; previous revision: 1.2
done