This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 117234 - I18N - duplicate key in same bundle file
Summary: I18N - duplicate key in same bundle file
Status: VERIFIED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: visualweb (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Peter Zavadsky
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2007-10-01 07:42 UTC by Ashizawa Kazunori
Modified: 2008-07-11 15:42 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ashizawa Kazunori 2007-10-01 07:42:28 UTC
The same key appears multiple times in a bundle file.  If each
messages should be different or should be used independently,
then each messages should have different keys.  If the message
is used at a single place, then multiple occurrences should be
unified.

This duplication means that it's not known at runtime which
message will be used.  This issue also increases translation
cost (time and effort).

visualweb/designer/jsf/src/org/netbeans/modules/visualweb/designer/jsf/Bundle.properties:
LBL_LinkComponent=Link Component
LBL_LinkComponent=Link Component
LBL_LinkComponents=Link Components
LBL_LinkComponents=Link Components
visualweb/designer/jsf/src/org/netbeans/modules/visualweb/designer/jsf/action/Bundle.properties:
LBL_RefreshAction=Refresh
LBL_RefreshAction=Refresh
visualweb/designer/jsf/src/org/netbeans/modules/visualweb/designer/jsf/text/Bundle.properties:
LBL_DeleteText=Delete Text
LBL_DeleteText=Delete Text
visualweb/jsfsupport/designtime/src/org/netbeans/modules/visualweb/faces/dt/converter/Bundle.properties:
class=Class:
class=Class:
currency=Currency
currency=Currency
currencyCode=Currency Code
currencyCode=Currency Code:
example=Example:
example=Example:
fracDigits=Fractional Digits:
fracDigits=Fractional Digits:
intDigits=Integer Digits:
intDigits=Integer Digits:
intOnly=Integer Only (on coverting to Number)
intOnly=Integer Only
locale=Locale:
locale=Locale:
number=Number
number=Number
numberFormat=Number Format
numberFormat=Number Format
numberFormatDesc=Edit the number formatting properties
numberFormatDesc=Edit the number formatting properties
numberFormatEllipse=Number format...
numberFormatEllipse=Number format...
pattern=Pattern:
pattern=Pattern:
pattern=Pattern
percent=Percent
percent=Percent
results=Results:
results=Results:
symbol=Symbol:
symbol=Symbol:
type=Type:
type=Type:
visualweb/project/jsf/src/org/netbeans/modules/visualweb/project/jsf/actions/Bundle.properties:
MSG_UnableToSetDefaultIcon=Can\'t find data object for file {0} to set default icon.
MSG_UnableToSetDefaultIcon=Can\'t find data object for file {0} to set default icon.
visualweb/project/jsf/src/org/netbeans/modules/visualweb/project/jsf/resources/Bundle.properties:
Templates/JSF/Page.jsp=Visual Web JSF Page
Templates/JSF/Page.jsp=Visual Web JSF Page
visualweb/websvcmgr/src/org/netbeans/modules/visualweb/websvcmgr/util/Bundle.properties:
IMAGE_COPY_ERROR=Could not copy the image
IMAGE_COPY_ERROR=Could not copy the image
visualweb/webui/designtime/src/org/netbeans/modules/visualweb/web/ui/dt/renderer/Bundle-DT.properties:
tab.label=Tab
tab.label=Tab
Comment 1 Dongmei Cao 2007-10-09 02:41:17 UTC


User: dongmeic
Date: 2007/10/08 18:38:48

Modified:
   visualweb/webui/designtime/src/org/netbeans/modules/visualweb/web/ui/dt/renderer/Bundle-DT.properties

Log:
 Removed dup entry "tab.label"

File Changes:

Directory: /visualweb/webui/designtime/src/org/netbeans/modules/visualweb/web/ui/dt/renderer/
=============================================================================================

File [changed]: Bundle-DT.properties
Url:
http://visualweb.netbeans.org/source/browse/visualweb/webui/designtime/src/org/netbeans/modules/visualweb/web/ui/dt/renderer/Bundle-DT.properties?r1=1.2&r2=1.3
Delta lines:  +0 -1
-------------------
--- Bundle-DT.properties	4 Oct 2007 03:27:13 -0000	1.2
+++ Bundle-DT.properties	9 Oct 2007 01:38:45 -0000	1.3
@@ -59,7 +59,6 @@
 alert.summary=Alert Summary
 pageAlert.summary=Page Alert Summary
 tabSet.label=Tab Set
-tab.label=Tab
 treeNode.label=Tree Node
 
 selector.readOnly.selectedValue=selected value
Comment 2 Dongmei Cao 2007-10-09 02:44:04 UTC
User: dongmeic
Date: 2007/10/08 18:40:09

Modified:
   visualweb/jsfsupport/designtime/src/org/netbeans/modules/visualweb/faces/dt/converter/Bundle.properties
   visualweb/jsfsupport/designtime/src/org/netbeans/modules/visualweb/faces/dt/converter/DateTimePatternPanel.java

Log:
 Fix for bug http://www.netbeans.org/issues/show_bug.cgi?id=117234. Removed dup entries

File Changes:

Directory: /visualweb/jsfsupport/designtime/src/org/netbeans/modules/visualweb/faces/dt/converter/
==================================================================================================

File [changed]: Bundle.properties
Url:
http://visualweb.netbeans.org/source/browse/visualweb/jsfsupport/designtime/src/org/netbeans/modules/visualweb/faces/dt/converter/Bundle.properties?r1=1.4&r2=1.5
Delta lines:  +11 -28
---------------------
--- Bundle.properties	2 Oct 2007 20:43:24 -0000	1.4
+++ Bundle.properties	9 Oct 2007 01:40:05 -0000	1.5
@@ -61,27 +61,6 @@
 bigDecimalConvertShortDesc=Big Decimal Conversion Helper Component
 bigIntegerConvert=Big Integer Converter
 bigIntegerConvertShortDesc=Big Integer Conversion Helper Component
-numberFormatEllipse=Number format...
-numberFormatDesc=Edit the number formatting properties
-numberFormat=Number Format
-number=Number
-currency=Currency
-percent=Percent
-type=Type:
-example=Example:
-results=Results:
-class=Class:
-minFractional=Min:
-maxFractional=Max:
-minInteger=Min:
-maxInteger=Max:
-fracDigits=Fractional Digits:
-intDigits=Integer Digits:
-intOnly=Integer Only (on coverting to Number)
-pattern=Pattern:
-locale=Locale:
-currencyCode=Currency Code
-symbol=Symbol:
 groupingUsed=Use Grouping Separator (1,000,000)
 notANumber=**Bad sample number {0}
 badMinIntegerDigits=Min integer digits is not valid\n
@@ -94,11 +73,6 @@
 emptySymbol=Currency symbol is not specified\n
 badPattern=Pattern {0} is invalid\n
 exampleInstructionsText=Choose an example or enter your own to see the resulting output String
-testText=Test
-chooseCurrency=Choose Currency Symbol Using:
-typeDescription=Select a type
-integerDigits=Integer digits
-fractionalDigits=Fractional Digits
 type_mnemonic=T
 pattern_mnemonic=P
 minFractional_mnemonic=n
@@ -305,15 +279,24 @@
 max=Max:
 fracDigits=Fractional Digits:
 intDigits=Integer Digits:
-intOnly=Integer Only
+intOnly=Integer Only (on coverting to Number)
 pattern=Pattern:
 locale=Locale:
 currencyCode=Currency Code:
 symbol=Symbol:
+minFractional=Min:
+maxFractional=Max:
+minInteger=Min:
+maxInteger=Max:
+testText=Test
+chooseCurrency=Choose Currency Symbol Using:
+typeDescription=Select a type
+integerDigits=Integer digits
+fractionalDigits=Fractional Digits
 
 
 #Labels and properties for property editors
-pattern=Pattern
+dateTime_pattern=Pattern
 input_pattern=Enter a date time pattern
 output_pattern=Output of the date time pattern
 test=Test

File [changed]: DateTimePatternPanel.java
Url:
http://visualweb.netbeans.org/source/browse/visualweb/jsfsupport/designtime/src/org/netbeans/modules/visualweb/faces/dt/converter/DateTimePatternPanel.java?r1=1.2&r2=1.3
Delta lines:  +3 -3
-------------------
--- DateTimePatternPanel.java	2 Oct 2007 20:43:24 -0000	1.2
+++ DateTimePatternPanel.java	9 Oct 2007 01:40:06 -0000	1.3
@@ -172,7 +172,7 @@
 
         label = new javax.swing.JLabel();
         label.setHorizontalAlignment(SwingConstants.LEFT);
-        label.setText(bundle.getString("pattern")); //NOI18N
+        label.setText(bundle.getString("dateTime_pattern")); //NOI18N
         gridBagConstraints = new java.awt.GridBagConstraints();
         gridBagConstraints.gridx = 0;
         gridBagConstraints.gridy = 0;
@@ -185,7 +185,7 @@
         patternInputField = new JTextField();
         patternInputField.getDocument().addDocumentListener(this);
         patternInputField.setText(getPropertyEditor().getAsText());
-        patternInputField.getAccessibleContext().setAccessibleName(bundle.getString("pattern"));
+        patternInputField.getAccessibleContext().setAccessibleName(bundle.getString("input_pattern"));
         patternInputField.getAccessibleContext().setAccessibleDescription(bundle.getString("input_pattern"));
         label.setLabelFor(patternInputField);
         gridBagConstraints = new java.awt.GridBagConstraints();
@@ -214,7 +214,7 @@
         nowOutputField = new JTextField();
         nowOutputField.setText(""); //NOI18N
         nowOutputField.setEditable(false);
-        nowOutputField.getAccessibleContext().setAccessibleName(bundle.getString("pattern"));
+        nowOutputField.getAccessibleContext().setAccessibleName(bundle.getString("output_pattern"));
         nowOutputField.getAccessibleContext().setAccessibleDescription(bundle.getString("output_pattern"));
         gridBagConstraints = new java.awt.GridBagConstraints();
         gridBagConstraints.gridx = 1;
Comment 3 Dongmei Cao 2007-10-09 02:45:52 UTC
I have fixed the dup keys in 
visualweb/jsfsupport/designtime/src/org/netbeans/modules/visualweb/faces/dt/converter/Bundle.properties
visualweb/webui/designtime/src/org/netbeans/modules/visualweb/web/ui/dt/renderer/Bundle-DT.properties

Pass the bug to pzavadsky to fix ones from designer
Comment 4 Peter Zavadsky 2007-10-09 21:57:57 UTC
Fixed.

Checking in visualweb/designer/jsf/src/org/netbeans/modules/visualweb/designer/jsf/Bundle.properties;
/cvs/visualweb/designer/jsf/src/org/netbeans/modules/visualweb/designer/jsf/Bundle.properties,v  <--  Bundle.properties
new revision: 1.10; previous revision: 1.9
done
Checking in visualweb/designer/jsf/src/org/netbeans/modules/visualweb/designer/jsf/action/Bundle.properties;
/cvs/visualweb/designer/jsf/src/org/netbeans/modules/visualweb/designer/jsf/action/Bundle.properties,v  <-- 
Bundle.properties
new revision: 1.6; previous revision: 1.5
done
Checking in visualweb/designer/jsf/src/org/netbeans/modules/visualweb/designer/jsf/text/Bundle.properties;
/cvs/visualweb/designer/jsf/src/org/netbeans/modules/visualweb/designer/jsf/text/Bundle.properties,v  <--  Bundle.properties
new revision: 1.11; previous revision: 1.10
done
Comment 5 Ken Frank 2008-07-11 15:42:14 UTC
v.