This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 125064 - 6.0.1 uninstaller should prompt, remove Glassfish V2 UR1
Summary: 6.0.1 uninstaller should prompt, remove Glassfish V2 UR1
Status: RESOLVED FIXED
Alias: None
Product: installer
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: dlipin
URL:
Keywords:
: 128615 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-01-10 21:20 UTC by _ krystyna
Modified: 2008-03-13 12:57 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description _ krystyna 2008-01-10 21:20:59 UTC
ML RC1 candidate: NetBeans IDE 6.0.1 dev (Build 200801100000)
Java: 1.6.0_04; Java HotSpot(TM) Client VM 10.0-b19
System: Windows XP, Solaris sparc


Running uninstaller for 6.0.1, checkbox lists option to uninstall "Glassfish V2" -- and it 
does remove glassfish-v2 however the 6.0.1 installer installs Glassfish V2 UR1
it should remove the version it installs, not earlier (glassfish v2).
Comment 1 _ krystyna 2008-01-10 21:22:49 UTC
Upping the priority - this needs to be fixed.
Comment 2 Lukas Hasik 2008-01-11 07:27:10 UTC
reassigning to NBI
Comment 3 Marian Mirilovic 2008-01-11 10:06:55 UTC
This is a stopper for NB 6.0.1
Comment 4 dlipin 2008-01-11 11:01:36 UTC
unfortunately I was not able to reproduce the issue:
the things that I did:
1) install netbeans-6.0-javaee-windows.exe with no tomcat
2) install netbeans-6.0.1-ml-javaee-windows.exe with no tomcat
3) run uninstaller for 6.0.1 : GlassFish V2 UR1 is the name of the checkbox on the PreUninstallSummary panel.

Krystyna,
could you please provide more details? (like what bundle you`ve installed first, second, what components were actually 
installed, etc)

thanks,
Dmitry
Comment 5 dlipin 2008-01-11 11:47:54 UTC
I`ve tried also full bundles  (netbeans-6.0-windows.exe & netbeans-6.0.1-ml-windows.exe) with the same steps - and the 
same result - V2 UR1 is shown to be removed.
Comment 6 Mikhail Kondratyev 2008-01-11 13:40:55 UTC
The scenario Dima mentions can't be reproduced indeed. The following scenario is reproducible:
 - install 6.0 with glassfish
 - install 6.0.1 without glassfish
 - try to uninstall 6.0.1
Uninstaller will suggest to uninstall glassfish V2 from 6.0 installation

Although I don't think this is a P1, I suppose this must be fixed as uninstalling 6.0.1 may break 6.0 installation
Comment 7 dlipin 2008-01-11 14:05:01 UTC
Mikhail,

the scenario you`ve described is valid and correct but let me give the details to be on the same page:
 - install 6.0 with glassfish -> This will integrate NB6.0 and GF (add GF instance to NB using specific property in 
netbeans.conf)
 - install 6.0.1 without glassfish -> This will integrate NB6.0.1 and GF (that was installed by NB6.0 installer)
 - try to uninstall 6.0.1

In this case GF is suggested to be uninstalled.
The main the idea is that uninstaller search the GF that is integrated with this NB and suggest it for uninstallation 
as well. During the installation newly installed GF is integrated with all NB that it could find (it is questionable, I 
agree)

The other scenario when this issue is reproducible is 
1) install 6.0.1 with GF V2 UR1
2) install 6.0 with GF V2
3) run uninstaller for 6.0.1

In this scenario at the second step the GF V2 is integrated to the NetBeans 6.0.1  - we can`t change that behavior 
since it is controlled by NetBeans 6.0 what is already shipped.

Both scenarios are not P1 since the user can certainly uncheck the GF V2 checkbox and uninstall GF V2 UR1 later.

In the future, we can enhance the strategy by the following steps:
1) During installation do not integrate just installed GF with previous installations of NetBeans if those 
installations have already been integrated with any other GF.

2) During NB uninstallation do not propose to uninstall GF which it is integrated with and which is also integrated 
with any other NB installation. The other option is to propose its uninstallation but set default checkbox state to 
unchecked (frankly speaking, in 6.1 the default state is unchecked in all cases). It is also the question whether to 
mention what particular other NetBeans installation uses this GF so that to make it clear why it is risky or not worth 
to uninstall GF.

Anyway this issue requires much investigation and is very ricky to fix it in 6.0.1.
Comment 8 dlipin 2008-01-11 14:13:26 UTC
As a safe "workaround" and solution for 6.0.1 we can integrate the fix for Issue 121538 (it is fixed only in trunk 
now): in that case GlassFish checkbox would be unchecked by default in the uninstaller so the user should explicitely 
check it that means, I hope, that he/she realize what he/she is doing.
Comment 9 _ krystyna 2008-01-11 16:12:55 UTC
This is what I saw:
Solaris sparc , jdk1.6.0_02:

6.0 javaee package + glassfish v2 + apache installed
6.0.1 javaee package + glassfish v2 ur1 installeld
uninstall 6.0.1 and check "Glassfish V2" (the only glassfish choice)
>result: de-installed my glassfish-v2.
It should prompt to remove glassfish v2 -ur1.
Comment 10 Petr Blaha 2008-01-11 16:21:56 UTC
Krys, which server is uninstalled? From NB 6.0 or from NB 6.0.1? 
Comment 11 Petr Blaha 2008-01-11 16:22:34 UTC
Krys, which server is uninstalled? From NB 6.0 or from NB 6.0.1? Is the issue about wrong server uninstallation or about
wrong server description in installer?
Comment 12 dlipin 2008-01-11 16:37:16 UTC
krystyna,

the order of installation makes sense : 
"6.0 javaee package + glassfish v2 + apache installed and then 6.0.1 javaee package + glassfish v2 ur1 installed"
is not the same as
"6.0.1 javaee package + glassfish v2 ur1 + apache installed and then 6.0 javaee package + glassfish v2 installed"

could you please confirm that you have followed the first variant?

thanks,
Dmitry
Comment 13 _ krystyna 2008-01-11 18:51:36 UTC

Yes, Dmitry, confirming I followed the first variant.

Yes, Petr with 6.0.1 uninstaller, I am pointing out that the UI dialog should be updated to state the correct 
version glassfish to uninstall as glassfishv2ur1 -- afterall that is the server that 6.0.1 installs --(it is wrong to
state glassfish v2) and then it should  of course uninstall the glassfishv2ur1. 

Comment 14 dlipin 2008-01-14 15:47:23 UTC
According to the agreement with QA, as a temporary solution I`ve integrated the fix for the Issue 121538 : now 
glassfish checkbox is unchecked by default.

The further changes would be done for 6.1 release.

Checking in NbPreInstallSummaryPanel.java;
/cvs/installer/engine/src/org/netbeans/installer/wizard/components/panels/netbeans/NbPreInstallSummaryPanel.java,v  <-
-  NbPreInstallSummaryPanel.java
new revision: 1.18.2.2; previous revision: 1.18.2.1
done
Comment 15 _ hong_lin 2008-01-15 07:27:55 UTC
But I don't think making the glassfish checkbox unchecked by default is a solution to this issue. The only way to fix it
is to find the right server, which is "glassfish v2 ur1" in Krys's case, to be un-installed.
Comment 16 _ hong_lin 2008-01-15 23:42:21 UTC
I downloaded NB 6.0 and NB 6.0.1 RC1 (Build 200801100000) today and installed them:

1. NB 6.0 + GF v2
2. NB 6.0.1 + GF v2 U1, with different port numbers

When I un-installed NB 6.0.1, it checked GF v2 U1, which is the correct behavior.

If the issue is fixed, that would be great. If not, at least it is not a NB 6.0.1 stopper any more. I agree to downgrade
it to lower priority. 
Comment 17 tonybeckham 2008-01-16 18:21:11 UTC
System Info:
Linux ubuntu20 2.6.22-14-generic 
Java 1.6.0_04

Trying this:
6.0 javaee package + glassfish v2 + apache installed
6.0.1 javaee package + glassfish v2 ur1 installeld

then uninstall 6.0.1, I am asked if I want to uninstall GlassFish V2 UR1 and Apache also.  Both options are unchecked by
default.  One note is that when installing 6.0.1 w/ GF ur1, I had to change the ports and rename the existing
.asadmintrustore file for installation to proceed.  I also did not install both 6.0 and 6.0.1 to the default location
nor to the same location.

One more caveat is that after successful uninstallation of 6.0.1, then attempting to uninstall 6.0, the GF instance
installed with 6.0 was not uninstalled with the IDE uninstallation.  I had to run its uninstaller after the IDE
uninstaller ran.
Comment 18 dlipin 2008-02-27 15:01:08 UTC
retargeting -> 6.1 fcs
Comment 19 dlipin 2008-02-28 07:54:56 UTC
*** Issue 128615 has been marked as a duplicate of this issue. ***
Comment 20 dlipin 2008-03-12 12:43:21 UTC
The integration strategy is described at 
http://wiki.netbeans.org/NetBeansInstallerIDEAndRuntimesIntegration

This is the theory, but due to this issue that strategy would work only for future releases.
Comment 21 dlipin 2008-03-13 12:57:49 UTC
Fixed.
http://hg.netbeans.org/main/rev/f002276c6f6b