This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 162859 - Do not call getActions() if not necessary
Summary: Do not call getActions() if not necessary
Status: NEW
Alias: None
Product: soa
Classification: Unclassified
Component: BPEL Debugger (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Kirill Sorokin
URL: http://statistics.netbeans.org/except...
Keywords: PERFORMANCE
Depends on:
Blocks:
 
Reported: 2009-04-16 16:28 UTC by Oleg Khokhlov
Modified: 2012-04-04 03:47 UTC (History)
9 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter: 149639


Attachments
stacktrace (7.13 KB, text/plain)
2009-04-16 16:28 UTC, Oleg Khokhlov
Details
stacktrace (7.13 KB, text/plain)
2009-05-06 05:18 UTC, hantsy
Details
stacktrace (7.13 KB, text/plain)
2009-05-12 15:15 UTC, vijaykiran
Details
Test. Apply, run and it fails in testSelectAllNodesInServicesTab. (2.93 KB, patch)
2009-05-25 11:48 UTC, Jaroslav Tulach
Details | Diff
stacktrace (876 bytes, text/plain)
2012-04-04 03:47 UTC, MackSix
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Oleg Khokhlov 2009-04-16 16:28:26 UTC
Build: NetBeans IDE Dev (Build 200904160201)
VM: Java HotSpot(TM) Client VM, 11.3-b02, Java(TM) SE Runtime Environment, 1.6.0_13-b03
OS: Windows XP, 5.1, x86

User Comments:
ovk: clicked on Databases node



Stacktrace: 
java.lang.IllegalStateException: WARNING: Going from readAccess to writeAccess, see #10778: http://www.netbeans.org/issues/show_bug.cgi?id=10778 
        at org.openide.util.Mutex.enterImpl(Mutex.java:665)
        at org.openide.util.Mutex.enter(Mutex.java:630)
        at org.openide.util.Mutex.writeEnter(Mutex.java:608)
        at org.openide.util.Mutex$Privileged.enterWriteAccess(Mutex.java:1655)
        at org.openide.nodes.FilterNode$Children.changeOriginal(FilterNode.java:1362)
        at org.openide.nodes.FilterNode.changeOriginal(FilterNode.java:447)
Comment 1 Oleg Khokhlov 2009-04-16 16:28:37 UTC
Created attachment 80278 [details]
stacktrace
Comment 2 t_h 2009-04-28 14:14:55 UTC
LazyNode.getActions() can be called under Children.MUTEX read lock: core-main #c8a55db90584. However, getActions()
should be called only if needed. Please fix.
Comment 3 t_h 2009-04-28 14:17:50 UTC
Wrong changeset, should be core-main #837300bddc05
Comment 4 Sergey Lunegov 2009-04-28 14:29:10 UTC
Why did you assign this issue to bpel debugger ?
Please comment.
Comment 5 Quality Engineering 2009-04-29 07:18:04 UTC
Integrated into 'main-golden', will be available in build *200904290201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/837300bddc05
User: Tomas Holy <t_h@netbeans.org>
Log: #162859: LazyNode.getActions() can be called under Children.MUTEX read lock
Comment 6 t_h 2009-04-29 09:07:04 UTC
Because in org.netbeans.modules.bpel.debugger.ui.action.Breakpoint.propertyChange(Breakpoint.java:130)
you call getActions() for no good reason. This negatively affects some recent performance optimization - jtulach can
comment more.
Comment 7 Jaroslav Tulach 2009-04-29 13:19:01 UTC
Can't your BPEL nodes offer some "BpelCookie" in their getLookup()? That is common way to seek for extensibility. Your 
current trick with getActions()[i] instanceof BpelAction invalidates improvements done as part of 
http://bits.netbeans.org/dev/javadoc/org-openide-nodes/apichanges.html#NodeOp.factory
http://bits.netbeans.org/dev/javadoc/org-netbeans-core-ide/org/netbeans/api/core/ide/ServicesTabNodeRegistration.html
as getActions(...) turns the delarative registrations into real ones. As such just selecting a node in Services tab 
initializes it, due to the behaviour of BPEL modules.

Comment 8 hantsy 2009-05-06 05:18:39 UTC
Build: NetBeans IDE 6.7 Beta (Build 200904242137)
VM: Java HotSpot(TM) Client VM, 11.3-b02, Java(TM) SE Runtime Environment, 1.6.0_13-b03
OS: Linux, 2.6.27.21-170.2.56.fc10.i686, i386

User Comments: 


Stacktrace: 
java.lang.IllegalStateException: WARNING: Going from readAccess to writeAccess, see #10778: http://www.netbeans.org/issues/show_bug.cgi?id=10778 
        at org.openide.util.Mutex.enterImpl(Mutex.java:665)
        at org.openide.util.Mutex.enter(Mutex.java:630)
        at org.openide.util.Mutex.writeEnter(Mutex.java:608)
        at org.openide.util.Mutex$Privileged.enterWriteAccess(Mutex.java:1655)
        at org.openide.nodes.FilterNode$Children.changeOriginal(FilterNode.java:1362)
        at org.openide.nodes.FilterNode.changeOriginal(FilterNode.java:447)
Comment 9 hantsy 2009-05-06 05:18:49 UTC
Created attachment 81612 [details]
stacktrace
Comment 10 vijaykiran 2009-05-12 15:14:56 UTC
This issue was originally marked as duplicate of issue 140458, that is already fixed. This issue is still valid, so this seems to be another issue, but it might be related.

Build: NetBeans IDE 6.7 Beta (Build 200904242137)
VM: Java HotSpot(TM) Client VM, 1.5.0_16-133, Java(TM) 2 Runtime Environment, Standard Edition, 1.5.0_16-b06-284
OS: Mac OS X, 10.5.6, i386

User Comments: 
1. Opened Services View from Window Menu.
2. Clicked on Web Services.

Stacktrace: 
java.lang.IllegalStateException: WARNING: Going from readAccess to writeAccess, see #10778: http://www.netbeans.org/issues/show_bug.cgi?id=10778 
        at org.openide.util.Mutex.enterImpl(Mutex.java:665)
        at org.openide.util.Mutex.enter(Mutex.java:630)
        at org.openide.util.Mutex.writeEnter(Mutex.java:608)
        at org.openide.util.Mutex$Privileged.enterWriteAccess(Mutex.java:1655)
        at org.openide.nodes.FilterNode$Children.changeOriginal(FilterNode.java:1362)
        at org.openide.nodes.FilterNode.changeOriginal(FilterNode.java:447)
Comment 11 vijaykiran 2009-05-12 15:15:15 UTC
Created attachment 81973 [details]
stacktrace
Comment 12 Exceptions Reporter 2009-05-19 09:17:07 UTC
This issue already has 20 duplicates 
see http://statistics.netbeans.org/exceptions/detail.do?id=149639
Comment 13 Jaroslav Tulach 2009-05-25 11:48:18 UTC
Created attachment 82729 [details]
Test. Apply, run and it fails in testSelectAllNodesInServicesTab.
Comment 14 Jaroslav Tulach 2009-05-25 11:49:14 UTC
We consider this bug a stopper for 6.8 release (not 6.7). We will reprioritize it once 6.7 is out.
Comment 15 Kirill Sorokin 2009-05-26 09:26:17 UTC
Curious, why would an SOA bug be a stopper for NetBeans, provided that SOA is not part of any distribution as of 6.7..
Comment 16 Jaroslav Tulach 2009-05-26 12:41:12 UTC
Is not the BPEL stuff on stable update center? If not, then we shalln't care, of course.
Comment 17 Kirill Sorokin 2009-05-26 19:51:21 UTC
IIRC it is on Beta UC. I guess I'll find some time to fix that though.
Comment 18 MackSix 2012-04-04 03:47:19 UTC
Created attachment 117773 [details]
stacktrace

Moved a JFrame.java form with Internationalization to newpackage.