This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 164810 - Allow user to disable error checks
Summary: Allow user to disable error checks
Status: RESOLVED FIXED
Alias: None
Product: web
Classification: Unclassified
Component: HTML Editor (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Marek Fukala
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-09 12:56 UTC by Masaki Katakai
Modified: 2009-05-29 16:50 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
screenshot (69.59 KB, image/png)
2009-05-09 12:57 UTC, Masaki Katakai
Details
sample project (13.36 KB, application/x-compressed)
2009-05-18 02:52 UTC, Masaki Katakai
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Masaki Katakai 2009-05-09 12:56:01 UTC
Product Version: NetBeans IDE Dev (Build 200905080201)
Java: 1.6.0_07; Java HotSpot(TM) 64-Bit Server VM 1.6.0_07-b06-57
System: Mac OS X version 10.5.6 running on x86_64; SJIS; en (nb)

JSP errors happen on NB6.7 on editor, but no error happened on NB6.5.
The example is blow. On NB6.5.1, only errors around missing taglib
(when taglib is actually missing) are reported. On NB6.7, extra
errors are reported.

<%@page contentType="text/html; charset=UTF-8"%>
<%@taglib tagdir="/WEB-INF/tags" prefix="t"%>

<t:doctype/>
<html>
	<t:head title="title" />

	<t:body kind="info">
		<h1><img src="title.jpg"></h1>

		<h1 class="ja"><a href="./1/">1</a></h1>
		<h1 class="ja"><a href="./2/">2</a></h1>
		<br>

		label
		<p class="announce">
			<jsp:include page="test.txt" />
		</p>
		<br>
		<br>
	</t:body>
</html>
Comment 1 Masaki Katakai 2009-05-09 12:57:12 UTC
Created attachment 81843 [details]
screenshot
Comment 2 Jindrich Sedek 2009-05-11 13:09:17 UTC
could you please attach a some project where the problem can be reproduced

Thanks.
Comment 3 Marek Fukala 2009-05-11 13:56:17 UTC
No need to attach the project, I can reproduce the issue on the inlined code.
Comment 4 Marek Fukala 2009-05-11 16:03:32 UTC
the shifted errors are fixed now in web-main#d7be660b1177

The jsp errors complaining about undefined tag will disappear once you fix the tagfile

The rest - html errors - are shown since the html souce is factually incorrect (from the html point of view). OTOH I see
you generate the missing tags by some jsp tags so there should be a way how to disable these error checks for such page.
Comment 5 Quality Engineering 2009-05-12 07:43:00 UTC
Integrated into 'main-golden', will be available in build *200905120201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/d7be660b1177
User: Marek Fukala <mfukala@netbeans.org>
Log: #164810 - jsp errors are reported on 6.7 but no error on 6.5
Comment 6 Masaki Katakai 2009-05-14 05:31:25 UTC
Thank you very much Marek,

I'm now asking the original reporter to check the issue on dev build.
Once it's verified, I'll mark as VERIFIED.
Comment 7 Masaki Katakai 2009-05-18 02:50:53 UTC
There are still some errors in the following example.
The error stripes are displayed on "<html>" and "<body>".
It happens on 6.7, not on 6.5. So the original reporter
is complaining.

I'll attach the sample project.

<%@page contentType="text/html" pageEncoding="UTF-8"%>
<%@taglib tagdir="/WEB-INF/tags" prefix="t"%>

<html>
    <t:head/>

    <body>
        <h1>Hello World!</h1>
    </body>
</html>
Comment 8 Masaki Katakai 2009-05-18 02:52:22 UTC
Created attachment 82275 [details]
sample project
Comment 9 Marek Fukala 2009-05-21 06:59:51 UTC
fixed in web-main#789d081b1c94

Each html error or warning now has a hint "Disable error checking for this file". Once you apply the hint, the errors
are not shown + one new hint on the first line of the file is added - "Enable error checking in this file". This way you
can toggle the error checkes for a file.

Please note that the information whether the checks should be done or not is stored in the userdir so it is not versionable.
Comment 10 Marek Fukala 2009-05-21 09:04:07 UTC
BTW a side effect of the fix is that the file status is never green if you disable the checks due to the "reenable
checks" hint presence. By this IMHO acceptable since you can never be sure if the file is really ok if the error checks
are disabled.

Does that sound acceptable?
Comment 11 Jindrich Sedek 2009-05-21 09:35:50 UTC
I agree - disabled error checks meens that the file is not sure to be "green" (valid)
Comment 12 Quality Engineering 2009-05-21 18:44:26 UTC
Integrated into 'main-golden', will be available in build *200905211401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/789d081b1c94
User: Marek Fukala <mfukala@netbeans.org>
Log: #164810 - Allow user to disable error checks