This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 182499 - ToolsConfiguration improperly uses instanceCookie.instanceClass().newInstance()
Summary: ToolsConfiguration improperly uses instanceCookie.instanceClass().newInstance()
Status: VERIFIED FIXED
Alias: None
Product: cnd
Classification: Unclassified
Component: D-Light (show other bugs)
Version: 6.x
Hardware: All All
: P2 normal (vote)
Assignee: Alexey Vladykin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-03-22 14:55 UTC by Alexey Vladykin
Modified: 2010-03-24 15:24 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Vladykin 2010-03-22 14:55:13 UTC 
o.n.m.dlight.api.tool.ToolsConfiguration.getToolsSet() scans folder DLight/ToolConfigurationProviders for DLightToolConfigurationProvider instances, and improperly uses InstanceCookie.instanceClass().newInstance() instead of InstanceCookie.instanceCreate() to create provider instance.
This incorrect code used to work for our existing tools, but it does not work for standalone DLight tools created from XML.
We need to fix this in patch 2 for standalone DLight. The bug is already fixed in trunk.
Comment 1 Alexey Vladykin 2010-03-22 15:07:30 UTC 
Fixed in trunk almost two weeks ago: http://hg.netbeans.org/cnd-main/rev/125b6a94bec7
Comment 2 Andrew Krasny 2010-03-22 15:21:00 UTC 
Fix is OK. Safe and correct.
Comment 3 Alexey Vladykin 2010-03-22 15:30:55 UTC 
The fix from trunk can be applied to release68_fixes as is.
Comment 4 Alexander Pepin 2010-03-22 16:44:05 UTC 
It's a technical issue and can not be verified by QA.
Comment 5 pgebauer 2010-03-23 10:43:21 UTC 
The bugfix has been ported into the release68_fixes branch.
http://hg.netbeans.org/release68_fixes/rev/59745f6031c3
Comment 6 Alexander Pepin 2010-03-24 15:24:49 UTC 
verified in patch2 candidate build 20100324