This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Currently all variable values are rendered as String. Java debugger provides variable ID or toString() value. TableModel can return cell value as an arbitrary object, but the class type needs to be identical for the whole column. We should introduce some extension of TableModel that would provide custom cell renderer.
Unfortunately the cell renderer is currently hard-coded in org.openide.explorer.propertysheet.RendererFactory, which is used by PropertyPanel. OutlineViewOutline is a private class and therefore we can not override getCellRenderer() method.
Created attachment 99688 [details] API change with implementation.
Please review this API change that is necessary for JavaFX debugger. Test for this change will follow shortly...
The implementation is on debugger_view_renderers branch: http://hg.netbeans.org/main/rev/5c75009b0619
Created attachment 99783 [details] Transition of tooltips from cell renderer's component to the table's tooltip. No API change. This should have been in the swing already!
Created attachment 99784 [details] Test of the renderers, editors and tooltips taken from the model.
Further changes pushed to debugger_view_renderers branch: changeset: 172407:ec69211b150a - Use the column cell renderer even for the tree column, if defined. http://hg.netbeans.org/main/rev/ec69211b150a changeset: 172409:006ede593c0b - Convert the tooltips http://hg.netbeans.org/main/rev/006ede593c0b changeset: 172408:33e00165e1f4, 172410:b0028a1d8f90 - Tests http://hg.netbeans.org/main/rev/33e00165e1f4 http://hg.netbeans.org/main/rev/b0028a1d8f90
No Yxx from me. Just a hint. If you are on a branch and want to create a changeset that contains all your changes then: $ hg update -C default $ hg merge your_branch $ hg branch your_branch $ hg ci -m "Merge with default" Then you can send a link to the changeset on hg.netbeans.org, it will contain all your changes done on your_branch.
Thanks for the review and for the hint with merging of changesets. I'll push the change to trunk tomorrow.
Pushed in following changesets: http://hg.netbeans.org/main/rev/642773c22147 http://hg.netbeans.org/main/rev/3669ef0d5321 http://hg.netbeans.org/main/rev/583a7adc4557 http://hg.netbeans.org/main/rev/1818e019ce59 http://hg.netbeans.org/main/rev/30d43139f936 http://hg.netbeans.org/main/rev/3cb07b5489d4 http://hg.netbeans.org/main/rev/74ed34aff621 http://hg.netbeans.org/main/rev/3af4af7fb251 http://hg.netbeans.org/main/rev/45378a20793e
Integrated into 'main-golden', will be available in build *201006160001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/5c75009b0619 User: mentlicher@netbeans.org Log: #186672 Ability to provide custom cell renderers and cell editors - TableRendererModel and TableRendererModelFilter introduced.
Please verify bugfix for this bug, so it can be included in release691 repository. Thanks, -R
verified
main #5c75009b0619 transplanted to release691 #f0a674a19832
Changing status whiteboard to reflect missing changesets.
I've prepared combined change in branch debugger_ports in release691 repository.
Integrated in release691 repository changeset: 171801: release691 #b84021caf081 branch: debugger_ports user: mentlicher@netbeans.org date: Tue Jun 08 16:03:09 2010 +0200 summary: #186672 The Node.Property.canWrite() determines if the cell is editable. changeset: 171800: release691 #148859144008 branch: debugger_ports user: mentlicher@netbeans.org date: Thu Jun 03 13:57:59 2010 +0200 summary: #186672 - Test the tooltip - the cell renderer's component's tooltip needs to be provided. changeset: 171799: release691 #10b177525b39 branch: debugger_ports user: mentlicher@netbeans.org date: Thu Jun 03 13:55:46 2010 +0200 summary: #186672 Provide the cell renderer's component's tooltip as a tooltip of the table. changeset: 171798: release691 #6dd1d7fc1920 branch: debugger_ports user: mentlicher@netbeans.org date: Thu Jun 03 09:57:58 2010 +0200 summary: #186672 - Test added. changeset: 171797: release691 #1e457fbff93d branch: debugger_ports user: mentlicher@netbeans.org date: Thu Jun 03 09:56:49 2010 +0200 summary: #186672 - Use the column cell renderer even for the tree column, if defined. changeset: 171728: release691 #f0a674a19832 user: mentlicher@netbeans.org date: Mon May 31 18:40:32 2010 +0200 summary: #186672 Ability to provide custom cell renderers and cell editors - TableRendererModel and TableRendererModelFilter introduced.
Integrated into 'main-golden', will be available in build *201007220001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress) Changeset: http://hg.netbeans.org/main/rev/b0028a1d8f90 User: mentlicher@netbeans.org Log: #186672 - Test the tooltip - the cell renderer's component's tooltip needs to be provided.