23470 – CVS: "Keyword Substitution" option of "Import" command does not work.

This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 23470 - CVS: "Keyword Substitution" option of "Import" command does not work.

Summary: CVS: "Keyword Substitution" option of "Import" command does not work.

Status:	CLOSED FIXED

Alias:	None

Product:	obsolete
Classification:	Unclassified
Component:	vcsgeneric (show other bugs)
Version:	-FFJ-
Hardware:	PC Windows ME/2000

Importance:	P2 blocker (vote)
Assignee:	Martin Entlicher

URL:
Keywords:

Depends on:
Blocks:

Reported:	2002-05-14 14:52 UTC by Jiri Kovalsky
Modified:	2003-07-01 13:02 UTC (History)
CC List:	1 user (show)

See Also:
Issue Type:	DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jiri Kovalsky 2002-05-14 14:52:38 UTC

Forte for Java 4.0, Community Edition RC2 on Windows XP with JDK 1.4 build #92

Description:
=========
There is an obvious error in "Input Descriptor" of "CVS|Import..." command. Mentioned 
combobox stores its value to RCS_KFLAG variable however execution string uses RCS_FLAG 
which results in an empty string. This means that directory with all binary files can't be imported 
using this command.

Steps to reproduce:
==============
1. Mount CVS filesystem using Command-line Client and create new directory with one file in it.
2. Right click this [Local] directory, hold down CTRL key and choose "CVS|Import...".
3. Setup all that is necessary and choose "Binary (-kb)" option as "Keyword Substitution".
4. Push "OK" button and confirm the dialog.
5. Invoke "CVS|Log" on your [Up-to-date; 1.1.1.1] file and verify that it is treated as "-kv".

Comment 1 Martin Entlicher 2002-05-14 16:27:21 UTC

This is a trivial bug, starting to fix it...

Comment 2 Martin Entlicher 2002-05-14 16:29:37 UTC

Fixed in dev build May 15.

Comment 3 Jiri Kovalsky 2002-05-15 10:01:05 UTC

This is unfortunately possible data loss if user wants to import whole
directory containing for instance some pictures. Import operation
damages all of transferred files by treating them as textual.
Therefore increasing priority. I think this should go to Forte for
Java 4.0 FCS.

Comment 4 Martin Entlicher 2002-05-15 10:31:25 UTC

Agreed. The fix is trivial and has no side effects for sure, it's just
a spelling error ("RCS_FLAG" should be "RCS_KFLAG"):

http://www.netbeans.org/source/browse/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/config/cvsUnix.xml.diff?r1=1.9&r2=1.10

http://www.netbeans.org/source/browse/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/config/cvsWin.xml.diff?r1=1.9&r2=1.10

http://www.netbeans.org/source/browse/vcsgeneric/profiles/cvsprofiles/src/org/netbeans/modules/vcs/profiles/cvsprofiles/config/cvsWin98.xml.diff?r1=1.9&r2=1.10

Comment 5 Jiri Kovalsky 2002-06-04 14:53:05 UTC

Works fine in development build #200206040100 of NetBeans 3.4.

Comment 6 Quality Engineering 2003-07-01 13:02:52 UTC

Resolved for 3.4.x or earlier, no new info since then -> closing.