Setting TM to 4.1.

We should hanle this error and display a message that the server
plugin has been removed.

We might have to test again this from 4.0 (and nbm for AS 80 plugin)
and upgrade to 4.1

If we have issues there, then it would become a p2 need to fix in 4.1

Jarda, can you test this?

Import settings from 4.0 to 4.1 doesn't work correctly too.

Several excveptions are thrown during startup:

javax.enterprise.deploy.spi.exceptions.DeploymentManagerCreationException: The
Application Server installation directory is not correctly set up. (Use the
Tools>Options>IDE Configuration menu enter a correct value.)

java.lang.IllegalStateException: Failed to get FileObject for server instance
deployer:Sun:AppServer::localhost:4848

org.netbeans.mdr.persistence.StorageBadRequestException: There is no value for
key "storageIds:"

This exception is thrown when I go to Server Registry:

java.lang.IllegalStateException: Failed to get FileObject for server instance
deployer:Sun:AppServer::localhost:4848

This exception was thrown when I invoken Add Server action on Server Registry:

java.lang.NullPointerException
	at
org.netbeans.modules.j2ee.deployment.impl.ui.wizard.ServerChooserVisual.getServerInstance(ServerChooserVisual.java:130)

Created attachment 21334 [details]
messages.log

I've tested import with NetBeans 4.0 build 200503231515,SJAS8.0 update 1 and
latest plugin.Then I used current daily build of NetBeans 4.1 200504031800.
I've tested on WindowsXP SP2

1)In most cases,warning about plugin removed has been displayed:

Warning - could not install some modules:
	Sun Java System Application Server 8 - The module Database Explorer was
requested in implementation version "release40" but only "1.1" was found.
	Sun Java System Application Server 8 - The module XML Core was requested in
implementation version "release40" but only "3.999.4" was found.

but it was immediatelly followed with this Unexpected exception in the IDE:

Annotation: Error encountered while reading
MultiFileObject@628704[nbfs://nbhost/SystemFileSystem/Modules/org-netbeans-modules-j2ee-sun-ide.xml]
org.netbeans.core.modules.DuplicateException:
C:\Testing\Userdir\NB4.1\modules\org-netbeans-modules-j2ee-sun-ide.jar is a
duplicate of C:\Testing\Userdir\NB4.1\modules\org-netbeans-modules-j2ee-sun-ide.jar
	at org.netbeans.core.modules.ModuleManager.subCreate(ModuleManager.java:581)
	at org.netbeans.core.modules.ModuleManager.create(ModuleManager.java:465)
	at org.netbeans.core.modules.ModuleList$1.run(ModuleList.java:233)
	at org.openide.filesystems.EventControl.runAtomicAction(EventControl.java:89)
	at org.openide.filesystems.FileSystem.runAtomicAction(FileSystem.java:432)
	at org.netbeans.core.modules.ModuleList.readInitial(ModuleList.java:133)
	at org.netbeans.core.modules.ModuleSystem.readList(ModuleSystem.java:239)
	at org.netbeans.core.NonGui.run(NonGui.java:353)
	at org.netbeans.core.Main.run(Main.java:185)
	at org.netbeans.core.NbTopManager.getNbTopManager(NbTopManager.java:241)
	at org.netbeans.core.NbTopManager.get(NbTopManager.java:190)
	at org.netbeans.core.Main.start(Main.java:311)
	at org.netbeans.core.TopThreadGroup.run(TopThreadGroup.java:90)
[catch] at java.lang.Thread.run(Thread.java:595)

I also experienced,that warning's window is very easy to lose focus and then
hard to access it again,because of lack its own task down in the system
tray.Moreof IDE main window isn't accessible until warning's window is shut
down,so it MUST be closed.

In one case was result slightly different,I haven't got the Warning message
window,server just vanished from Runtime tab and in message.log was the same output.

I will add the message.log as attachment.

Created attachment 21337 [details]
My message.log

We had two choices to display or not to display a warning dialog if plugin or
server instance cannot be imported. After a short discussion we decided for the
second option - not to display a warning dialog (only an informational message
will be logged).

The reason for this decision was that the message dialog would be displayed over
the startup splash screen which would suspend the startup until the OK button
would be pressed and second, it looked quite weird.

A test whether a disconnected deployment manager instance can be created or not
was added and is called when an server instance is being added. This was a kind
of regression I made in order to fix issue 57166 in which a connected deployment
manager instance was being called which was a bug.

F.

Checking in src/org/netbeans/modules/j2ee/deployment/impl/ServerRegistry.java;
/cvs/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerRegistry.java,v
 <--  ServerRegistry.java
new revision: 1.42; previous revision: 1.41
done

http://j2eeserver.netbeans.org/source/browse/j2eeserver/src/org/netbeans/modules/j2ee/deployment/impl/ServerRegistry.java?r1=1.41&r2=1.42

i reviewed the fix and I am ok with it

The patch was integrated to release41 branch.

verified