This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 53244 - Review of PackageView extension
Summary: Review of PackageView extension
Status: CLOSED FIXED
Alias: None
Product: java
Classification: Unclassified
Component: Project (show other bugs)
Version: 4.x
Hardware: All All
: P3 blocker (vote)
Assignee: Tomas Zezula
URL:
Keywords: API_REVIEW_FAST
Depends on:
Blocks: 48618
  Show dependency tree
 
Reported: 2005-01-11 16:29 UTC by Tomas Zezula
Modified: 2006-03-24 12:55 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Diff (20.99 KB, patch)
2005-01-11 16:30 UTC, Tomas Zezula
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Zezula 2005-01-11 16:29:32 UTC
The class
org.netbeans.spi.java.project.support.ui.PackageView
 was extended by factory methods creating the
ComboBoxModel of packages from given SourceGroup
and ListCellRenderer rendering the package.

UseCases: There is a need to create chooser of
packages on several places in the IDE (new file
wizard, refactoring - move class)

API Stability: Should be stable API in the
NetBeans 4.1
Comment 1 Tomas Zezula 2005-01-11 16:30:44 UTC
Created attachment 19620 [details]
Diff
Comment 2 Jesse Glick 2005-01-11 20:12:17 UTC
Looks fine to me.
Comment 3 Tomas Pavek 2005-01-12 13:28:01 UTC
Diff is ok, I see no problem with the change.
Comment 4 Jaroslav Tulach 2005-01-12 15:48:18 UTC
ComboBoxModel! Why not Node? Otherwise ok.
Comment 5 Jesse Glick 2005-01-12 19:13:55 UTC
I suppose it could use Node, but it works fine the way it is, so why
add extra layers of abstraction? You can take the model and set it on
a JComboBox and you are done; and that is the only use case for it.
Comment 6 Tomas Zezula 2005-01-13 08:42:02 UTC
It returns ComboBoxModel since it is used in JComboBoxes. The
JComboBox is more reliable than ChoiceView which accepts nodes.
Comment 7 Miloslav Metelka 2005-01-13 10:13:20 UTC
I agree with the integration.
Comment 8 Tomas Zezula 2005-01-13 13:21:59 UTC
Checking in java/project/apichanges.xml;
/cvs/java/project/apichanges.xml,v  <--  apichanges.xml
new revision: 1.5; previous revision: 1.4
done
Processing log script arguments...
More commits to come...
Checking in
java/project/src/org/netbeans/modules/java/project/JavaTargetChooserPanelGUI.java;
/cvs/java/project/src/org/netbeans/modules/java/project/JavaTargetChooserPanelGUI.java,v
 <--  JavaTargetChooserPanelGUI.java
new revision: 1.23; previous revision: 1.22
done
Removing
java/project/src/org/netbeans/modules/java/project/PackageListView.java;
/cvs/java/project/src/org/netbeans/modules/java/project/PackageListView.java,v
 <--  PackageListView.java
new revision: delete; previous revision: 1.2
done
Processing log script arguments...
More commits to come...
Checking in
java/project/src/org/netbeans/spi/java/project/support/ui/PackageView.java;
/cvs/java/project/src/org/netbeans/spi/java/project/support/ui/PackageView.java,v
 <--  PackageView.java
new revision: 1.10; previous revision: 1.9
done
Processing log script arguments...
More commits to come...
Checking in
refactoring/src/org/netbeans/modules/refactoring/ui/MoveClassPanel.java;
/cvs/refactoring/src/org/netbeans/modules/refactoring/ui/MoveClassPanel.java,v
 <--  MoveClassPanel.java
new revision: 1.15; previous revision: 1.14
done
Removing
refactoring/src/org/netbeans/modules/refactoring/ui/PackageListView.java;
/cvs/refactoring/src/org/netbeans/modules/refactoring/ui/PackageListView.java,v
 <--  PackageListView.java
new revision: delete; previous revision: 1.1
done
Comment 9 Jaromir Uhrik 2006-01-18 10:48:02 UTC
Marking this issue as VERIFIED since the issue reporter == issue owner.