This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 87369 - Completion module has implementation dependency on text module
Summary: Completion module has implementation dependency on text module
Status: CLOSED FIXED
Alias: None
Product: xml
Classification: Unclassified
Component: Schema Tools (show other bugs)
Version: 5.x
Hardware: All All
: P2 blocker (vote)
Assignee: Samaresh Panda
URL:
Keywords:
Depends on: 87244
Blocks:
  Show dependency tree
 
Reported: 2006-10-17 21:48 UTC by Karthikeyan Rajeswaran
Modified: 2007-03-30 20:06 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Karthikeyan Rajeswaran 2006-10-17 21:48:47 UTC
The following warning is issued by the build system while building
schema/completion module:
   jar:
   Warning: in org.netbeans.modules.xml.schema.completion, not using   
   spec.version.base, yet declaring implementation dependencies; may lead to 
   problems with Auto Update

Ideally module dependencies should be specified via spec numbers so that when
the dependent module is updated, the depending module can still work with it. If
the dependency is specified with respect to a specific implementation value,
then when the dependent module's implementation version is updated, the
depending module will not work. 

From schema/completion/nbprojct/project.xml:

<dependency>
   <code-name-base>org.netbeans.modules.xml.text</code-name-base>
   <build-prerequisite/>
   <compile-dependency/>
   <run-dependency>
      <release-version>2</release-version>
      <implementation-version/>
   </run-dependency>
</dependency>
Comment 1 Samaresh Panda 2006-10-18 00:13:30 UTC
We have two choices:
- have text-edit declare this module as friend
(http://www.netbeans.org/issues/show_bug.cgi?id=87244)
- make xml/schema/completion and text-edit be part of one cluster.

None of this is possible at this time, that is, it cannot be fixed at this time.
Comment 2 Samaresh Panda 2006-10-23 22:09:39 UTC
Marking this as enhancement, since this cannot be fixed at this point for
release55. We can take care of this in 6.0.
Comment 3 Samaresh Panda 2006-11-30 00:19:03 UTC
Depends on 87244.
Comment 4 Samaresh Panda 2007-01-10 20:24:51 UTC
Fix integrated:
Checking in friend-packages.txt;
/cvs/ide/golden/friend-packages.txt,v  <--  friend-packages.txt
new revision: 1.15.4.1.2.134.6.8; previous revision: 1.15.4.1.2.134.6.7

Checking in impl-deps.txt;
/cvs/ide/golden/impl-deps.txt,v  <--  impl-deps.txt
new revision: 1.30.2.4.2.8.14.1; previous revision: 1.30.2.4.2.8

Checking in project.xml;
/cvs/xml/xdm/nbproject/project.xml,v  <--  project.xml
new revision: 1.1.2.17.14.3; previous revision: 1.1.2.17.14.2

Checking in project.xml;
/cvs/xml/text-edit/nbproject/project.xml,v  <--  project.xml
new revision: 1.5.2.1.2.3.28.1; previous revision: 1.5.2.1.2.3

Checking in project.xml;
/cvs/xml/schema/completion/nbproject/project.xml,v  <--  project.xml
new revision: 1.1.2.6.26.1; previous revision: 1.1.2.6
Comment 5 Samaresh Panda 2007-01-23 01:59:22 UTC
Here is the new project.xml snippet from completion module:
    <dependency>
        <code-name-base>org.netbeans.modules.xml.text</code-name-base>
        <build-prerequisite/>
        <compile-dependency/>
        <run-dependency>
            <release-version>2</release-version>
            <specification-version>1.12.21.4.4</specification-version>
        </run-dependency>
    </dependency>

This explains.
Comment 6 khu 2007-03-30 20:06:45 UTC
Verified in NB551 build.
There is no warning in the build log; furthermore, the new project.xml from
completion module does show :

dependencies is specified via spec numbers