This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 87821 - Remove comments from ml Bundle.properties in build process
Summary: Remove comments from ml Bundle.properties in build process
Status: RESOLVED FIXED
Alias: None
Product: www
Classification: Unclassified
Component: Builds & Repositories (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: rbalada
URL:
Keywords:
Depends on:
Blocks: 118390
  Show dependency tree
 
Reported: 2006-10-24 04:21 UTC by Masaki Katakai
Modified: 2007-10-11 22:48 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Masaki Katakai 2006-10-24 04:21:16 UTC 
Hi RE team,

Is it possible to remove comment lines from localized Bundle.properties
at build time?

It seems that current build script is doing this for English
Bundle.properties (in bug 58298) for size reduction and performance.

Below is the simple result only for Japanese. We will have Chinese and
pt-BR, also more languages. So I think we should do the same reduction
in ml builds.

$ find */*/src */src -name "*_ja.properties" | xargs grep  -v -h "^#" | wc
    9892   12735  651545
$ find */*/src */src -name "*_ja.properties" | xargs cat | wc
   20316   69883 1147587
Comment 1 rbalada 2007-04-17 16:45:37 UTC 
Changing version to 6.0. Setting preliminary milestone to 6.0M11.

I've found sample how to easily do that in nbbuild/templates/common.xml

         <copy todir="${build.classes.dir}">
            <!-- #58298: strip comments to save some space -->
            <fileset dir="${src.dir}" includes="**/*.properties"/>
            <filterchain>
                <tokenfilter>
                    <!-- #61965: preserve #NOI18N and similar comments -->
                    <filetokenizer/>
                    <replaceregex pattern="^#(?!(PART)?(NO)?I18N).*[\r\n]+"
replace="" flags="gm"/>
                </tokenfilter>
            </filterchain>
        </copy>
Comment 2 rbalada 2007-09-27 21:56:32 UTC 
Reassigning to me. Actual working prototype of NB 6.0 ML build already has a fix for this issue.
Comment 3 rbalada 2007-10-11 22:45:55 UTC 
Checking in nbbuild/templates/projectized.xml;
/cvs/nbbuild/templates/projectized.xml,v  <--  projectized.xml
new revision: 1.131; previous revision: 1.130
done