This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Setting some defaults on the Plugin Portal accounts | ||
---|---|---|---|
Product: | updatecenters | Reporter: | pekinsoft <pekinsoft> |
Component: | Pluginportal | Assignee: | issues@updatecenters <issues> |
Status: | RESOLVED FIXED | ||
Severity: | blocker | ||
Priority: | P3 | ||
Version: | 6.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | ENHANCEMENT | Exception Reporter: |
Description
pekinsoft
2009-03-26 07:13:47 UTC
I was just looking at the source code on Kenai for the verifications page. The one thing that I noticed pretty quickly was the following: -=-=-=- CODE SNIPPET -=-=-=- while (vrIterator.hasNext()) { currentVR = vrIterator.next(); /** * First, if this is the verificationrequest for this user, load the user's verificationrequest data. */ if (currentVR.getVerifier().getUserid().equals(this.getSessionBean1().getCurrentUserProfile().getUserid())) { /** * If the checkBox for hide decided is checked, only show undecided * */ if (getSessionBean1().isHideDecided() && currentVR.getVote() != 0) { hideRequest = true; break; } currentVerification.setVerificationRequestID(currentVR.getId()); currentVerification.setStatus(Integer.toString(currentVR.getVote())); currentVerification.setSelectedOption(Integer.toString(currentVR.getVote())); currentVerification.setComment(currentVR.getComment()); currentVerification.setRequestDate(currentVR.getRequestDate()); } -=-=-=- END CODE SNIPPET -=-=-=- Would it be possible to reverse the logic on the second if() block in the while and reverse what is said in the checkbox on the page, so that the logic comes out to only showing the decided verifications if the verifier chooses to do so. In other words, instead of: if (getSessionBean1().isHideDecided() && currentVR.getVote() != 0) { hideRequest = true; break; } Couldn't the logic be reversed to: if (getSessionBean1().isHideDecided() && currentVR.getVote() != 0) { hideRequest = false; break; } Now, I may not be following the logic of the current code as well as I think I am, but the default for old votes should be in a hidden state. Obviously, the logic inside of the SessionBean would need to take care of that, and I have just started looking at where changes could be made to help speed the verifications site up a little. Just tell me to shut up and I will ;) I have another update on something I've discovered with the checkbox setting... Yesterday, I had logged in to the Plugin Portal and selected the checkbox to only show the undecided requests. I had then logged out, but left my browser open at the Plugin Portal main page. I continued to leave my browser open all day and when I logged back in about 6 hours later, the checkbox was no longer selected, even though I had not closed my browser. So, now, I'm not sure what the deal is...so much for it being a session thing. It seems that the persisting may not be tied to the browser state either...at least not just the browser state. Status update. Since yesterday default value of "Only Show Undecided Requests" option is ON, so one does not have to always click it to reduce the long list of entries. However, complete list of all verification requests is still being loaded from the server so I don't know how much performance improvement this will bring. Verification requests are now grouped into 3 different tables. 1st group with requests needing immediate attention is shown by default paginated by 5 plugins. All changes allow to close this RFE as fixed. |