This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 161216 - Setting some defaults on the Plugin Portal accounts
Summary: Setting some defaults on the Plugin Portal accounts
Status: RESOLVED FIXED
Alias: None
Product: updatecenters
Classification: Unclassified
Component: Pluginportal (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker with 1 vote (vote)
Assignee: issues@updatecenters
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-03-26 07:13 UTC by pekinsoft
Modified: 2012-01-02 15:06 UTC (History)
0 users

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description pekinsoft 2009-03-26 07:13:47 UTC
Would it be possible to have the following enhancements made to the Plugin Portal?

1.  By default, sort the list of plugins to be verified by newest to oldest, instead of how they are now.
2.  Provide an option that may be set by the user within their profile so that we can make it the default to show only
    undecided plugin verification requests and not see our old decisions unless we choose to.

Every time that I receive a plugin verification request and go to the site, it gets slower to load than the last time 
I visited it.  I know that some of the lag-time could be do the amount of traffic on the site at that moment and the 
number of people currently, actively surfing the internet through my ISP, but I'm sure that quite a bit of the lag is 
do to the shear numbers of plugin verifications that are being loaded.  

I believe that if we have the "Show Undecided Verifications Only" option turned on by default, the load time should 
increase quite a bit.  I know that, once the page has loaded, when I check that option, the reload doesn't take very 
long at all.  Also, if the verification requests are loaded from newest to oldest, we would be able to see the new 
verification requests without the need to select the "Undecided Only" option or scrolling through numerous pages of 
old verification requests to get to the one we're after.
Comment 1 pekinsoft 2009-04-08 16:03:37 UTC
I was just looking at the source code on Kenai for the verifications page.  The one thing that I noticed pretty quickly
was the following:

-=-=-=- CODE SNIPPET -=-=-=-
 while (vrIterator.hasNext()) {  
   currentVR = vrIterator.next();  
   /** 
    * First, if this is the verificationrequest for this user, load the user's verificationrequest data. 
    */  
   if (currentVR.getVerifier().getUserid().equals(this.getSessionBean1().getCurrentUserProfile().getUserid())) {  
   /** 
    * If the checkBox for hide decided is checked, only show undecided  
    * 
    */  
    if (getSessionBean1().isHideDecided() && currentVR.getVote() != 0) {  
      hideRequest = true;  
      break;  
    }  
   currentVerification.setVerificationRequestID(currentVR.getId());  
   currentVerification.setStatus(Integer.toString(currentVR.getVote()));  
   currentVerification.setSelectedOption(Integer.toString(currentVR.getVote()));  
   currentVerification.setComment(currentVR.getComment());  
   currentVerification.setRequestDate(currentVR.getRequestDate());  
}  
-=-=-=- END CODE SNIPPET -=-=-=-

Would it be possible to reverse the logic on the second if() block in the while and reverse what is said in the checkbox
on the page, so that the logic comes out to only showing the decided verifications if the verifier chooses to do so.  In
other words, instead of:

    if (getSessionBean1().isHideDecided() && currentVR.getVote() != 0) {  
      hideRequest = true;  
      break;  
    }  

Couldn't the logic be reversed to:

   if (getSessionBean1().isHideDecided() && currentVR.getVote() != 0) {
     hideRequest = false;
     break;
   }

Now, I may not be following the logic of the current code as well as I think I am, but the default for old votes should
be in a hidden state.  Obviously, the logic inside of the SessionBean would need to take care of that, and I have just
started looking at where changes could be made to help speed the verifications site up a little.

Just tell me to shut up and I will ;)
Comment 2 pekinsoft 2009-10-19 15:32:28 UTC
I have another update on something I've discovered with the checkbox setting...

Yesterday, I had logged in to the Plugin Portal and selected the checkbox to only show the undecided requests.  I had
then logged out, but left my browser open at the Plugin Portal main page.  I continued to leave my browser open all day
and when I logged back in about 6 hours later, the checkbox was no longer selected, even though I had not closed my
browser.  So, now, I'm not sure what the deal is...so much for it being a session thing.  It seems that the persisting
may not be tied to the browser state either...at least not just the browser state.
Comment 3 Jiri Kovalsky 2009-11-12 02:59:10 UTC
Status update. Since yesterday default value of "Only Show Undecided Requests" option is ON, so one does not have to always click it to reduce the long list of entries. However, complete list of all verification requests is still being loaded from the server so I don't know how much performance improvement this will bring.
Comment 4 Jiri Kovalsky 2012-01-02 15:06:34 UTC
Verification requests are now grouped into 3 different tables. 1st group with requests needing immediate attention is shown by default paginated by 5 plugins. All changes allow to close this RFE as fixed.