This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Review of PackageView extension | ||
---|---|---|---|
Product: | java | Reporter: | Tomas Zezula <tzezula> |
Component: | Project | Assignee: | Tomas Zezula <tzezula> |
Status: | CLOSED FIXED | ||
Severity: | blocker | CC: | jbecicka |
Priority: | P3 | Keywords: | API_REVIEW_FAST |
Version: | 4.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: | |
Bug Depends on: | |||
Bug Blocks: | 48618 | ||
Attachments: | Diff |
Description
Tomas Zezula
2005-01-11 16:29:32 UTC
Created attachment 19620 [details]
Diff
Looks fine to me. Diff is ok, I see no problem with the change. ComboBoxModel! Why not Node? Otherwise ok. I suppose it could use Node, but it works fine the way it is, so why add extra layers of abstraction? You can take the model and set it on a JComboBox and you are done; and that is the only use case for it. It returns ComboBoxModel since it is used in JComboBoxes. The JComboBox is more reliable than ChoiceView which accepts nodes. I agree with the integration. Checking in java/project/apichanges.xml; /cvs/java/project/apichanges.xml,v <-- apichanges.xml new revision: 1.5; previous revision: 1.4 done Processing log script arguments... More commits to come... Checking in java/project/src/org/netbeans/modules/java/project/JavaTargetChooserPanelGUI.java; /cvs/java/project/src/org/netbeans/modules/java/project/JavaTargetChooserPanelGUI.java,v <-- JavaTargetChooserPanelGUI.java new revision: 1.23; previous revision: 1.22 done Removing java/project/src/org/netbeans/modules/java/project/PackageListView.java; /cvs/java/project/src/org/netbeans/modules/java/project/PackageListView.java,v <-- PackageListView.java new revision: delete; previous revision: 1.2 done Processing log script arguments... More commits to come... Checking in java/project/src/org/netbeans/spi/java/project/support/ui/PackageView.java; /cvs/java/project/src/org/netbeans/spi/java/project/support/ui/PackageView.java,v <-- PackageView.java new revision: 1.10; previous revision: 1.9 done Processing log script arguments... More commits to come... Checking in refactoring/src/org/netbeans/modules/refactoring/ui/MoveClassPanel.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/ui/MoveClassPanel.java,v <-- MoveClassPanel.java new revision: 1.15; previous revision: 1.14 done Removing refactoring/src/org/netbeans/modules/refactoring/ui/PackageListView.java; /cvs/refactoring/src/org/netbeans/modules/refactoring/ui/PackageListView.java,v <-- PackageListView.java new revision: delete; previous revision: 1.1 done Marking this issue as VERIFIED since the issue reporter == issue owner. |