This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | Toolbar icons don't become disabled if action is unavailable | ||
---|---|---|---|
Product: | editor | Reporter: | Roman Strobl <rstrobl> |
Component: | -- Other -- | Assignee: | issues@editor <issues> |
Status: | RESOLVED WONTFIX | ||
Severity: | blocker | ||
Priority: | P4 | ||
Version: | 4.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
Roman Strobl
2005-03-16 19:20:34 UTC
Although I generally agree with the request I would be rather selective regarding choosing of the actions that will change their enabled status because updating of the status takes extra resources. We certainly do not want to maintain precise status for all 110+ editor's actions. Moreover we need to consider that each opened file has its own editor toolbar so updating of the status of a shared global resource (such as jumplist) will fire all the opened files (though the updates should be cheap as there is no visual updating taking place except the file on top). We will try to implement this for 4.1 at least for back/forward icons. Milo, I agree that we don't want not maintain status of all actions. On the other hand if we implement it only for back/forward it may look inconsistent. The best solution IMHO would be to keep status of all actions which are visible in the toolbar and have the forward/back functionality (they are 3x2 AFAIK). Unless there would be an issue with performance you mention. In that case it is a question whether we want to have the feature even if it will be a bit inconsistant. I would still say yes, but there may be other opinions. Implemented for moving Back/Forward in the Jump List. Checking in ActionFactory.java; /cvs/editor/libsrc/org/netbeans/editor/ActionFactory.java,v <-- ActionFactory.java new revision: 1.66; previous revision: 1.65 done Checking in BaseCaret.java; /cvs/editor/libsrc/org/netbeans/editor/BaseCaret.java,v <-- BaseCaret.java new revision: 1.107; previous revision: 1.106 done Checking in JumpList.java; /cvs/editor/libsrc/org/netbeans/editor/JumpList.java,v <-- JumpList.java new revision: 1.13; previous revision: 1.12 done Changed TM from 4.1 to TBD, please re-evaluate. Thanks! issue will probably not fixed into NB 5.0 Back, forward fixed. Rest is P4. Will be resolved LATER. NetBeans.org Migration: changing resolution from LATER to WONTFIX |