This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 56570 - Toolbar icons don't become disabled if action is unavailable
Summary: Toolbar icons don't become disabled if action is unavailable
Status: RESOLVED WONTFIX
Alias: None
Product: editor
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 4.x
Hardware: All All
: P4 blocker (vote)
Assignee: issues@editor
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-16 19:20 UTC by Roman Strobl
Modified: 2009-11-02 11:01 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Strobl 2005-03-16 19:20:34 UTC 
There are several icons in editor toolbar that should become disabled if user
cannot activate them. It starts to be a topic with introduction of back/forward
icons. Users will probably expact similar functionality as in web browser, it's
common that arrows become disabled if no action is possible. The same is valid
for other actions such as prev/next bookmark, matching words and search.
Comment 1 Miloslav Metelka 2005-03-17 10:43:11 UTC 
Although I generally agree with the request I would be rather selective
regarding choosing of the actions that will change their enabled status because
updating of the status takes extra resources. We certainly do not want to
maintain precise status for all 110+ editor's actions. Moreover we need to
consider that each opened file has its own editor toolbar so updating of the
status of a shared global resource (such as jumplist) will fire all the opened
files (though the updates should be cheap as there is no visual updating taking
place except the file on top). We will try to implement this for 4.1 at least
for back/forward icons.
Comment 2 Roman Strobl 2005-03-18 08:30:29 UTC 
Milo, I agree that we don't want not maintain status of all actions. On the
other hand if we implement it only for back/forward it may look inconsistent.
The best solution IMHO would be to keep status of all actions which are visible
in the toolbar and have the forward/back functionality (they are 3x2 AFAIK).
Unless there would be an issue with performance you mention. In that case it is
a question whether we want to have the feature even if it will be a bit
inconsistant. I would still say yes, but there may be other opinions.
Comment 3 Dusan Balek 2005-03-25 09:17:40 UTC 
Implemented for moving Back/Forward in the Jump List.

Checking in ActionFactory.java;
/cvs/editor/libsrc/org/netbeans/editor/ActionFactory.java,v  <--  ActionFactory.java
new revision: 1.66; previous revision: 1.65
done
Checking in BaseCaret.java;
/cvs/editor/libsrc/org/netbeans/editor/BaseCaret.java,v  <--  BaseCaret.java
new revision: 1.107; previous revision: 1.106
done
Checking in JumpList.java;
/cvs/editor/libsrc/org/netbeans/editor/JumpList.java,v  <--  JumpList.java
new revision: 1.13; previous revision: 1.12
done
Comment 4 Roman Strobl 2005-07-11 14:37:17 UTC 
Changed TM from 4.1 to TBD, please re-evaluate. Thanks!
Comment 5 Martin Roskanin 2005-11-01 16:48:19 UTC 
issue will probably not fixed into NB 5.0
Comment 6 Jan Becicka 2008-02-15 08:12:30 UTC 
Back, forward fixed. Rest is P4.
Comment 7 Max Sauer 2008-11-28 09:20:42 UTC 
Will be resolved LATER.
Comment 8 Quality Engineering 2009-11-02 11:01:26 UTC 
NetBeans.org Migration: changing resolution from LATER to WONTFIX