This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
Summary: | [41cat] International characters do not show up properly in Local Variables view | ||
---|---|---|---|
Product: | platform | Reporter: | Miloslav Metelka <mmetelka> |
Component: | Outline&TreeTable | Assignee: | Stanislav Aubrecht <saubrecht> |
Status: | RESOLVED WONTFIX | ||
Severity: | blocker | CC: | cberger, cezariusz, jchalupa, mkrauskopf, non_migrated_user, saubrecht, zikmund |
Priority: | P3 | Keywords: | I18N |
Version: | 4.x | ||
Hardware: | All | ||
OS: | All | ||
Issue Type: | DEFECT | Exception Reporter: |
Description
Miloslav Metelka
2005-04-12 15:31:52 UTC
thanks ;) BTW: 1) when I click on the [...] on the "Type" column, I see the exact same "null" problem that I see on the "Value" column. 2) Instead of the "Value - Value" and "Type - Type" dialog title, it would be IMHO much better to put the name of the variable, like "c2 - Value" and "c2 - Type" (on on the opposite order). I guess that was the intended behaviour, and that some bugs are there. This code is in openide, as far as I know. We are not renrerring properties in TreeTableView, nor tooltips. Oh, and while playing in there: If I click on the [...] at the right of the "#52(length=0)" value (for args variable), the "Value - Value" dialog is editable, and when I close it by pressing "OK", I get that ugly error: Lexical error at line 1, column 1. Encountered: "#" (35), after : "" I guess that for value that are not editable, the dialog should show up as "readonly", like for the "Type" column. Sorry for adding one more item to that already loaded report... This is less important than the editing features, but if it's easy to fix... Why is the cat41 been removed? Does this bug appear on NB-4.1 dashboard? Stan, please look at it. Start with the test case provided in issue #57240. I suspect there still may be more issues to solve in various places. makeDisplayable() in TableSheetCell and RendererFactory is supposed to handle some cases when a string with non-displayable characters is being displayed, but it gets broken when the user tries to edit the cell content either in-place, or via the [...] button. it's not a problem to fix the broken tooltips but i'm not sure about the editing functionality. it's possible to escape all strings before they are passed to editor and then parse and un-escape them when editing stops. but then i can imagine windows users complaining they can't edit file name values in debugger windows because they're seeing something like this: "C:\\Projects\\Netbeans\\openide\\scr\\somefile.java" comments anyone? IMHO, that is not a big problem, ppl are used to the need of double-slashes in Java. BTW, a little detail, but why are the initial " and ' quote characters not stripped when entering editing mode? that would for sure be more user-friendly. I mean, initial and final quotes. That would be cool if the field display "\n", but when you edit it, it just shows \n, so editing is simplified. Just checked that displaying/editing of string with escaped characters didn't work at all in NB 4.0. The current state is a big progress already. cberger, thanks for pushing it. One of the issues described here -- tooltips in the Value columns -- can be fixed easily. The editing is more complex, it has to be fixed in multiple places and will need to be thoroughly tested. There's no time left to make it for 4.1. Tooltips will be fixed for 4.1. Editing will not. I'm downgrading this issue to P3. fixed the tooltip part: Checking in org/openide/explorer/view/TableSheetCell.java; /cvs/openide/src/org/openide/explorer/view/TableSheetCell.java,v <-- TableSheetCell.java new revision: 1.26; previous revision: 1.25 done The editing part will be fixed for 4.2. I tested it in Build 200507041800 and I've got still problem with tooltips. If you use the source which is in issue 57420, the variables c1='\33', c6='\ue161'and s="\33\n\"'\\\ue161" have got tooltips with squeres. I'm using JDK 1.6.0-ea. BTW variables s and c1 have got bad value in value column. Sorry, in build 200508041800 evaluation: 1. as far as i can tell the tooltips now behave correctly (in editor pane as well as in debugger views). 2. the incorrect rendering of string values in debugger views is now the problem of the debugger module. the debugger supplies the values to be rendered as html string (htmlDisplayValue property) to signal value changes in bold face etc. in this case the property sheet does *not* check the value for non-displayable characters. imho, the debugger should check for non-displayble characters when constructing its html strings. 3. the editing part seems to be the most complicated one. the debugger does not support multi-line text values, however chars '\' and 'n' are interpreted as a newline char ("\n"). on the other hand the same editor in e.g. form designer accepts multi-line text and chars '\' and 'n' are interpreted as "\\n" (and show as such in the designer window). it's possible to escape the value before editing and replace all non-displayable chars with their "\uxxxx" equivalents and then re-parse the value before it is commited to the model. however i don't know how to implement consistent handling of newline chars. (maybe a special string editor for debugger views?) all comments are very welcome. reassigning to the debugger team to implement the conversion of non-displayable characters to '\uxxxx' strings in htmlDisplayValue properties. please reassign back to me if you think the conversion should be done in the property sheet after the html code creation. IMHO the code that displays the String should care about non-displayable characters. Also it's good to have this in one place in openide, since other modules can run into similar problems. Therefore moving to openide... fixed the rendering of international chars Checking in RendererFactory.java; /cvs/openide/explorer/src/org/openide/explorer/propertysheet/RendererFactory.java,v <-- RendererFactory.java new revision: 1.3; previous revision: 1.2 done pls note that there's still a problem with editing of such strings. no easy fix NetBeans.org Migration: changing resolution from LATER to WONTFIX |