This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 57779 - [41cat] International characters do not show up properly in Local Variables view
Summary: [41cat] International characters do not show up properly in Local Variables view
Status: RESOLVED WONTFIX
Alias: None
Product: platform
Classification: Unclassified
Component: Outline&TreeTable (show other bugs)
Version: 4.x
Hardware: All All
: P3 blocker (vote)
Assignee: Stanislav Aubrecht
URL:
Keywords: I18N
Depends on:
Blocks:
 
Reported: 2005-04-12 15:31 UTC by Miloslav Metelka
Modified: 2009-11-02 10:59 UTC (History)
7 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Miloslav Metelka 2005-04-12 15:31:52 UTC
This defect was entered as continuation of issue 57420 as there some problems
that persist on the debugger side. The copied report from #57420 follows:

I don't know which of the fixes have been applied
to the 4.1 branch, so in order to verify that all
the issues have been closed, I've downloaded the
4.2-dev build 200504111800

Result: better, but not quite there. Basically,
the first half of my bur report is fixed.

To sum up what does NOT work. Run my example,
with the breakpoint as I suggested.

Then, go to the Debbuger "Local Variables" view,
and be curious, and play a little during 30 seconds.

You will see that:

   a) If you move your mouse over the "Value" column, tooltips are wrong.
   b) If you click on any of the cell in the "Value" column, text is wrong.
   c) If you click on the [...] button on the right of the "Value" column,
      many things are wrong:
        c.1) while the ill-named "Value - Value" dialog is up, some of the
             cell values take the value "null"
        c.2) The value in the "Value - Value" dialog is of course wrong.
        c.3) If you press on the [...] button at the right of the "c1"
             column, there is a square in the dialog. If you put '\u001b'
             in the "Value - Value" dialog and press OK, then A RED SQARE
             APPEAR in the c1 value field (It should not be RED, since it's
             the same value (c.3.a) and it should not be a square, of course
             (c.3.b)
Comment 1 cberger 2005-04-12 15:53:30 UTC
thanks ;)
Comment 2 cberger 2005-04-12 16:00:56 UTC
BTW:

1) when I click on the [...] on the "Type" column,
   I see the exact same "null" problem that I see on
   the "Value" column.

2) Instead of the "Value - Value" and "Type - Type"
   dialog title, it would be IMHO much better to put
   the name of the variable, like "c2 - Value" and
   "c2 - Type" (on on the opposite order). I guess
   that was the intended behaviour, and that some 
   bugs are there.
Comment 3 Jan Jancura 2005-04-12 16:09:49 UTC
This code is in openide, as far as I know.
We are not renrerring properties in TreeTableView, nor tooltips.
Comment 4 cberger 2005-04-12 16:13:16 UTC
Oh, and while playing in there:

If I click on the [...] at the right of the "#52(length=0)"
value (for args variable), the "Value - Value" dialog is
editable, and when I close it by pressing "OK", I get that
ugly error:

 Lexical error at line 1, column 1. Encountered: "#" (35), after : ""

I guess that for value that are not editable, the dialog
should show up as "readonly", like for the "Type" column.

Sorry for adding one more item to that already loaded report...
This is less important than the editing features, but if it's
easy to fix...
Comment 5 cberger 2005-04-12 17:21:26 UTC
Why is the cat41 been removed?
Does this bug appear on NB-4.1 dashboard?
Comment 6 Jan Chalupa 2005-04-13 07:46:32 UTC
Stan, please look at it. Start with the test case provided in issue #57240. I
suspect there still may be more issues to solve in various places.
makeDisplayable() in TableSheetCell and RendererFactory is supposed to handle
some cases when a string with non-displayable characters is being displayed, but
it gets broken when the user tries to edit the cell content either in-place, or
via the [...] button.
Comment 7 Stanislav Aubrecht 2005-04-13 11:59:57 UTC
it's not a problem to fix the broken tooltips but i'm not sure about the editing
functionality.
it's possible to escape all strings before they are passed to editor and then
parse and un-escape them when editing stops. but then i can imagine windows
users complaining they can't edit file name values in debugger windows because
they're seeing something like this:
"C:\\Projects\\Netbeans\\openide\\scr\\somefile.java"

comments anyone?
Comment 8 cberger 2005-04-13 12:07:52 UTC
IMHO, that is not a big problem, ppl are used to the need of
double-slashes in Java.
BTW, a little detail, but why are the initial " and ' quote
characters not stripped when entering editing mode? that
would for sure be more user-friendly.
Comment 9 cberger 2005-04-13 12:10:23 UTC
I mean, initial and final quotes.
That would be cool if the field display "\n", but
when you edit it, it just shows \n, so editing is
simplified.
Comment 10 Jan Chalupa 2005-04-14 15:28:50 UTC
Just checked that displaying/editing of string with escaped characters didn't
work at all in NB 4.0. The current state is a big progress already. cberger,
thanks for pushing it.

One of the issues described here -- tooltips in the Value columns -- can be
fixed easily. The editing is more complex, it has to be fixed in multiple places
and will need to be thoroughly tested. There's no time left to make it for 4.1.

Tooltips will be fixed for 4.1. Editing will not. I'm downgrading this issue to P3.
Comment 11 Stanislav Aubrecht 2005-04-14 16:04:49 UTC
fixed the tooltip part:

Checking in org/openide/explorer/view/TableSheetCell.java;
/cvs/openide/src/org/openide/explorer/view/TableSheetCell.java,v  <-- 
TableSheetCell.java
new revision: 1.26; previous revision: 1.25
done
Comment 12 Jan Chalupa 2005-04-15 15:24:18 UTC
The editing part will be fixed for 4.2.
Comment 13 Zdenek Konecny 2005-08-05 16:28:47 UTC
I tested it in Build 200507041800 and I've got still problem with tooltips. If
you use the source which is in issue 57420, the variables c1='\33',
c6='\ue161'and s="\33\n\"'\\\ue161" have got tooltips with squeres. I'm using
JDK 1.6.0-ea. BTW variables s  and c1 have got bad value in value column.  
Comment 14 Zdenek Konecny 2005-08-05 17:21:10 UTC
Sorry, in build 200508041800
Comment 15 Stanislav Aubrecht 2005-11-04 13:48:13 UTC
evaluation:

1. as far as i can tell the tooltips now behave correctly (in editor pane as
well as in debugger views).

2. the incorrect rendering of string values in debugger views is now the problem
of the debugger module. the debugger supplies the values to be rendered as html
string (htmlDisplayValue property) to signal value changes in bold face etc. in
this case the  property sheet does *not* check the value for non-displayable
characters. imho, the debugger should check for non-displayble characters when
constructing its html strings.

3. the editing part seems to be the most complicated one. the debugger does not
support multi-line text values, however chars '\' and 'n' are interpreted as a
newline char ("\n"). on the other hand the same editor in e.g. form designer
accepts multi-line text and chars '\' and 'n' are interpreted as "\\n" (and show
as such in the designer window).
it's possible to escape the value before editing and replace all non-displayable
chars with their "\uxxxx" equivalents and then re-parse the value before it is
commited to the model. however i don't know how to implement consistent handling
of newline chars. (maybe a special string editor for debugger views?)

all comments are very welcome.
Comment 16 Stanislav Aubrecht 2005-11-09 14:34:49 UTC
reassigning to the debugger team to implement the conversion of non-displayable
characters to '\uxxxx' strings in htmlDisplayValue properties.

please reassign back to me if you think the conversion should be done in the
property sheet after the html code creation.
Comment 17 Martin Entlicher 2005-12-02 14:38:28 UTC
IMHO the code that displays the String should care about non-displayable
characters. Also it's good to have this in one place in openide, since other
modules can run into similar problems.
Therefore moving to openide...
Comment 18 Stanislav Aubrecht 2005-12-02 20:56:26 UTC
fixed the rendering of international chars

Checking in RendererFactory.java;
/cvs/openide/explorer/src/org/openide/explorer/propertysheet/RendererFactory.java,v
 <--  RendererFactory.java
new revision: 1.3; previous revision: 1.2
done

pls note that there's still a problem with editing of such strings.
Comment 19 Stanislav Aubrecht 2008-11-21 09:48:05 UTC
no easy fix
Comment 20 Quality Engineering 2009-11-02 10:59:15 UTC
NetBeans.org Migration: changing resolution from LATER to WONTFIX