This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 100478 - line selection highlighting is inconsistent
Summary: line selection highlighting is inconsistent
Status: VERIFIED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Painting & Printing (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: issues@editor
URL:
Keywords:
Depends on:
Blocks: 74730
  Show dependency tree
 
Reported: 2007-04-10 15:15 UTC by athompson
Modified: 2007-11-05 13:45 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
looks ugly (1.48 MB, application/octet-stream)
2007-04-10 15:17 UTC, athompson
Details

Note You need to log in before you can comment on or make changes to this bug.
Description athompson 2007-04-10 15:15:17 UTC
if you select a blank line in the editor, the line selection highlighting
extends all the way to the end of the window.  but if you select a line which
contains characters or whitespace, the line selection highlighting only extends
to the last character. this yields a 'ragged' and inconsistent look (see
attached picture).

things would look much prettier and more consistent if the selection
highlighting for every complete line extended to the end of the window.
Comment 1 athompson 2007-04-10 15:17:06 UTC
Created attachment 40684 [details]
looks ugly
Comment 2 Vitezslav Stejskal 2007-04-10 23:46:32 UTC
IIRC it used to work (in 5.5) the way that the selection of empty lines showed
as a half-character-wide stripe at the beginning of the line. We should probably
fix it to the original state.
Comment 3 athompson 2007-04-11 12:19:34 UTC
i like the look of having the line selection going to the end of the window
better; it's more uniform and i always thought that the old line selection
looked ragged, especially on JSP pages.  besides, extending to the end of the
window provides more information; it unambiguously tells you that the entire
line (including the carriage return) is selected.
Comment 4 Miloslav Metelka 2007-04-13 16:06:31 UTC
I like half-character newline marking more (could be done for each line not just
for the empty ones) because it shows the whitespace at the end of line. However
the other IDEs also select till the end of window so we should probably follow
or make an option.
Comment 5 Vitezslav Stejskal 2007-07-11 16:33:26 UTC
Fixed. Text selection is extends to the end of each line.

Checking in CaretBasedBlockHighlighting.java;
/cvs/editor/lib2/src/org/netbeans/modules/editor/lib2/highlighting/CaretBasedBlockHighlighting.java,v  <-- 
CaretBasedBlockHighlighting.java
new revision: 1.5; previous revision: 1.4
done
Comment 6 athompson 2007-07-13 04:58:25 UTC
yup