This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 100926 - Remove the empty gap from the Tools menu
Summary: Remove the empty gap from the Tools menu
Status: VERIFIED FIXED
Alias: None
Product: javame
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Adam Sotona
URL:
Keywords:
: 102502 (view as bug list)
Depends on:
Blocks: 104411
  Show dependency tree
 
Reported: 2007-04-13 10:15 UTC by jrojcek
Modified: 2007-10-05 10:50 UTC (History)
4 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description jrojcek 2007-04-13 10:15:27 UTC
There's a big empty gap on the left side of each item in the Tools menu. Remove the gap.

Please find which menu item is causing this issue and reassign to responsible engineer.

Should be fixed for 6.0 M10.
Comment 1 Antonin Nebuzelsky 2007-04-17 14:31:39 UTC
Reassigning to Marek for evaluation. Marku, have a look at this.
Comment 2 mslama 2007-04-18 15:24:15 UTC
What OS, JDK, L&F? I do not see gap on GTK L&F with JDK 7 b11 but it is present
with all updates of JDK 6 (6, 6u1, 6u2). I do not see it on Metal L&F. With JDK
6 and 7. Or do you use NB with addons ie. modified Tools menu? I use daily dev
build NetBeans IDE Dev (Build 200704171800).
Comment 3 jrojcek 2007-04-19 10:06:45 UTC
Yes, it's in the "big" IDE with all components planned for 6.0 installed. Try downloading and installing the 
following build (look for "all-in-one" archive):
http://bits.nbextras.org/netbeans/6.0/nightly/latest/
Comment 4 mslama 2007-04-19 13:16:21 UTC
There are menu items "Component Libraries" and "Shared Component Libraries" from
visualweb. They should not add empty icon to menu. As they are subclasses of
CallableSystemAction you should call putValue("noIconInMenu", Boolean.TRUE); in
action constructor. Hopefully I did not miss any other 'bad' action in Tools
menu. If there will be still gap in Tools menu after you fix it feel free
reassing it back so I can dispatch issue....

BTW Jano the same problem is in Help menu of this NB version. Will you file
separate issue?
Comment 5 _ edwingo 2007-04-20 02:59:01 UTC
It seems to me that a more reasonable behavior is to not reserve space for an
icon unless an action specifies one, rather than for clients of the API to have
to actively state "do not reserve a space for an icon". So I think the fix
should go into CallableSystemAction.
Comment 6 David Simonek 2007-04-20 08:42:43 UTC
edwingo, I have to reopen, because this issue is simply not fixed. It seems that
you are not satisfied with offered solution, that's OK. But for M9 (J1), we have
no other choice. Please fix the issue as mslama described and enter new
enhancement to better support actions without icon. It's unfortunately
complicated to change things in CallableSystemAction, will require some time,
change of API semantics and so on.

Thanks for understanding. 
Comment 7 _ edwingo 2007-04-20 17:51:31 UTC
I did check in a tested fix into the trunk yesterday and then marked the bug as
FIXED. Are you saying that you do not see this as FIXED? Maybe you need to cvs
update the "visualweb/complib" module and build it. The comments I added on
"------- Additional comments from edwingo Fri Apr 20 01:59:01 +0000 2007
-------" are unrelated to the bug being fixed. It is just an added comment.
Comment 8 David Simonek 2007-04-20 19:04:57 UTC
I see, sorry. I didn't realize you actually fixed it. Sorry again and thanks.
Comment 9 mslama 2007-04-23 12:00:37 UTC
Note: We usually add comment in description together with CVS log. It can help
later when someone else wants to track bugfix esp. when more files are changed.
See for example issue #100996. It means slightly more work for solver but it
greatly helps other people so it is worth of invested effort.
Comment 10 jrojcek 2007-04-25 15:45:33 UTC
The empty gap is in the Tools menu again. Try this build:
http://bits.nbextras.org/netbeans/6.0/nightly/200704250000/

It looks like it's caused by mobility.
Comment 11 Adam Sotona 2007-04-25 16:17:14 UTC
I've just removed it from Mobility Deployment Manager action.
Comment 12 Marian Mirilovic 2007-04-25 16:33:45 UTC
*** Issue 102502 has been marked as a duplicate of this issue. ***
Comment 13 Lukas Hasik 2007-10-05 10:50:56 UTC
v