This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 106771 - ACTIONS: Externally added icon brokes Action Editor
Summary: ACTIONS: Externally added icon brokes Action Editor
Status: VERIFIED FIXED
Alias: None
Product: guibuilder
Classification: Unclassified
Component: App Framework (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Joshua Marinacci
URL:
Keywords:
Depends on:
Blocks: 93325
  Show dependency tree
 
Reported: 2007-06-15 10:23 UTC by Jana Maleckova
Modified: 2007-09-13 09:04 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
106771 (8.28 KB, text/plain)
2007-06-15 10:24 UTC, Jana Maleckova
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jana Maleckova 2007-06-15 10:23:52 UTC
Product Version: NetBeans IDE Dev (Build 200706141800) Java: 1.6.0; Java HotSpot(TM) Client VM 1.6.0-b105 System:
Windows XP version 5.1 running on x86; Cp1252; en_GB (nb) Userdir: D:\userdir60

Description:
============
have some action in JDA project. 
Set e.g. large icon to this action but it's location is not in classpath and save it
Then do edit of this action and try to edit this icon as well. When button "set icon" is pushed, an NPE occurs
Action editor is broken and is not possible to manipulate with action's icon then.

StackTrace:
===========
java.lang.NullPointerException
	at
org.netbeans.modules.form.editors.CustomIconEditor$IconComboRenderer.getListCellRendererComponent(CustomIconEditor.java:476)
	at javax.swing.plaf.basic.BasicComboBoxUI.paintCurrentValue(BasicComboBoxUI.java:1164)
	at com.sun.java.swing.plaf.windows.WindowsComboBoxUI.paintCurrentValue(WindowsComboBoxUI.java:292)
	at javax.swing.plaf.basic.BasicComboBoxUI.paint(BasicComboBoxUI.java:860)
Comment 1 Jana Maleckova 2007-06-15 10:24:49 UTC
Created attachment 43770 [details]
106771
Comment 2 Tomas Pavek 2007-06-22 17:30:24 UTC
External icons can't be used in actions. This option just needs to be disabled somehow.
Comment 3 Joshua Marinacci 2007-08-22 22:47:59 UTC
I believe this is fixed now. When the user selects an external icon it will now be imported into the project.
Comment 4 Jana Maleckova 2007-08-28 10:32:07 UTC
selected external icons are not automatically imported into project and then project can't be run.
key (test.Action.icon) in bundle has set icon's absolute path. When icon is imported into the project, I understand that
icon is on classpath then. Is it correct?
Comment 5 Tomas Pavek 2007-08-28 17:14:35 UTC
Yes, external icon is not imported automatically.
Comment 6 Joshua Marinacci 2007-09-12 00:06:11 UTC
This is fixed now.

External icons are not imported automatically when you select an external icon. Instead you must click on the 'import icon' button.  It shouldn't be possible to 
select icons that aren't within the project. We should fix the icon editor to either auto-import external icons, or else to only allow the 'import button' to be 
pressed. Since changing the icon editor significantly is difficult at this point in the development process I have added a boolean property on the IconEditor to 
disable external icons. Now the '...' button for external icons will be disabled so the user can only use the 'import icon' button.
Comment 7 Jana Maleckova 2007-09-13 09:04:32 UTC
now the possibility to set external icon is disabled in action editor

verified on

Product Version: NetBeans IDE Dev (Build 070913) Java: 1.6.0_02; Java HotSpot(TM) Client VM 1.6.0_02-b05 System: Windows
XP version 5.1 running on x86; Cp1252; en_GB (nb)