This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 112280 - Mistakes in ModuleInstall classes
Summary: Mistakes in ModuleInstall classes
Status: VERIFIED FIXED
Alias: None
Product: cnd
Classification: Unclassified
Component: -- Other -- (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Vladimir Kvashin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-08 10:33 UTC by _ rkubacki
Modified: 2007-08-13 13:06 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description _ rkubacki 2007-08-08 10:33:03 UTC
While investigating our startup sequence I see various wrong pattern in ModuleInstall classes in CND cluster
(cnd/highlight, cnd/modelimpl)

Overriding method to call only their super implementation is not a good idea (waste of time and memory). If not needed
validate() should not be overriden at all (causes earlier loading of class and any code called here needs to be very
careful because only small portion of system is setup). Wrapping call to super with tracing is not good either - you can
get similar info by turning on logging in {openide|core}/modules

cnd/highlight module install searches for open projects and then in fact does nothing with them. Whole this part should
be avoided.
Comment 1 Vladimir Kvashin 2007-08-13 11:35:10 UTC
Fixed.

Checking in highlight/src/org/netbeans/modules/cnd/highlight/HighlightProvider.java;
/shared/data/ccvs/repository/cnd/highlight/src/org/netbeans/modules/cnd/highlight/HighlightProvider.java,v  <-- 
HighlightProvider.java
new revision: 1.10; previous revision: 1.9
done
Checking in highlight/src/org/netbeans/modules/cnd/highlight/HighlightInstaller.java;
/shared/data/ccvs/repository/cnd/highlight/src/org/netbeans/modules/cnd/highlight/HighlightInstaller.java,v  <-- 
HighlightInstaller.java
new revision: 1.4; previous revision: 1.3
done
Checking in modelimpl/src/org/netbeans/modules/cnd/modelimpl/Installer.java;
/shared/data/ccvs/repository/cnd/modelimpl/src/org/netbeans/modules/cnd/modelimpl/Installer.java,v  <--  Installer.java
new revision: 1.8; previous revision: 1.7
done
Comment 2 _ rkubacki 2007-08-13 13:06:02 UTC
thanks