This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 122407 - Unwanted hgk repeatedly added to ~/.hgrc
Summary: Unwanted hgk repeatedly added to ~/.hgrc
Status: RESOLVED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Mercurial (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: issues@versioncontrol
URL:
Keywords:
Depends on:
Blocks: 119250
  Show dependency tree
 
Reported: 2007-11-20 15:38 UTC by Jesse Glick
Modified: 2008-01-03 09:40 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Proposed patch (13.01 KB, text/plain)
2007-11-21 16:52 UTC, John Rice
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse Glick 2007-11-20 15:38:31 UTC
I have been annoyed recently by the fact that

hgext.hgk = 

keeps appearing in my ~/.hgrc for no apparent reason. I notice because every single hg command (using 0.9.5 with some
other extensions installed) after that displays

extension 'hgext/hgk' overrides commands: debug-config debug-cat-file debug-diff-tree debug-rev-parse ^view
debug-rev-list debug-merge-base

which among other things messed up display in the Emacs mode line for Hg-controlled files.

A Google search tracked it down to issue #119250 - apparently NetBeans is adding it! This is bad. You may only add hgk
to my ~/.hgrc if

1. You have asked me, in a dialog box, and I have said yes.

2. The IDE actually needed it, because I actually invoked the View action. (Which I never have.)

3. I have hgk installed so it could work. (Which I don't.)
Comment 1 John Rice 2007-11-21 16:52:15 UTC
Created attachment 53318 [details]
Proposed patch
Comment 2 John Rice 2007-11-21 16:59:20 UTC
Attached patch will not add hgext.hgk to ~/.hgrc automatically.

When you click on Mercurial >View:

1. If hgk is not on your PATH, notifies you and returns
2. If hgk is on your PATH, but hgext.hgk is not in your ~/.hgrc prompts you, to add it if you want:
Yes - gets added and hgk is run
No - not added and you return

To get hgk to work on Windows, you need to install the "unofficial batteries included" release:
http://qct.sourceforge.net/Mercurial-BI.html

and add <MercurialInstallDir>\scripts to your PATH [Control Panel> System> Advanced> Environment Variables: System
Variables - select Path and choose Edit

This patch has not been tested on the Mac yet.
Comment 3 John Rice 2007-11-22 15:54:43 UTC
hgk - is not part of the mac release of mercurial. On the mac you will be told that hgk is not installed or not in your
PATH and to install it.
If someone does get hgk working on the mac then just putting it on your PATH will enable it to work on the mac.

Committed to Head.
Comment 4 Jesse Glick 2007-11-30 20:53:22 UTC
Thanks. Did you increment the module's spec version so as to push the change?

BTW it is customary to paste the CVS commit log (or equivalent info) into the comment when closing a bug as FIXED. Also
to set the target milestone.
Comment 5 John Rice 2007-12-03 11:42:14 UTC
"Did you increment the module's spec version so as to push the change?"
Nope - you can pick it up from the nightlies, we only increment the version when we are doing a new release. This is the
way QE have been testing hte fixes for us.

"BTW it is customary to paste the CVS commit log (or equivalent info) into the comment when closing a bug as FIXED. Also
to set the target milestone."
Will do - and now setting milestone as 6.1M1