This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 133130 - [nimbus] colors and some graphics in profiler windows are not according to nimbus L&F
Summary: [nimbus] colors and some graphics in profiler windows are not according to ni...
Status: VERIFIED FIXED
Alias: None
Product: profiler
Classification: Unclassified
Component: Base (show other bugs)
Version: 6.x
Hardware: All Solaris
: P3 blocker (vote)
Assignee: issues@profiler
URL: http://ui.netbeans.org/docs/ui/nimbus...
Keywords: L&F
Depends on:
Blocks: 132737
  Show dependency tree
 
Reported: 2008-04-17 16:17 UTC by Ondrej Langr
Modified: 2009-01-14 17:04 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ondrej Langr 2008-04-17 16:17:35 UTC
Colors used in profiler and attach profiler dialogs do not follow Nimbus L&F. Also, some graphics, such as the
background clock as well as overhead meter are not nimbus compliant.
Comment 1 Jiri Sedlacek 2008-06-16 15:54:35 UTC
As already mentioned in umbrella Issue 132737, the dialog is correctly implemented according to an UI specification. The
colors, images and components are defined especially for the dialog and currently don't change for any particular LaF.

Marking as INCOMPLETE, please update the UI spec with the requested changes first.
Comment 2 Ondrej Langr 2008-06-16 17:42:54 UTC
> The colors, images and components are defined especially 
> for the dialog and currently don't change for any particular LaF.

Well .. since look&feel is defined mainly by colors, imagery and shapes of components, this means that this dialog has
it's own L&F independent of the active L&F running on NetBeans. Having two look&feels active at the same time in the
same product seems to be wrong and denies the purpose of L&Fs which is to provide unified user experience across the
product. 

I can't update the spec. details you've asked for as I neither know who the author is nor I can find the spec. Please
provide the link. 
Comment 3 Ondrej Langr 2008-07-02 19:16:52 UTC
> Marking as INCOMPLETE, please update the UI spec with the requested changes first.

Having seen the UI specification, I am removing the INCOMPLETE keyword. UI specifications generally (although graphics
are usually done for a single selected L&F) do not define appearance for all L&Fs, neither does this one.

Requested changes are the ones reported in this issue (in descending order of importance) : 

1) background colors and button color are hard-coded and do not follow Nimbus (standard colors fetched from
color-schemes should be used)
2) use of background graphics is not nimbus compliant (probably not other L&F compliant either, but this issue focuses
on nimbus as it has been filed as part of nimbus UI review linked from the URL field).
3) "Overhead" meter is non-standard component, which does not reflect active L&F
4) Use of the "attach" graphics on the button is non-standard and not nimbus-compliant
Comment 4 Jiri Sedlacek 2008-08-27 15:38:48 UTC
Partially fixed: Removed button icons, used progressbar for overhead. Waiting for colors & background definition from
olangr.


changeset:   98136:526524c2d82c
date:        Wed Aug 27 16:35:49 2008 +0200
summary:     Partial bugfix #133130 Removed button icons, used progressbar for overhead
Comment 5 Ondrej Langr 2008-08-28 13:25:16 UTC
The suggested color (on nimbus) for background of the panel is standard grey used for toolbars and many other panels
accross the IDE. 

Color for highlighting of pseudo-buttons: #B6CBDE. 
Background of pseudo-buttons: no change.

Please let me know if I missed something and anything else is needed.
Comment 6 Jiri Sedlacek 2008-08-29 16:55:02 UTC
Fixed dialog background & pseudo-buttons border according to provided data.

Fixed for 6.5.


changeset:   98739:39a75d1be0ef
date:        Fri Aug 29 17:52:40 2008 +0200
summary:     Remaining part of bugfix #133130: changed SPT background & TaskChooser border
Comment 7 Quality Engineering 2008-09-01 17:30:44 UTC
Integrated into 'main-golden', available in build *200809011401* on http://bits.netbeans.org/dev/nightly/
Changeset: http://hg.netbeans.org/main/rev/526524c2d82c
User: Jiri Sedlacek <jis@netbeans.org>
Log: Partial bugfix #133130 Removed button icons, used progressbar for overhead
Comment 8 Rashid Urusov 2009-01-14 17:04:05 UTC
VERIFIED in Build 200901140201