This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 138230 - Wrong label in the installer in bundle running on JRE
Summary: Wrong label in the installer in bundle running on JRE
Status: RESOLVED FIXED
Alias: None
Product: installer
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: dlipin
URL: http://ui.netbeans.org/docs/ui/IDE_on...
Keywords:
Depends on:
Blocks:
 
Reported: 2008-06-25 14:39 UTC by Ondrej Langr
Modified: 2008-09-03 17:23 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
netbeans configuration panel (26.99 KB, image/png)
2008-08-29 11:01 UTC, dlipin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ondrej Langr 2008-06-25 14:39:30 UTC
When only components running on JRE are selected in the installer, the label on the panel where NetBeans folder is
customized still displays "JDK for the NetBeans IDE" despite that JRE is also sufficient here (tested with Base IDE +
PHP selected in the full installer).

If only components running on JRE are selected, we do not need to display the field at all and can just use
auto-detected JRE as we do with the installer. While choosing a version of JDK makes sense, there is little or no need
to be willing to use particular version of JRE (especially considering that users who do not install Java development
tools inside NetBeans IDE are likely not to be very familiar with Java versions, etc..).
Comment 1 dlipin 2008-07-29 12:15:42 UTC
Ondrej,

what label should be used in that case? It can`t be "JRE for the NetBeans IDE" since JDK can also be set there, right?
How about "Java environment for..." ?

Even though in most cases it would be hidden, there are some rare cases when the label and field would be shown e.g. 
when the JRE that installer run on does not fit the NetBeans IDE requirements. In that case we need to show the field 
so that the user can select the JRE/JDK by hand.

Dmitry
Comment 2 Ondrej Langr 2008-07-30 09:50:53 UTC
In the specific case you're describing, I suggest to "Java Environment for the NetBeans IDE". In cases when JDK is
required, it should still say "JDK for the NetBeans IDE".

But given this would be displayed if the auto-detected JRE "does not fit the NetBeans IDE requirements", we need to have
an error message to display if the same JRE (the same as is used for the installer) is chosen manually.
Comment 3 dlipin 2008-08-29 11:00:43 UTC
In fact, there are several labels on that panel that refers to JDK:
at the top: Choose the installation folder and JDK(tm) for the NetBeans IDE
in the middle: JDK(tm) for the NetBeans IDE
at the bottom, a number of various error messages.

Should they all be fixed?

Having "Choose the installation folder and Java(tm) environment for the NetBeans IDE" will likely make this string 
wrapped on some "wide" look-and-feels.
Comment 4 dlipin 2008-08-29 11:01:22 UTC
Created attachment 68610 [details]
netbeans configuration panel
Comment 5 Ondrej Langr 2008-09-01 14:51:41 UTC
Thanks for catching the other strings, Dmitry!

Yes, they should all be fixed to reflect what really is needed, to avoid confusing the user with inconsistent
terminology. As for the wrapping the text, I believe we can just skip the "for NetBeans IDE" part in the title as it is
obvious from given context and it is already present several times on the panel. 

So, the strings would be: 

at the top: Choose the installation folder and Java Environment.
in the middle: Java environment for the NetBeans IDE
at the bottom, all references to JDK should be replaced by references to Java environment whenever JRE is sufficient. I
believe wrapping should not be a problem here as error messages generally can wrap, right?
Comment 6 dlipin 2008-09-01 17:24:43 UTC
>I believe wrapping should not be a problem here as error messages generally can wrap, right?

Right.

Thanks, Ondrej, I`ll try to do my best to fix the issue in time.
Comment 7 dlipin 2008-09-02 15:34:48 UTC
The first part (top and middle labels) is fixed, the fix for error messages needs some more resources...
Comment 8 dlipin 2008-09-02 16:43:16 UTC
Should be completely fixed now, please verify on the next daily build.
Comment 9 Quality Engineering 2008-09-03 17:23:36 UTC
Integrated into 'main-golden', will be available in build *200809031401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/a2af1ce16530
User: Dmitry Lipin <dlipin@netbeans.org>
Log: Issue #138230 Wrong label in the installer in bundle running on JRE (part 1)