This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 141508 - LifecycleListener class (appbase.jar) incorrectly removes all request attributes
Summary: LifecycleListener class (appbase.jar) incorrectly removes all request attributes
Status: RESOLVED FIXED
Alias: None
Product: obsolete
Classification: Unclassified
Component: visualweb (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Matthew Bohm
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-07-24 11:07 UTC by steveshaw2000
Modified: 2008-08-02 15:56 UTC (History)
0 users

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description steveshaw2000 2008-07-24 11:07:15 UTC
The com.sun.rave.web.ui.appbase.servlet.LifecycleListener class packaged in the appbase.jar of the JSF 1.1/1.2 Support 
library has the method 'requestDestroyed()' that should (according to the javadoc) only remove servlet request 
attributes that implement AbstractRequestBean or AbstractFragmentBean.  In fact, it removes *all* request attributes.
This breaks the web application error page functionality as Catalina looks for a specifiec request attribute containing 
the exception thrown.
Comment 1 Matthew Bohm 2008-07-25 00:18:17 UTC
Glancing at the source, this looks like an antipattern throughout several methods of
com.sun.rave.web.ui.appbase.servlet.LifecycleListener, namely, contextDestroyed(ServletContextEvent),
sessionDestroyed(HttpSessionEvent), and requestDestroyed(ServletRequestEvent).
Comment 2 Matthew Bohm 2008-08-02 10:33:31 UTC
Fixed.

changeset:   93662:e515ea1f4fc1
user:        mbohm@netbeans.org
date:        Sat Aug 02 01:00:54 2008 -0700
summary:     #141508 LifecycleListener class (appbase.jar) incorrectly removes a
l
Comment 3 Quality Engineering 2008-08-02 15:56:37 UTC
Integrated into 'main-golden', available in build *200808021401* on http://bits.netbeans.org/dev/nightly/
Changeset: http://hg.netbeans.org/main/rev/e515ea1f4fc1
User: mbohm@netbeans.org
Log: #141508 LifecycleListener class (appbase.jar) incorrectly removes al