This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 145546 - weak performance when navigating through nodes of (large) web project
Summary: weak performance when navigating through nodes of (large) web project
Status: VERIFIED FIXED
Alias: None
Product: javaee
Classification: Unclassified
Component: Web Project (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: David Konecny
URL:
Keywords: PERFORMANCE
: 145464 (view as bug list)
Depends on:
Blocks: 145464
  Show dependency tree
 
Reported: 2008-08-29 10:37 UTC by Tomas Danek
Modified: 2008-10-07 17:30 UTC (History)
6 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
td1 (20.65 KB, text/plain)
2008-08-29 16:21 UTC, Tomas Danek
Details
td2 (24.05 KB, text/plain)
2008-08-29 16:23 UTC, Tomas Danek
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tomas Danek 2008-08-29 10:37:44 UTC
Product Version: NetBeans IDE Dev (Build 20080828105910)
Java: 1.6.0_10-beta; Java HotSpot(TM) Client VM 11.0-b11
System: Linux version 2.6.24-19-generic running on i386; UTF-8; en_US (nb)
Userdir: /usr/local/home/tomas/.netbeans/dev
-------------------------------
- have a large web project (depending on ~50 j2se projects or JARs, web pages contain ~1000 items, sources not so large)
- have it opened in IDE (j2se + web) with its depending j2se projects
- expand web project node, try to navigate through its subnodes
- CPU runs 100%, and you will notice lags when navigating through nodes, especially when compared with (also large) j2se
project. 
(e.g. try to press down arrow three times - in j2se project focus moves down the nodes instantly, in webproject there's
a delay after which focus moves directly from first to fourth node)
Comment 1 Petr Jiricka 2008-08-29 14:20:02 UTC
Could this be related to issue 145464?
Comment 2 Tomas Danek 2008-08-29 14:28:25 UTC
not sure, right click on project node is almost instant (by this i mean taking cca ~1-2 sec :-)), i did not spot any
long-time freeze.
Comment 3 Petr Jiricka 2008-08-29 14:39:47 UTC
I see. BTW, do you know if this is a recent regression, or a longer term problem? Adding also Tomas M to cc.
Comment 4 Tomas Mysik 2008-08-29 14:48:01 UTC
Would it be possible to attach several thread dumps? Thanks.
Comment 5 Tomas Danek 2008-08-29 14:57:25 UTC
pjiricka: No idea, never worked with web projects before:)
tmysik: can give it a try, but I am not sure if i have fast enough fingers to switch into console and generate TD during
moving through nodes.
Comment 6 Tomas Danek 2008-08-29 15:45:12 UTC
well, i moved the project to a NTFS filesystem and opened in IDE under WinXP -> performance got significantly even
worse, jumping over the nodes produces even ~2sec delay. In this environment is delay noticeable also for big J2se
projects. 
Comment 7 Tomas Danek 2008-08-29 16:20:50 UTC
attaching captured thread dumps:
td1 - captured during invoking popup on project node (takes ~5sec, on java app is popup instant)
td2 - captured during jumping on webproject nodes (subnodes of project)
Comment 8 Tomas Danek 2008-08-29 16:21:49 UTC
Created attachment 68639 [details]
td1
Comment 9 Tomas Danek 2008-08-29 16:23:31 UTC
Created attachment 68641 [details]
td2
Comment 10 David Konecny 2008-08-31 22:02:48 UTC
Would it be possible to upload ZIPped test projects somewhere so that I can play with this?

Looking at thread dumps I can see one thing to fix which should improve performance: PetrH, in
http://hg.netbeans.org/main/rev/760ed5f34f01 in WebActionProvider.isActionEnabled you introduced call to
project.getWebProjectProperties(). It is quite unobvious but WebProjectProperties class should be used only by project
customizer. Creation of WebProjectProperties is never cached and its constructor is quite expensive (dozens of
customizer fields are initialized; see also issue 145464). WebActionProvider should use directly AntProjectHelper. I
will fix that and also other calls to WebProjectProperties.
Comment 11 David Konecny 2008-09-01 00:36:37 UTC
I do not have test data to prove that this has been fixed but very likely it was. Please reopen if still slow. Locally
fixed as #0d27e2dd0c64. Will be pushed to main later today.
Comment 12 David Konecny 2008-09-01 10:09:38 UTC
*** Issue 145464 has been marked as a duplicate of this issue. ***
Comment 13 Tomas Danek 2008-09-01 13:02:17 UTC
tried this in recent trunk, and *subjectively* feels much better. Will try also on XP, where performance was really
weak. And if also performance team does not plan to do any measuring, i'm for to marked as verified.
Comment 14 Tomas Danek 2008-09-01 13:27:49 UTC
..on Win XP also fine, so if there are no objections from perf team, i will mark verified. 
Comment 15 Quality Engineering 2008-09-01 17:31:09 UTC
Integrated into 'main-golden', available in build *200809011401* on http://bits.netbeans.org/dev/nightly/
Changeset: http://hg.netbeans.org/main/rev/0d27e2dd0c64
User: David Konecny <dkonecny@netbeans.org>
Log: #145546 - weak performance when navigating through nodes of (large) web project.
Removed all calls to WebProjectProperties and made it package private.
Comment 16 Quality Engineering 2008-09-05 06:15:11 UTC
Integrated into 'main-golden', will be available in build *200809050201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/c06c074cea52
User: David Konecny <dkonecny@netbeans.org>
Log: #145546 - make sure other project type do not have similar problem (in future)
Comment 17 Tomas Danek 2008-10-07 17:30:42 UTC
thanks,navigation between nodes in web project is not problem any more, verified in 20081007