This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 148041 - Built-in JavaFXSDK should have executable flag on jmcDaemonServer script on Mac
Summary: Built-in JavaFXSDK should have executable flag on jmcDaemonServer script on Mac
Status: VERIFIED FIXED
Alias: None
Product: javafx
Classification: Unclassified
Component: Unsupported (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: Andrey Yamkovoy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2008-09-23 14:06 UTC by David Kaspar
Modified: 2008-10-28 10:30 UTC (History)
3 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Kaspar 2008-09-23 14:06:36 UTC
Built-in JavaFXSDK should have executable flag on lib/desktop/jmcDaemonServer script on Mac.
Comment 1 Adam Sotona 2008-09-24 12:45:30 UTC
Setting of executable flags should responsibility of installer and autoupdate.

Assigning to autoupdate and ccing installer.
Comment 2 dlipin 2008-09-24 12:59:18 UTC
Andrey, please make sure that permissions are not lost when you create javafx cluster zip files (for all platforms).
It applies to both javafx modules and javafx-sdk.

The first thing that should be done is to check that the javafx-sdk zip file (I am speaking about javafx_sdk-1_0-dev-
macosx-universal.zip and such) has correct permissions as well.
NetBeans/JavaFX installer does not change any permissions - it uses the ones from the provided data.
Comment 3 Jiri Rechtacek 2008-09-24 13:03:01 UTC
No. Autoupdate didn't have such capability. You have to solve itself, use openide/modules/ModuleInstall.restored() or
post-install hook for that.
Comment 4 dlipin 2008-09-29 16:00:20 UTC
[speaking about installer]
Andrey,

If it works for you, you can zip only NetBeans part in the cluster zip files.
In other words, do not include the SDK in the per-platform cluster zip files but just put it at the same level:
zips/javafx-cluster-mac.zip (without FX SDK)
zips/javafx-cluster-win.zip (without FX SDK)
zips/javafx-cluster-lin.zip (without FX SDK)
zips/javafx-cluster-sol.zip (without FX SDK)
zips/javafx-sdk-mac.zip
zips/javafx-sdk-win.zip
zips/javafx-sdk-lin.zip
zips/javafx-sdk-sol.zip

If possible, use fx sdk names without any build info - it will save a lot of time and support efforts...

In other words, for windows part:
<zip destfile="zips/javafx-cluster-win.zip" update="false" duplicate="preserve">
          <zipfileset prefix="${nb.cluster.javafx.dir}" dir="${netbeans.dest.dir}/${nb.cluster.javafx.dir}">
		<exclude name="${javafx.sdk.pattern}"/>
		<exclude name="**/*-lin.*"/>
		<exclude name="**/*-sol.*"/>
		<exclude name="**/*-mac.*"/>
          </zipfileset>
</zip>
<copy file="javafx.sdk.win/${javafx-sdk.win.zip}" tofile="zips/javafx-sdk-win.zip"/>

The similar for mac, lin and sol.

CC-ing Ivan - it can also affect tests.
Comment 5 Andrey Yamkovoy 2008-10-07 11:36:56 UTC
I have changed the build script. Now cluster zips not contain SDK inside. SDK zips putting at the same level as cluster
zips.
Comment 6 dlipin 2008-10-07 22:24:29 UTC
Andrey, thanks!
I`ve adjusted the installer so that it get permissions info from javafx sdk zip file.

David, please try the latest JavaFX_NB_Plugin_NB65_installer build and check whether the permissions are correct.

Regarding permissions of the SDK files in case FX is installed from UC... Like Jirka said, it is the responsibility of 
the plugin owner.
If you have any troubles with that - feel free to check e.g. Cnd and Ruby modules installation.
http://hg.netbeans.org/main/file/tip/cnd/src/org/netbeans/modules/cnd/CndModule.java
and
http://hg.netbeans.org/main/file/tip/ruby.project/src/org/netbeans/modules/ruby/rubyproject/
RubyProjectModuleInstaller.java
http://hg.netbeans.org/main/file/tip/ruby.platform/src/org/netbeans/api/ruby/platform/RubyInstallation.java

Thanks,
Dmitry
Comment 7 David Kaspar 2008-10-21 10:39:03 UTC
I have looked at the latest installers of NetBeans 6.5 with JavaFX plugin/SDK and the file permissions look ok.
Therefore resolving as Fixed.
Comment 8 dlipin 2008-10-21 10:55:34 UTC
I guess it still does not work for the FX plugin if it is installed in the IDE using Plugin Manager.
Comment 9 Andrey Yamkovoy 2008-10-21 11:18:16 UTC
It should be fine if installed from UC.
I have pushed the following fix 30 min ago:
http://hg.netbeans.org/javafx?cmd=changeset;node=705ce7dc5d4e
Comment 10 Alexandr Scherbatiy 2008-10-28 10:30:15 UTC
verified in 2008-10-28_03-01-09.zip