This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
May also affect ability of modules (e.g. apisupport) to provide custom icons for *.jarContent's serving as templates: SystemFileSystem.icon seems to be ignored. See patch, the added code is customary.
Created attachment 2500 [details] Suggested patch
Is there a convention for whose badges go where? Otherwise, one badge is likely to overwrite another.
Supplied patch applied. Note that a more sensible way of doing this is: DataNode.java: public java.awt.Image getBaseIcon() { return super.getIcon(); } public final java.awt.Image getIcon (int type) { img = getBaseIcon(type); try { img = obj.getPrimaryFile ().getFileSystem ().getStatus ().annotateIcon (img, type, obj.files ()); } catch (FileStateInvalidException e) { // no fs, do nothing } return img; } This gives descendents of DataNode the proper behavior, while eliminating the need to copy code from superclass to all subclasses. With the current design, what happens if the code in DataNode.getIcon() needs to change, when there are so many copies of it?
The UI site somewhere has a complete badging proposal that specifies which kinds of badges are permitted to go into each sextant of the 24x16 icon. Yes the situation with DataNode and its icon is clumsy at times; your idea may be workable if it can be done compatibly. Bring it up on dev@openide.