This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 155946 - ModInstall needs to be fixed
Summary: ModInstall needs to be fixed
Status: RESOLVED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Maven (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords: PERFORMANCE
: 181426 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-12-22 15:56 UTC by Alexander Kouznetsov
Modified: 2012-03-27 19:29 UTC (History)
2 users (show)

See Also:
Issue Type: DEFECT
Exception Reporter:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Kouznetsov 2008-12-22 15:56:48 UTC 
org.netbeans.modules.maven.ModInstall class needs to be fixed according to the following AIs (originally by jtulach):

# org.netbeans.modules.maven.ModInstall$OpenProjectsListener - why can't this be replaced with OpenProjectHook??
# eliminate: prfs.put("touch", "me");
# eliminate: disableOldModules, not useful anymore when maven is part of the product
Comment 1 Milos Kleint 2008-12-22 16:15:41 UTC 
what is an AI? and why doesn't jtulach file it himself then if he has a problem with it?

the first item is the only one relevant probably. The other two are being depended on by an already released codebase.
Comment 2 Antonin Nebuzelsky 2010-07-30 15:17:09 UTC 
Reassigning to default owner.
Comment 3 Jesse Glick 2010-11-18 00:17:36 UTC 
core-main #1cae752ae9e0
Comment 4 Quality Engineering 2010-11-19 06:12:49 UTC 
Integrated into 'main-golden', will be available in build *201011190001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/1cae752ae9e0
User: Jesse Glick <jglick@netbeans.org>
Log: #155946: ModInstall needs to be fixed
Comment 5 Jaroslav Tulach 2010-11-19 08:29:19 UTC 
Good, open hook is definitely better place for doing initialization. 

You can verify your fix by adding some Maven classes on blacklist as described at http://wiki.netbeans.org/FitnessViaWhiteAndBlackList
Comment 6 Jesse Glick 2010-11-19 14:41:50 UTC 
Will try.

BTW the whitelist/blacklist test setup is cumbersome to maintain and violates DRY. Simpler would be to just collect a list of loaded classes and file touches etc. from each daily build, or more or less frequently, in some Hudson job and mail diffs (correlated with changelog) to performance team for review. This would immediately point out regressions which are candidates for fixing, and also provide confirmation of fixes; while uninteresting or unfixable changes (e.g. from JDK version updates, or old code factored out into its own class) can be simply accepted without needing to make changes in the source base.
Comment 7 Quality Engineering 2010-11-20 06:12:36 UTC 
Integrated into 'main-golden', will be available in build *201011200001* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main/rev/d4ccfc29051a
User: Jesse Glick <jglick@netbeans.org>
Log: Whitelist updates after #155946: no more ModuleInstall in maven.
(maven.indexer necessarily keeps a ModuleInstall to implement close(),
and there are some global queries which cannot be associated with a project.)
Comment 8 Jesse Glick 2012-03-27 19:29:04 UTC 
*** Bug 181426 has been marked as a duplicate of this bug. ***