This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 158093 - Keymap panel enhancements
Summary: Keymap panel enhancements
Status: RESOLVED FIXED
Alias: None
Product: editor
Classification: Unclassified
Component: Key bindings (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Svata Dedic
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-02-06 16:41 UTC by Petr Dvorak
Modified: 2012-05-25 05:43 UTC (History)
1 user (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments
Patch (9.71 KB, text/plain)
2009-02-06 16:41 UTC, Petr Dvorak
Details
Icon - SW keyboard hidden (319 bytes, image/png)
2009-02-06 16:43 UTC, Petr Dvorak
Details
Icon - SW keyboard shown (317 bytes, image/png)
2009-02-06 16:44 UTC, Petr Dvorak
Details
[1] No border is drawn around the SW keyboard (70.88 KB, image/png)
2009-02-06 16:50 UTC, Petr Dvorak
Details
[2] Nimbus before (7.04 KB, image/png)
2009-02-06 16:53 UTC, Petr Dvorak
Details
[2] Nimbus after (m aybe a color change is appropriate?) (6.39 KB, image/png)
2009-02-06 16:53 UTC, Petr Dvorak
Details
[3] You can show and hide the SW keyboard (the button allows two states) (136.75 KB, image/png)
2009-02-06 16:58 UTC, Petr Dvorak
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Petr Dvorak 2009-02-06 16:41:11 UTC
Hi;o),

I tried to play with a Keymap panel a little to make it little easier to use and friendly. I will send you the patch and
the other files.

Changes made:

- added "etched border" to the SW keyboard, so that it is more separated from the background [1]
- centered text in the "..." button by the action's shortcut (looks slightly better, but not too much)
- set "ContentAreaFilled" to false - otherwise the "..." button looks bad on Nimbus/GTK l&f (text "..." overlaps the
button drawn inside) [2]
- added state to the button showing the SW keyboard - now you can use it to show AND hide the SW keyboard [3]
- redesigned the icon for the "..." button (actually 2 icons are needed now due to above mentioned state addition)
Comment 1 Petr Dvorak 2009-02-06 16:41:49 UTC
Created attachment 76669 [details]
Patch
Comment 2 Petr Dvorak 2009-02-06 16:43:47 UTC
Created attachment 76670 [details]
Icon - SW keyboard hidden
Comment 3 Petr Dvorak 2009-02-06 16:44:24 UTC
Created attachment 76672 [details]
Icon - SW keyboard shown
Comment 4 Petr Dvorak 2009-02-06 16:50:33 UTC
Created attachment 76674 [details]
[1] No border is drawn around the SW keyboard
Comment 5 Petr Dvorak 2009-02-06 16:53:09 UTC
Created attachment 76675 [details]
[2] Nimbus before
Comment 6 Petr Dvorak 2009-02-06 16:53:41 UTC
Created attachment 76676 [details]
[2] Nimbus after (m aybe a color change is appropriate?)
Comment 7 Petr Dvorak 2009-02-06 16:58:17 UTC
Created attachment 76677 [details]
[3] You can show and hide the SW keyboard (the button allows two states)
Comment 8 Petr Dvorak 2009-02-06 17:05:30 UTC
Just a note:

I am not the best swing programmer, so I believe somewhere should be some code "SwingUtilities.invokeLater" or so...
When you click the "<" button for the first time, "..." flashes there for a fraction of the second and then the icon is
correctly set to "V"...
Comment 9 Max Sauer 2009-02-07 09:51:16 UTC
OK, I'll have a look.
Comment 10 Svata Dedic 2012-05-21 09:02:01 UTC
Changeset: 177159660018
Author:    Svata Dedic <sdedic@netbeans.org>
Date:      2012-05-21 11:01
Message:   Issue #158093 - Keymap panel enhancements: fixed
Implemented changes proposed in the issue. Changed layout of the special key panel a little more.
Comment 11 Quality Engineering 2012-05-25 05:43:19 UTC
Integrated into 'main-golden', will be available in build *201205250002* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/177159660018
User: Svata Dedic <sdedic@netbeans.org>
Log: Issue #158093 - Keymap panel enhancements: fixed
Implemented changes proposed in the issue. Changed layout of the special key panel a little more.