This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.
It's necessary to declare a new string constant as an identifier for the PropertyChangeEvent. The constant is going to be used for sending a new kind of notification events about transactions' completion. It is a part of changes in scope of the issue #134153 It is suggested to put the new constant here: -------------------------------------------------------- package org.netbeans.modules.xml.xam public interface Model String TRANSACTION_COMPLETED_PROPERTY = "transaction_completed"; // NOI18N --------------------------------------------------------
The changes don't affect any documentation. At least I didn't manage to find any mentioning about other events' constants.
Y01 Prepare the actual diff Y02 Don't forget about proper versioning and @since tags Y03 Write a test to show what this is good for
Created attachment 79145 [details] The diff is going to be applied
I changed the proposed name of property form TRANSACTION_COMPLETED_PROPERTY to MODEL_CHANGED_PROPERTY because it tuned out that not each transaction comes to model's changing. But the required behavior is to inform about valuable model's changes. The test in the attached diff isn't so expressive because the XAM model is too abstract. The advantage of the enhancement is more visible from real XML models based on XAM. See the explanations in the issue #134153. Some additional changes are required to JUnit tests in other modules because some tests expect a specific number of events from the model.
Y04 You need a note in apichanges.xml, increment spec version of the module, make sure all modules that use this new API depend on the new spec version. More info at: http://openide.netbeans.org/tutorial/api.html http://openide.netbeans.org/versioning-policy.html
Created attachment 79417 [details] A new diff with apichanges.xml
I've increased the specification version from 1.5.0 to 1.6.0 I've increased a dependency version at the xml.schema.model module. It uses the new constant in tests. It's the only place where it is used so far.
Reviewed, with patch ready. Raising priority to get some attention. Feel free to close as won'tfix.
The enhancement which provoked this issue was not progressing for past 6 years, closing.