This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 166409 - VCS Annotation Provider can block AWT for >5s
Summary: VCS Annotation Provider can block AWT for >5s
Status: RESOLVED FIXED
Alias: None
Product: versioncontrol
Classification: Unclassified
Component: Code (show other bugs)
Version: 6.x
Hardware: All All
: P2 blocker (vote)
Assignee: issues@versioncontrol
URL:
Keywords: PERFORMANCE
: 167971 168728 169057 169118 169997 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-06-02 15:07 UTC by Jaroslav Tulach
Modified: 2009-08-06 15:30 UTC (History)
1 user (show)

See Also:
Issue Type: DEFECT
Exception Reporter:


Attachments
Profiler snapshot (10.12 KB, application/octet-stream)
2009-06-02 15:08 UTC, Jaroslav Tulach
Details
Another slowdown, now more significant (13.02 KB, application/octet-stream)
2009-06-02 19:41 UTC, Jaroslav Tulach
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jaroslav Tulach 2009-06-02 15:07:38 UTC
I guess the reads from the Turbo cache shall be done outside of AWT thread. Otherwise we cannot guarantee it will ever 
be fast enough.
Comment 1 Jaroslav Tulach 2009-06-02 15:08:19 UTC
Created attachment 83106 [details]
Profiler snapshot
Comment 2 Jaroslav Tulach 2009-06-02 19:42:05 UTC
Created attachment 83121 [details]
Another slowdown, now more significant
Comment 3 Ondrej Vrabec 2009-06-10 10:13:52 UTC
fix for the mercurial: cdev #43f2eddcc1bf
if it works and does not cause a regression, it should be transplanted into CVS and Subversion, too
Comment 4 Quality Engineering 2009-06-11 08:45:55 UTC
Integrated into 'main-golden', will be available in build *200906110201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/43f2eddcc1bf
User: Ondrej Vrabec <ovrabec@netbeans.org>
Log: #166409 - VCS Annotation Provider can block AWT for >5s
faster icon selection - the icon is returned on basis of cached modifiedfiles and their complete scan is performed in a backgound thread asynchronously
Comment 5 Ondrej Vrabec 2009-07-08 16:33:50 UTC
fixing another related part: cdev #0a43a1b5f972
there was a synchronized method which blocked AWT
Comment 6 Quality Engineering 2009-07-10 05:43:28 UTC
Integrated into 'main-golden', will be available in build *200907100200* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/0a43a1b5f972
User: Ondrej Vrabec <ovrabec@netbeans.org>
Log: #166409 - VCS Annotation Provider can block AWT for >5s
method no longer synchronized, synchronizing the less time-consuming code
Comment 7 Ondrej Vrabec 2009-07-16 08:52:37 UTC
*** Issue 167971 has been marked as a duplicate of this issue. ***
Comment 8 Ondrej Vrabec 2009-07-17 08:51:57 UTC
*** Issue 168728 has been marked as a duplicate of this issue. ***
Comment 9 Ondrej Vrabec 2009-07-23 15:59:58 UTC
*** Issue 169057 has been marked as a duplicate of this issue. ***
Comment 10 Ondrej Vrabec 2009-07-27 17:47:25 UTC
*** Issue 169119 has been marked as a duplicate of this issue. ***
Comment 11 Ondrej Vrabec 2009-07-27 17:55:04 UTC
*** Issue 169118 has been marked as a duplicate of this issue. ***
Comment 12 Ondrej Vrabec 2009-07-31 07:05:10 UTC
issue 169119 - not a duplicate, fixed as a separate issue
issue 167971 - already fixed
issue 169118, 169057, 168728 - Subversion annotateIcon/getAllModifiedFiles
Comment 13 Ondrej Vrabec 2009-07-31 10:40:26 UTC
fixing those subversion duplicates: cdev #2e5837af39a6
Comment 14 Quality Engineering 2009-08-01 06:35:09 UTC
Integrated into 'main-golden', will be available in build *200908010201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/2e5837af39a6
User: Ondrej Vrabec <ovrabec@netbeans.org>
Log: #166409 - Subversion Annotator can block AWT
getAllModifiedFiles replaced with a cached alternate
full scan of modified files is carried on asynchronously
Comment 15 Ondrej Vrabec 2009-08-06 15:30:47 UTC
*** Issue 169997 has been marked as a duplicate of this issue. ***