This Bugzilla instance is a read-only archive of historic NetBeans bug reports. To report a bug in NetBeans please follow the project's instructions for reporting issues.

Bug 167386 - Support partial line hyperlinks
Summary: Support partial line hyperlinks
Status: RESOLVED FIXED
Alias: None
Product: projects
Classification: Unclassified
Component: Ant (show other bugs)
Version: 6.x
Hardware: All All
: P3 blocker (vote)
Assignee: Jesse Glick
URL:
Keywords: UI
Depends on: 162159 168898
Blocks:
  Show dependency tree
 
Reported: 2009-06-19 18:12 UTC by mclaassen
Modified: 2010-03-31 23:19 UTC (History)
3 users (show)

See Also:
Issue Type: ENHANCEMENT
Exception Reporter:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description mclaassen 2009-06-19 18:12:32 UTC
When Eclipse logs to the output window, lines that have something like com.mydomain.foo.java:123 in them have hyperlinks
applied to them.  Netbeans does something similar, however Eclipse will make a hyperlink only on the
'com.mydomain.foo.java:123".  Netbeans makes the entire a hyperlink.  

Now that the algorithm to find a hyperlink is more lenient (Issue 153057), I am going to have lots of hyperlinks.  This
will make it harder to pick out the stack traces.  However, if the hyperlink just comprised of the class and line
number, it would be easy to find the stack traces by its pattern.  (In a stack trace, all the hyperlinks will more or
less line up, while in my debug messages they will not.

If you really want to go crazy, stack traces could be recognized by the "\tat " and could be colored red, while the
hyperlink portion of the line would be colored blue like the rest of the hyperlinks.  This would make it even easier to
spot.

BTW, blue is the most common color for hyperlinks and I think sticking with that would be a good idea.  They are blue in
the editor.
Comment 1 mclaassen 2009-06-26 18:42:28 UTC
Here is a sample of one of my log messages:

01:37:28[00002:04] dsi.joint.io.ApacheDConnection$MyRequestEntity.writeRequest(ApacheDConnection.java:238)Sent data to
servlet

I opened my project in eclipse and the only underlined part was the part in the parentheses "ApacheDConnection.java:238"

This is very nice.  It is blue (which indicates a link), and does not create a lot of screen clutter by underlining the
entire FQN.  I would suggest this model.

This would also allow the main color of the text to show more.  So if red was desired for stack traces, black for
something else, ...  the line would be mostly that color.  But ALL hyperlinks would be in blue.
Comment 2 Jesse Glick 2009-06-26 23:15:07 UTC
Yes, this would be preferable if it is possible to implement.
Comment 3 t_h 2009-08-04 08:20:19 UTC
Fixed by core-main #c2da2c80f723
Comment 4 Jesse Glick 2009-08-04 15:52:20 UTC
No, the API was implemented. It is not yet used.
Comment 5 t_h 2009-08-04 15:57:58 UTC
I expected there will be a separate issue for ant.
Comment 6 Jesse Glick 2009-08-04 16:10:48 UTC
Well 168898 was the separate issue for the API.
Comment 7 Jesse Glick 2009-08-04 21:08:20 UTC
core-main #6aa2ecd324b5

Due to limitations in the API, the coloration is not yet quite what you want: the hyperlinks are always blue (well this
is what mclaassen wants but not what our UI specs request), and non-hyperlinked portions of stack trace lines are black
rather than red as you would expect for stderr.
Comment 8 Jesse Glick 2009-08-04 22:15:18 UTC
Tomas pointed me to the way to correct the coloration problem.
Comment 9 Quality Engineering 2009-08-05 18:02:49 UTC
Integrated into 'main-golden', will be available in build *200908051401* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/6aa2ecd324b5
User: Jesse Glick <jglick@netbeans.org>
Log: #167386: hyperlink just those portions of a line which correspond to the file and line number.
Comment 10 Quality Engineering 2009-08-06 06:01:05 UTC
Integrated into 'main-golden', will be available in build *200908060201* on http://bits.netbeans.org/dev/nightly/ (upload may still be in progress)
Changeset: http://hg.netbeans.org/main-golden/rev/761e59c99a63
User: Jesse Glick <jglick@netbeans.org>
Log: #167386 continued: t_h says use of IOColors is unnecessary.